From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Mark Salyzyn <salyzyn@android.com>, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Will Deacon <will.deacon@arm.com>, Russell King <linux@armlinux.org.uk>, Ralf Baechle <ralf@linux-mips.org>, Paul Burton <paul.burton@mips.com>, Thomas Gleixner <tglx@linutronix.de>, Peter Collingbourne <pcc@google.com> Subject: Re: [PATCH v3 18/24] arm64: Add vDSO compat support Date: Thu, 10 Jan 2019 10:39:31 +0000 [thread overview] Message-ID: <da171bd4-06fd-cebe-1f11-b744e87feff6@arm.com> (raw) In-Reply-To: <483c4226-b56d-69aa-1638-9f495d801273@android.com> On 17/12/2018 15:26, Mark Salyzyn wrote: > On 12/13/2018 08:57 AM, Vincenzo Frascino wrote: >> This patch adds vDSO compat support to the arm64 building system. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> --- >> arch/arm64/Kconfig | 1 + >> arch/arm64/Makefile | 21 +++++++++++++++++++-- >> arch/arm64/kernel/Makefile | 6 +++++- >> 3 files changed, 25 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index aafa18e2e7c4..ed9c36f0ccb9 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -103,6 +103,7 @@ config ARM64 >> select GENERIC_STRNLEN_USER >> select GENERIC_TIME_VSYSCALL >> select GENERIC_GETTIMEOFDAY >> + select GENERIC_COMPAT_VDSO >> select HANDLE_DOMAIN_IRQ >> select HARDIRQS_SW_RESEND >> select HAVE_ACPI_APEI if (ACPI && EFI) >> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile >> index 6cb9fc7e9382..814d2b0ac017 100644 >> --- a/arch/arm64/Makefile >> +++ b/arch/arm64/Makefile >> @@ -49,9 +49,23 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable) >> endif >> endif >> >> -KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst) >> +ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y) >> + CROSS_COMPILE_ARM32 ?= $(CONFIG_CROSS_COMPILE_COMPAT_VDSO:"%"=%) >> + >> + ifeq ($(CROSS_COMPILE_ARM32),) >> + $(warning CROSS_COMPILE_ARM32 not defined or empty, the compat vDSO will not be built) >> + else ifeq ($(shell which $(CROSS_COMPILE_ARM32)gcc 2> /dev/null),) >> + $(error $(CROSS_COMPILE_ARM32)gcc not found, check CROSS_COMPILE_ARM32) >> + else >> + export CROSS_COMPILE_ARM32 >> + export CONFIG_COMPAT_VDSO := y >> + compat_vdso := -DCONFIG_COMPAT_VDSO=1 >> + endif >> +endif >> + >> +KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst) $(compat_vdso) >> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables >> -KBUILD_AFLAGS += $(lseinstr) $(brokengasinst) >> +KBUILD_AFLAGS += $(lseinstr) $(brokengasinst) $(compat_vdso) >> >> KBUILD_CFLAGS += $(call cc-option,-mabi=lp64) >> KBUILD_AFLAGS += $(call cc-option,-mabi=lp64) > Does not build with clang > > Do not hard-code gcc, use $(cc-name) > $(cc-name) does not seem a supported function: Documentation/kbuild/makefiles.txt The way of enabling clang seems via CONFIG_CC_IS_CLANG. > -- Mark > -- Regards, Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Mark Salyzyn <salyzyn@android.com>, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>, Russell King <linux@armlinux.org.uk>, Ralf Baechle <ralf@linux-mips.org>, Paul Burton <paul.burton@mips.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Collingbourne <pcc@google.com> Subject: Re: [PATCH v3 18/24] arm64: Add vDSO compat support Date: Thu, 10 Jan 2019 10:39:31 +0000 [thread overview] Message-ID: <da171bd4-06fd-cebe-1f11-b744e87feff6@arm.com> (raw) Message-ID: <20190110103931.Gen9gVqZmTy_DTxOPeaA8XmQngy1I6iy3kkufjF1dvw@z> (raw) In-Reply-To: <483c4226-b56d-69aa-1638-9f495d801273@android.com> On 17/12/2018 15:26, Mark Salyzyn wrote: > On 12/13/2018 08:57 AM, Vincenzo Frascino wrote: >> This patch adds vDSO compat support to the arm64 building system. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> --- >> arch/arm64/Kconfig | 1 + >> arch/arm64/Makefile | 21 +++++++++++++++++++-- >> arch/arm64/kernel/Makefile | 6 +++++- >> 3 files changed, 25 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index aafa18e2e7c4..ed9c36f0ccb9 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -103,6 +103,7 @@ config ARM64 >> select GENERIC_STRNLEN_USER >> select GENERIC_TIME_VSYSCALL >> select GENERIC_GETTIMEOFDAY >> + select GENERIC_COMPAT_VDSO >> select HANDLE_DOMAIN_IRQ >> select HARDIRQS_SW_RESEND >> select HAVE_ACPI_APEI if (ACPI && EFI) >> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile >> index 6cb9fc7e9382..814d2b0ac017 100644 >> --- a/arch/arm64/Makefile >> +++ b/arch/arm64/Makefile >> @@ -49,9 +49,23 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable) >> endif >> endif >> >> -KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst) >> +ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y) >> + CROSS_COMPILE_ARM32 ?= $(CONFIG_CROSS_COMPILE_COMPAT_VDSO:"%"=%) >> + >> + ifeq ($(CROSS_COMPILE_ARM32),) >> + $(warning CROSS_COMPILE_ARM32 not defined or empty, the compat vDSO will not be built) >> + else ifeq ($(shell which $(CROSS_COMPILE_ARM32)gcc 2> /dev/null),) >> + $(error $(CROSS_COMPILE_ARM32)gcc not found, check CROSS_COMPILE_ARM32) >> + else >> + export CROSS_COMPILE_ARM32 >> + export CONFIG_COMPAT_VDSO := y >> + compat_vdso := -DCONFIG_COMPAT_VDSO=1 >> + endif >> +endif >> + >> +KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst) $(compat_vdso) >> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables >> -KBUILD_AFLAGS += $(lseinstr) $(brokengasinst) >> +KBUILD_AFLAGS += $(lseinstr) $(brokengasinst) $(compat_vdso) >> >> KBUILD_CFLAGS += $(call cc-option,-mabi=lp64) >> KBUILD_AFLAGS += $(call cc-option,-mabi=lp64) > Does not build with clang > > Do not hard-code gcc, use $(cc-name) > $(cc-name) does not seem a supported function: Documentation/kbuild/makefiles.txt The way of enabling clang seems via CONFIG_CC_IS_CLANG. > -- Mark > -- Regards, Vincenzo
next prev parent reply other threads:[~2019-01-10 10:39 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-13 16:57 [PATCH v3 00/24] Unify vDSOs across more architectures Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 01/24] kernel: Standardize vdso_datapage Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 02/24] kernel: Define gettimeofday vdso common code Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-14 18:15 ` Mark Salyzyn 2018-12-14 18:15 ` Mark Salyzyn 2019-01-10 10:36 ` Vincenzo Frascino 2019-01-10 10:36 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 03/24] arm64: Build vDSO with -ffixed-x18 Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 04/24] arm64: Substitute gettimeofday with C implementation Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 05/24] arm64: compat: Alloc separate pages for vectors and sigpage Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 06/24] arm64: compat: Split kuser32 Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 07/24] arm64: compat: Refactor aarch32_alloc_vdso_pages() Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 08/24] arm64: compat: Add KUSER_HELPERS config option Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 09/24] arm64: compat: Add missing syscall numbers Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 10/24] arm64: compat: Expose signal related structures Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 11/24] arm64: compat: Generate asm offsets for signals Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 12/24] lib: vdso: Add compat support Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 13/24] arm64: compat: Add vDSO Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 14/24] arm64: Refactor vDSO code Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 15/24] arm64: compat: vDSO setup for compat layer Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 16/24] arm64: elf: vDSO code page discovery Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 17/24] arm64: compat: Get sigreturn trampolines from vDSO Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 18/24] arm64: Add vDSO compat support Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-17 15:26 ` Mark Salyzyn 2018-12-17 15:26 ` Mark Salyzyn 2019-01-10 10:39 ` Vincenzo Frascino [this message] 2019-01-10 10:39 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 19/24] arm64: Enable compat vDSO support Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 20/24] arm: Add support for generic vDSO Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 21/24] mips: Introduce vdso_direct Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 22/24] clock: csrc-4k: Add support for vdso_direct Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 23/24] clock: gic-timer: " Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino 2018-12-13 16:57 ` [PATCH v3 24/24] mips: Add support for generic vDSO Vincenzo Frascino 2018-12-13 16:57 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=da171bd4-06fd-cebe-1f11-b744e87feff6@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=paul.burton@mips.com \ --cc=pcc@google.com \ --cc=ralf@linux-mips.org \ --cc=salyzyn@android.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).