From: Igor Stoppa <igor.stoppa@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: igor.stoppa@huawei.com, linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm-generic: bug: add unlikely() to BUG_ON()
Date: Sat, 8 Sep 2018 07:32:15 +0300 [thread overview]
Message-ID: <f59169de-fe5b-61b9-df36-321741682da9@gmail.com> (raw)
In-Reply-To: <CAK8P3a3u0z+Rkt0=UUG04o-uNC_K1+N=h+_Ucd23N-r2H=fTLg@mail.gmail.com>
On 07/09/18 23:41, Arnd Bergmann wrote:
> Could you add a comment about -Wmaybe-uninitialized next to the definition?
> Otherwise that is easily lost.
>
> Also, I see that the file has two separate definitions of BUG_ON(), and the
> other one does have an unlikely() in it already. Can you change both
> to do the same thing with unlikely() or not unlikely()?
ack
--
igor
next prev parent reply other threads:[~2018-09-08 4:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 19:21 [PATCH] asm-generic: bug: add unlikely() to BUG_ON() Igor Stoppa
2018-09-07 19:21 ` Igor Stoppa
2018-09-07 20:41 ` Arnd Bergmann
2018-09-07 20:41 ` Arnd Bergmann
2018-09-08 4:32 ` Igor Stoppa [this message]
2018-09-08 4:32 ` Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59169de-fe5b-61b9-df36-321741682da9@gmail.com \
--to=igor.stoppa@gmail.com \
--cc=arnd@arndb.de \
--cc=igor.stoppa@huawei.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).