linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [tip:core/rcu] include/asm-generic: Remove spin_is_locked() comment
@ 2019-02-13  8:38 tip-bot for Paul E. McKenney
  0 siblings, 0 replies; only message in thread
From: tip-bot for Paul E. McKenney @ 2019-02-13  8:38 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-arch, mingo, arnd, hpa, paulmck, tglx

Commit-ID:  728e3e6178aa5790066b642dd2ebc9e9bdacff1b
Gitweb:     https://git.kernel.org/tip/728e3e6178aa5790066b642dd2ebc9e9bdacff1b
Author:     Paul E. McKenney <paulmck@linux.ibm.com>
AuthorDate: Tue, 8 Jan 2019 10:13:44 -0800
Committer:  Paul E. McKenney <paulmck@linux.ibm.com>
CommitDate: Fri, 25 Jan 2019 15:36:04 -0800

include/asm-generic: Remove spin_is_locked() comment

The WARN_ON_SMP() comment header suggests using spin_is_locked() to
check for locks being held.  But these days we prefer lockdep_assert_held(),
so this commit removes that suggestion.

Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arch@vger.kernel.org>
---
 include/asm-generic/bug.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 20561a60db9c..0e9bd9c83870 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -211,9 +211,6 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
 /*
  * WARN_ON_SMP() is for cases that the warning is either
  * meaningless for !SMP or may even cause failures.
- * This is usually used for cases that we have
- * WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked()
- * returns 0 for uniprocessor settings.
  * It can also be used with values that are only defined
  * on SMP:
  *

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-13  8:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13  8:38 [tip:core/rcu] include/asm-generic: Remove spin_is_locked() comment tip-bot for Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).