From: sricharan@codeaurora.org (Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] drivers: platform: Configure dma operations at probe time
Date: Tue, 16 Aug 2016 17:58:51 +0530 [thread overview]
Message-ID: <000701d1f7b9$c2c4e8b0$484eba10$@codeaurora.org> (raw)
In-Reply-To: <14864888.EhQqoi8buh@avalon>
Hi Laurent,
>Hi Sricharan,
>
>Thank you for the patch.
>
>On Tuesday 09 Aug 2016 04:19:07 Sricharan R wrote:
>> Configuring DMA ops at probe time will allow deferring device probe when
>> the IOMMU isn't available yet.
>>
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>> drivers/base/dd.c | 11 +++++++++++
>> drivers/base/dma-mapping.c | 11 +++++++++++
>> include/linux/dma-mapping.h | 3 +++
>> 3 files changed, 25 insertions(+)
>>
>> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
>> index 16688f5..b9978af 100644
>> --- a/drivers/base/dd.c
>> +++ b/drivers/base/dd.c
>> @@ -19,6 +19,7 @@
>>
>> #include <linux/device.h>
>> #include <linux/delay.h>
>> +#include <linux/dma-mapping.h>
>> #include <linux/module.h>
>> #include <linux/kthread.h>
>> #include <linux/wait.h>
>> @@ -353,6 +354,10 @@ static int really_probe(struct device *dev, struct
>> device_driver *drv) if (ret)
>> goto pinctrl_bind_failed;
>>
>> + ret = dma_configure_ops(dev);
>
>Your patch doesn't remove the of_dma_configure_ops() from
>of_platform_device_create_pdata(). Unless I'm mistaken, you will then end up
>configuring the DMA ops twice, which at least on ARM will be a no-op the
>second time:
I did remove both of_dmaconfigure/deconfigure from other places, but
i did as a separate next patch [1] (should have been squashed here).
I will squash for the next repost.
[1] https://www.spinics.net/lists/arm-kernel/msg522510.html
Regards,
Sricharan
next prev parent reply other threads:[~2016-08-16 12:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 22:49 [PATCH 0/8] IOMMU Probe deferral support Sricharan R
2016-08-08 22:49 ` [PATCH 1/8] arm: dma-mapping: Don't override dma_ops in arch_setup_dma_ops() Sricharan R
2016-09-02 8:16 ` Marek Szyprowski
2016-09-07 6:24 ` Sricharan
2016-08-08 22:49 ` [PATCH 2/8] of: dma: Move range size workaround to of_dma_get_range() Sricharan R
2016-08-08 22:49 ` [PATCH 3/8] of: dma: Make of_dma_deconfigure() public Sricharan R
2016-08-08 22:49 ` [PATCH 4/8] of: dma: Split of_configure_dma() into mask and ops configuration Sricharan R
2016-08-12 7:31 ` Tomasz Figa
2016-08-12 15:18 ` Laurent Pinchart
2016-08-12 15:45 ` Sricharan
2016-09-09 6:53 ` Magnus Damm
2016-09-09 9:48 ` Sricharan
2016-08-08 22:49 ` [PATCH 5/8] drivers: platform: Configure dma operations at probe time Sricharan R
2016-08-16 9:25 ` Laurent Pinchart
2016-08-16 12:28 ` Sricharan [this message]
2016-08-08 22:49 ` [PATCH 6/8] drivers: platform: Remove call to of_dma_(con/decon)figure_ops Sricharan R
2016-08-12 7:33 ` Tomasz Figa
2016-08-12 15:42 ` Sricharan
2016-08-08 22:49 ` [PATCH 7/8] iommu: of: Handle IOMMU lookup failure with deferred probing or error Sricharan R
2016-08-12 7:46 ` Tomasz Figa
2016-08-12 15:40 ` Sricharan
2016-09-02 8:09 ` Marek Szyprowski
2016-09-07 6:16 ` Sricharan
2016-09-02 12:52 ` Marek Szyprowski
2016-09-07 6:29 ` Sricharan
2016-08-08 22:49 ` [PATCH 8/8] drivers: iommu: arm-smmu: Set iommu_ops in probe Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701d1f7b9$c2c4e8b0$484eba10$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).