From: Hans Verkuil <hverkuil@xs4all.nl>
To: Andriy Gelman <andriy.gelman@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Jeongtae Park <jtp.park@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: s5p-mfc: set V4L2_BUF_FLAG_LAST flag on final buffer
Date: Fri, 28 Jan 2022 11:13:09 +0100 [thread overview]
Message-ID: <040ba85c-6cdd-8053-30ed-194548d23a18@xs4all.nl> (raw)
In-Reply-To: <20200502194052.485-1-andriy.gelman@gmail.com>
Hi all,
I'm going through a bunch of (very) old patches in my patchwork TODO list
that for one reason or another I never processed. This patch is one of
them.
I don't feel comfortable merging this, given the follow-ups that were posted.
If someone wants to get this in anyway, then please make a new patch. I'm
marking it as 'Changes Requested' in patchwork.
Regards,
Hans
On 02/05/2020 21:40, Andriy Gelman wrote:
> From: Andriy Gelman <andriy.gelman@gmail.com>
>
> As per V4L2 api, the final buffer should set V4L2_BUF_FLAG_LAST flag.
>
> Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index 5c2a23b953a4..b3d9b3a523fe 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -614,6 +614,7 @@ static void s5p_mfc_handle_stream_complete(struct s5p_mfc_ctx *ctx)
> list_del(&mb_entry->list);
> ctx->dst_queue_cnt--;
> vb2_set_plane_payload(&mb_entry->b->vb2_buf, 0, 0);
> + mb_entry->b->flags |= V4L2_BUF_FLAG_LAST;
> vb2_buffer_done(&mb_entry->b->vb2_buf, VB2_BUF_STATE_DONE);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-01-28 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200502194052.485-1-andriy.gelman@gmail.com>
2020-06-02 15:09 ` [PATCH] media: s5p-mfc: set V4L2_BUF_FLAG_LAST flag on final buffer Nicolas Dufresne
2020-09-17 8:48 ` Hans Verkuil
2020-09-17 12:52 ` Tomasz Figa
2020-09-17 8:48 ` Hans Verkuil
2022-01-28 10:13 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040ba85c-6cdd-8053-30ed-194548d23a18@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=a.hajda@samsung.com \
--cc=andriy.gelman@gmail.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).