From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>, Peter Rosin <peda@axentia.se>
Cc: devicetree@vger.kernel.org, nsekhar@ti.com,
linux-kernel@vger.kernel.org, kishon@ti.com, t-kristo@ti.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines
Date: Thu, 17 Sep 2020 15:00:30 +0300 [thread overview]
Message-ID: <08c84d02-abe1-8399-50fb-9268c7130f8a@ti.com> (raw)
In-Reply-To: <20200916154536.m552ft2jzfsaeokr@akan>
Hi Peter & Nishanth,
On 16/09/2020 18:45, Nishanth Menon wrote:
> On 06:52-20200916, Peter Rosin wrote:
>> Hi,
>>
>> Sorry for the delay.
>>
>> On 2020-09-15 13:20, Roger Quadros wrote:
>>> Each SERDES lane mux can select upto 4 different IPs.
>>> There are 4 lanes in each J7200 SERDES. Define all
>>> the possible functions in this file.
>>>
>>> Cc: Peter Rosin <peda@axentia.se>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> include/dt-bindings/mux/mux-j7200-wiz.h | 29 +++++++++++++++++++++++++
>>> 1 file changed, 29 insertions(+)
>>> create mode 100644 include/dt-bindings/mux/mux-j7200-wiz.h
>>>
>>> diff --git a/include/dt-bindings/mux/mux-j7200-wiz.h b/include/dt-bindings/mux/mux-j7200-wiz.h
>>> new file mode 100644
>>> index 000000000000..b091b1185a36
>>> --- /dev/null
>>> +++ b/include/dt-bindings/mux/mux-j7200-wiz.h
>>> @@ -0,0 +1,29 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +/*
>>> + * This header provides constants for J7200 WIZ.
>>> + */
>>> +
>>> +#ifndef _DT_BINDINGS_J7200_WIZ
>>> +#define _DT_BINDINGS_J7200_WIZ
>>> +
>>> +#define SERDES0_LANE0_QSGMII_LANE3 0x0
>>> +#define SERDES0_LANE0_PCIE1_LANE0 0x1
>>> +#define SERDES0_LANE0_IP3_UNUSED 0x2
>>> +#define SERDES0_LANE0_IP4_UNUSED 0x3
>>> +
>>> +#define SERDES0_LANE1_QSGMII_LANE4 0x0
>>> +#define SERDES0_LANE1_PCIE1_LANE1 0x1
>>> +#define SERDES0_LANE1_IP3_UNUSED 0x2
>>> +#define SERDES0_LANE1_IP4_UNUSED 0x3
>>> +
>>> +#define SERDES0_LANE2_QSGMII_LANE1 0x0
>>> +#define SERDES0_LANE2_PCIE1_LANE2 0x1
>>> +#define SERDES0_LANE2_IP3_UNUSED 0x2
>>> +#define SERDES0_LANE2_IP4_UNUSED 0x3
>>> +
>>> +#define SERDES0_LANE3_QSGMII_LANE2 0x0
>>> +#define SERDES0_LANE3_PCIE1_LANE3 0x1
>>> +#define SERDES0_LANE3_USB 0x2
>>> +#define SERDES0_LANE3_IP4_UNUSED 0x3
>>> +
>>> +#endif /* _DT_BINDINGS_J7200_WIZ */
>>
>> Should not the defines start with J7200_WIZ? SERDES0 seems like a too
>> generic prefix, at least to me.
>
> Thanks, good point. I am not sure if WIZ should even be used.. It is
> a TI internal prefix for various serdes solutions, but I agree that
> SERDES0 is too generic a terminology. That said, we should cleanup
> include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing
> j7200 changes.
>
I'm planning to put all TI SERDES definitions in one header file "ti-serdes-mux.h"
and add SOC specific prefixes to the macros.
This will mean some churn in the existing DT files. (only 2 so far)
Are you guys OK if I do the change in one patch to avoid a broken build in between.
You guys can then decide whose tree it goes through.
The new SoC addition will be separate of course.
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 12:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 11:20 [PATCH v3 0/6] arm64: dts: ti: Add USB support for J7200 EVM Roger Quadros
2020-09-15 11:20 ` [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines Roger Quadros
2020-09-16 4:52 ` Peter Rosin
2020-09-16 15:45 ` Nishanth Menon
2020-09-17 9:45 ` Peter Rosin
2020-09-17 12:27 ` Nishanth Menon
2020-09-17 12:53 ` Peter Rosin
2020-09-17 13:00 ` Nishanth Menon
2020-09-17 10:17 ` Kishon Vijay Abraham I
2020-09-17 12:36 ` Nishanth Menon
2020-09-17 12:00 ` Roger Quadros [this message]
2020-09-17 12:14 ` Nishanth Menon
2020-09-17 12:37 ` Peter Rosin
2020-09-17 12:51 ` Nishanth Menon
2020-09-15 11:20 ` [PATCH v3 2/6] arm64: dts: ti: k3-j7200-main: Add SERDES lane control mux Roger Quadros
2020-09-15 11:20 ` [PATCH v3 3/6] arm64: dts: ti: k3-j7200-main.dtsi: Add USB to SERDES lane MUX Roger Quadros
2020-09-15 11:20 ` [PATCH v3 4/6] arm64: dts: ti: k3-j7200-main: Add USB controller Roger Quadros
2020-09-15 11:20 ` [PATCH v3 5/6] arm64: dts: ti: k3-j7200-common-proc-board: Configure the SERDES lane function Roger Quadros
2020-09-15 11:20 ` [PATCH v3 6/6] arm64: dts: ti: k3-j7200-common-proc-board: Add USB support Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08c84d02-abe1-8399-50fb-9268c7130f8a@ti.com \
--to=rogerq@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).