From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Miles Chen <miles.chen@mediatek.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function
Date: Tue, 27 Sep 2022 12:39:41 +0200 [thread overview]
Message-ID: <0a1618c4-b808-56bd-e89f-560b0423191d@collabora.com> (raw)
In-Reply-To: <20220926102523.2367530-4-wenst@chromium.org>
Il 26/09/22 12:25, Chen-Yu Tsai ha scritto:
> top_early_divs are registered in the CLK_OF_DECLARE_DRIVER() half of the
> topckgen clk driver. Don't try to register it again in the actual probe
> function. This gets rid of the "Trying to register duplicate clock ..."
> warning.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Can't we simply remove the CLK_OF_DECLARE_DRIVER() and top_init_early entirely,
and transfer TOP_CSW_F26M_D2 to top_divs[] instead?
I get that systimer concern and we have something similar in MT8195, where the
TOP_CLK26M_D2 is registered "late".
Getting back to MT8192, TOP_CSW_F26M_D2 seems to be used only for:
1. systimer
2. SPMI MST (registered "late").
Being it a fixed factor clock, parented to another fixed clock, it doesn't
even have any ON/OFF switch, so I think it would be actually possible to go
for the proposed removal... which would further improve this cleanup.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-27 10:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 10:25 [PATCH 0/6] clk: mediatek: More cleanups Chen-Yu Tsai
2022-09-26 10:25 ` [PATCH 1/6] clk: mediatek: fix unregister function in mtk_clk_register_dividers cleanup Chen-Yu Tsai
2022-09-27 10:39 ` AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 2/6] clk: mediatek: Migrate remaining clk_unregister_*() to clk_hw_unregister_*() Chen-Yu Tsai
2022-09-27 10:40 ` AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function Chen-Yu Tsai
2022-09-27 10:39 ` AngeloGioacchino Del Regno [this message]
2022-09-28 1:55 ` Miles Chen
2022-09-28 7:50 ` Chen-Yu Tsai
2022-09-30 7:09 ` Miles Chen
2022-09-28 6:51 ` Chen-Yu Tsai
2022-09-26 10:25 ` [PATCH 4/6] clk: mediatek: mt8192: Avoid duplicate OF clk provider for topckgen Chen-Yu Tsai
2022-09-26 10:25 ` [PATCH 5/6] clk: mediatek: mt8192: deduplicate parent clock lists Chen-Yu Tsai
2022-09-27 10:39 ` AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 6/6] clk: mediatek: mt8192: Implement error handling in probe functions Chen-Yu Tsai
2022-09-27 10:39 ` AngeloGioacchino Del Regno
2022-09-29 4:36 ` [PATCH 0/6] clk: mediatek: More cleanups Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a1618c4-b808-56bd-e89f-560b0423191d@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).