linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wenst@chromium.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Miles Chen <miles.chen@mediatek.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] clk: mediatek: fix unregister function in mtk_clk_register_dividers cleanup
Date: Mon, 26 Sep 2022 18:25:18 +0800	[thread overview]
Message-ID: <20220926102523.2367530-2-wenst@chromium.org> (raw)
In-Reply-To: <20220926102523.2367530-1-wenst@chromium.org>

When the cleanup paths for the various clk register APIs in the MediaTek
clk library were added, the one in the dividers type used the wrong type
of unregister function. This would result in incorrect dereferencing of
the clk pointer and freeing of invalid pointers.

Fix this by switching to the correct type of clk unregistration call.

Fixes: 3c3ba2ab0226 ("clk: mediatek: mtk: Implement error handling in register APIs")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 drivers/clk/mediatek/clk-mtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c
index 3a8875b6c37f..174d0645be38 100644
--- a/drivers/clk/mediatek/clk-mtk.c
+++ b/drivers/clk/mediatek/clk-mtk.c
@@ -393,7 +393,7 @@ int mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, int num,
 		if (IS_ERR_OR_NULL(clk_data->hws[mcd->id]))
 			continue;
 
-		mtk_clk_unregister_composite(clk_data->hws[mcd->id]);
+		clk_hw_unregister_divider(clk_data->hws[mcd->id]);
 		clk_data->hws[mcd->id] = ERR_PTR(-ENOENT);
 	}
 
-- 
2.37.3.998.g577e59143f-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-26 10:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 10:25 [PATCH 0/6] clk: mediatek: More cleanups Chen-Yu Tsai
2022-09-26 10:25 ` Chen-Yu Tsai [this message]
2022-09-27 10:39   ` [PATCH 1/6] clk: mediatek: fix unregister function in mtk_clk_register_dividers cleanup AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 2/6] clk: mediatek: Migrate remaining clk_unregister_*() to clk_hw_unregister_*() Chen-Yu Tsai
2022-09-27 10:40   ` AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 3/6] clk: mediatek: mt8192: Do not re-register top_early_divs in probe function Chen-Yu Tsai
2022-09-27 10:39   ` AngeloGioacchino Del Regno
2022-09-28  1:55     ` Miles Chen
2022-09-28  7:50       ` Chen-Yu Tsai
2022-09-30  7:09         ` Miles Chen
2022-09-28  6:51     ` Chen-Yu Tsai
2022-09-26 10:25 ` [PATCH 4/6] clk: mediatek: mt8192: Avoid duplicate OF clk provider for topckgen Chen-Yu Tsai
2022-09-26 10:25 ` [PATCH 5/6] clk: mediatek: mt8192: deduplicate parent clock lists Chen-Yu Tsai
2022-09-27 10:39   ` AngeloGioacchino Del Regno
2022-09-26 10:25 ` [PATCH 6/6] clk: mediatek: mt8192: Implement error handling in probe functions Chen-Yu Tsai
2022-09-27 10:39   ` AngeloGioacchino Del Regno
2022-09-29  4:36 ` [PATCH 0/6] clk: mediatek: More cleanups Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926102523.2367530-2-wenst@chromium.org \
    --to=wenst@chromium.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).