From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
<alexandre.torgue@foss.st.com>, <robh+dt@kernel.org>,
<Oleksii_Moisieiev@epam.com>, <linus.walleij@linaro.org>,
<gregkh@linuxfoundation.org>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <loic.pallardy@st.com>,
<devicetree@vger.kernel.org>, <mark.rutland@arm.com>,
<arnd@arndb.de>
Subject: Re: [RFC PATCH 6/7] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards
Date: Thu, 22 Dec 2022 15:42:09 +0100 [thread overview]
Message-ID: <0bff5b2d-2837-57cb-5434-58158acc1483@foss.st.com> (raw)
In-Reply-To: <2e7c901c-e322-ded6-b170-6d2436d74c0f@kernel.org>
Hello,
On 12/22/22 11:30, Krzysztof Kozlowski wrote:
> On 21/12/2022 18:30, Gatien Chevallier wrote:
>> The STM32 System Bus is an internal bus on which devices are connected.
>> ETZPC is a peripheral overseeing the firewall bus that configures
>> and control access to the peripherals connected on it.
>>
>> For more information on which peripheral is securable, please read
>> the STM32MP15 reference manual.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> ---
>> arch/arm/boot/dts/stm32mp151.dtsi | 2737 +++++++++++++++--------------
>> 1 file changed, 1406 insertions(+), 1331 deletions(-)
>>
>> - lptimer1: timer@40009000 {
>> + etzpc: etzpc@5c007000 {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Will change to etzpc: bus@5c007000 in V3
>
>> + compatible = "st,stm32mp15-sys-bus";
>> + reg = <0x5c007000 0x400>;
>> #address-cells = <1>;
>> - #size-cells = <0>;
>> - compatible = "st,stm32-lptimer";
>> - reg = <0x40009000 0x400>;
>> - interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>;
>> - clocks = <&rcc LPTIM1_K>;
>> - clock-names = "mux";
>> - wakeup-source;
>> - status = "disabled";
>
> Why entire bus is disabled? What resources do you miss?
Here, I did not want to modify the status of the nodes in the device
tree. Nodes that are default enabled in the SoC device tree stay enabled
and vice-versa. IMO think this patch should not include these kind of
changes in its scope. I describe the bus and the peripherals connected
to it, nothing more :)
>
>> + #size-cells = <1>;
>> + feature-domain-controller;
>> + #feature-domain-cells = <2>;
>> + ranges;
>>
> Best regards,
> Krzysztof
>
Best regards,
Gatien
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-22 15:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 17:30 [RFC PATCH 0/7] Introduce STM32 system bus Gatien Chevallier
2022-12-21 17:30 ` [RFC PATCH 1/7] dt-bindings: Document common device controller bindings Gatien Chevallier
2022-12-22 10:22 ` Krzysztof Kozlowski
2022-12-22 13:01 ` Gatien CHEVALLIER
2022-12-22 13:51 ` Krzysztof Kozlowski
2022-12-21 17:30 ` [RFC PATCH 2/7] dt-bindings: bus: add STM32 System Bus Gatien Chevallier
2022-12-21 20:09 ` Rob Herring
2022-12-22 10:24 ` Krzysztof Kozlowski
2022-12-22 13:39 ` Gatien CHEVALLIER
2022-12-22 13:55 ` Krzysztof Kozlowski
2022-12-21 17:30 ` [RFC PATCH 3/7] dt-bindings: bus: add STM32MP15 ETZPC firewall bus bindings Gatien Chevallier
2022-12-22 10:26 ` Krzysztof Kozlowski
2022-12-22 13:51 ` Gatien CHEVALLIER
2022-12-22 13:57 ` Krzysztof Kozlowski
2023-01-04 13:43 ` Gatien CHEVALLIER
2023-01-05 21:53 ` Krzysztof Kozlowski
2023-01-09 11:54 ` Gatien CHEVALLIER
2023-01-11 12:32 ` Krzysztof Kozlowski
2023-01-16 14:06 ` Gatien CHEVALLIER
2022-12-21 17:30 ` [RFC PATCH 4/7] dt-bindings: bus: add STM32MP13 " Gatien Chevallier
2022-12-22 10:26 ` Krzysztof Kozlowski
2022-12-22 13:53 ` Gatien CHEVALLIER
2022-12-21 17:30 ` [RFC PATCH 5/7] bus: stm32_sys_bus: add support for STM32MP15 and STM32MP13 system bus Gatien Chevallier
2022-12-22 10:28 ` Krzysztof Kozlowski
2022-12-22 14:30 ` Gatien CHEVALLIER
2022-12-22 15:19 ` Krzysztof Kozlowski
2022-12-21 17:30 ` [RFC PATCH 6/7] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Gatien Chevallier
2022-12-22 10:30 ` Krzysztof Kozlowski
2022-12-22 14:42 ` Gatien CHEVALLIER [this message]
2022-12-22 15:21 ` Krzysztof Kozlowski
2022-12-22 15:57 ` Gatien CHEVALLIER
2022-12-22 16:00 ` Krzysztof Kozlowski
2022-12-21 17:30 ` [RFC PATCH 7/7] ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Gatien Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bff5b2d-2837-57cb-5434-58158acc1483@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=Oleksii_Moisieiev@epam.com \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).