From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: clayc@hpe.com, linux-kernel@vger.kernel.org, soc@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
verdun@hpe.com, nick.hawkins@hpe.com, arnd@arndb.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux@armlinux.org.uk, olof@lixom.net
Subject: Re: [PATCH 2/5] dt-bindings: soc: hpe: hpe,gxp-srom.yaml
Date: Tue, 10 Jan 2023 10:49:36 +0100 [thread overview]
Message-ID: <110af65f-9c18-524d-a073-ef7be60d1f5a@linaro.org> (raw)
In-Reply-To: <20230110042533.12894-3-clayc@hpe.com>
On 10/01/2023 05:25, clayc@hpe.com wrote:
> From: Clay Chang <clayc@hpe.com>
>
> Document binding to support SROM driver in GXP.
>
> Signed-off-by: Clay Chang <clayc@hpe.com>
> ---
> .../bindings/soc/hpe/hpe,gxp-srom.yaml | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
> new file mode 100644
> index 000000000000..14ad97d595c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
Don't drop stuff to soc. Put it in respective directories. This also
applies to your driver.
SROM controllers go to memory-controllers. What is this, I have no clue.
"SROM Control Register" is not helping me.
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/hpe/hpe,gxp-srom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP SoC SROM Control Register
> +
> +maintainers:
> + - Clay Chang <clayc@hpe.com>
> +
> +description: |+
> + The SROM control register can be used to configure LPC related legacy
> + I/O registers.
And why this is a hardware? No, you now add fake devices to be able to
write some stuff from user-space... Otherwise this needs proper hardware
description.
> +
> +properties:
> + compatible:
> + items:
Drop items, you have only one item.
> + - const: hpe,gxp-srom
> +
> + reg:
> + items:
> + - description: SROM LPC Configuration Registers
Drop items and description. Just maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + srom: srom@80fc0000 {
> + compatible = "hpe,gxp-srom";
> + reg = <0x80fc0000 0x100>;
> + };
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-10 9:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 4:25 [PATCH 0/5] ARM: Add GXP SROM Support clayc
2023-01-10 4:25 ` [PATCH 1/5] soc: hpe: Add GXP SROM Control Register Driver clayc
2023-01-10 9:46 ` Krzysztof Kozlowski
2023-01-12 12:46 ` Clay Chang
2023-01-10 4:25 ` [PATCH 2/5] dt-bindings: soc: hpe: hpe,gxp-srom.yaml clayc
2023-01-10 9:49 ` Krzysztof Kozlowski [this message]
2023-01-12 13:16 ` Clay Chang
2023-01-12 13:37 ` Arnd Bergmann
2023-01-16 13:42 ` Clay Chang
2023-01-16 15:18 ` Arnd Bergmann
2023-01-19 7:39 ` Clay Chang
2023-01-19 7:56 ` Arnd Bergmann
2023-01-10 4:25 ` [PATCH 3/5] ARM: dts: hpe: Add SROM Driver clayc
2023-01-10 4:25 ` [PATCH 4/5] ARM: multi_v7_defconfig: Add GXP " clayc
2023-01-10 9:50 ` Krzysztof Kozlowski
2023-01-12 13:17 ` Clay Chang
2023-01-10 4:25 ` [PATCH 5/5] MAINTAINERS: Add maintainer of GXP SROM support clayc
2023-01-10 9:51 ` Krzysztof Kozlowski
2023-01-12 13:18 ` Clay Chang
2023-01-20 2:21 ` [PATCH 0/5] ARM: Add GXP SROM Support Andrew Jeffery
2023-01-31 13:46 ` Clay Chang
2023-02-01 13:28 ` Clay Chang
2023-02-02 1:12 ` Andrew Jeffery
2023-02-02 15:25 ` Clay Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110af65f-9c18-524d-a073-ef7be60d1f5a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=clayc@hpe.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nick.hawkins@hpe.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).