From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: "Robin Murphy" <robin.murphy@arm.com>,
wens@kernel.org, "Heiko Stübner" <heiko@sntech.de>,
"Markus Reichl" <m.reichl@fivetechno.de>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v4] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4
Date: Fri, 15 Jul 2022 19:16:20 +0200 [thread overview]
Message-ID: <115AD6A4-021B-4879-BFB5-BC7689A0203E@kohlschutter.com> (raw)
In-Reply-To: <73F9AED0-D2A8-4294-B6E1-1B92D2A36529@kohlschutter.com>
OK, this took me a while to figure out.
When no undervoltage limit is configured, I can reliably trigger the initialization bug upon boot.
When the limit is set to 3.0V, it rarely occurs, but just after I send the v3 patch, I was able to reproduce...
> Am 15.07.2022 um 19:12 schrieb Christian Kohlschütter <christian@kohlschutter.com>:
>
> mmc/SD-card initialization may fail on NanoPi R4S with
> "mmc1: problem reading SD Status register" /
> "mmc1: error -110 whilst initialising SD card"
> either on cold boot or after a reboot.
>
> Moreover, the system would also sometimes hang upon reboot.
>
> This is prevented by setting an explicit undervoltage protection limit
> for the SD-card-specific vcc3v0_sd voltage regulator.
>
> Set the undervoltage protection limit to 2.7V, which is the minimum
> permissible SD card operating voltage.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
> mode change 100644 => 100755 arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> old mode 100644
> new mode 100755
> index 8c0ff6c96e03..669c74ce4d13
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
> @@ -73,6 +73,10 @@ vcc3v0_sd: vcc3v0-sd {
> regulator-always-on;
> regulator-min-microvolt = <3000000>;
> regulator-max-microvolt = <3000000>;
> +
> + // must be configured or SD card may fail to initialize occasionally
> + regulator-uv-protection-microvolt = <2700000>;
> +
> regulator-name = "vcc3v0_sd";
> vin-supply = <&vcc3v3_sys>;
> };
> --
> 2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-15 17:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 22:22 [PATCH] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4 Christian Kohlschütter
2022-07-13 23:41 ` Heiko Stübner
2022-07-14 11:41 ` Robin Murphy
2022-07-14 12:14 ` Christian Kohlschütter
2022-07-14 13:14 ` Markus Reichl
2022-07-14 13:50 ` Robin Murphy
2022-07-14 16:24 ` Christian Kohlschütter
2022-07-14 16:26 ` [PATCH v2] " Christian Kohlschütter
2022-07-14 16:44 ` Christian Loehle
2022-07-14 17:20 ` Christian Kohlschütter
2022-07-15 17:02 ` Christian Loehle
2022-07-14 17:02 ` Chen-Yu Tsai
2022-07-14 17:35 ` Robin Murphy
2022-07-14 17:57 ` Christian Kohlschütter
2022-07-14 23:44 ` Robin Murphy
2022-07-15 17:01 ` [PATCH v3] " Christian Kohlschütter
2022-07-15 17:12 ` [PATCH v4] " Christian Kohlschütter
2022-07-15 17:16 ` Christian Kohlschütter [this message]
2022-07-15 18:11 ` Robin Murphy
2022-07-15 18:57 ` Christian Kohlschütter
2022-07-15 18:57 ` Robin Murphy
2022-07-15 19:04 ` Christian Kohlschütter
2022-07-15 19:38 ` Robin Murphy
2022-07-15 22:33 ` Christian Kohlschütter
2022-07-16 0:24 ` Christian Kohlschütter
2022-07-16 19:43 ` [PATCH v5] " Christian Kohlschütter
2022-07-18 12:04 ` [PATCH v6] " Christian Kohlschütter
2022-07-18 12:05 ` Christian Kohlschütter
2022-07-18 21:04 ` Christian Kohlschütter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115AD6A4-021B-4879-BFB5-BC7689A0203E@kohlschutter.com \
--to=christian@kohlschutter.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=robin.murphy@arm.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).