From: Christian Loehle <CLoehle@hyperstone.com>
To: "Christian Kohlschütter" <christian@kohlschutter.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Markus Reichl" <m.reichl@fivetechno.de>,
"Heiko Stübner" <heiko@sntech.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Linux MMC List" <linux-mmc@vger.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4
Date: Thu, 14 Jul 2022 16:44:08 +0000 [thread overview]
Message-ID: <eec07acea8694191a75880acc397dafe@hyperstone.com> (raw)
In-Reply-To: <A9634366-A012-43D2-B253-8BB9BF6005C7@kohlschutter.com>
I only briefly skimmed the discussion, but does this mean that a soft-reset (CMD0) of a UHS (post-voltage-switch) will not work?
(As the card/spec requires a power-cycle by the host which will not come, right?)
Can you try this real quick? I can give you a mmc-utils snippet if you have trouble issuing one.
If that does indeed not work I think the general approach is to disable uhs in the dts or at least document that.
Regards,
Christian
-----Original Message-----
From: Christian Kohlschütter <christian@kohlschutter.com>
Sent: Donnerstag, 14. Juli 2022 18:27
To: Robin Murphy <robin.murphy@arm.com>; Markus Reichl <m.reichl@fivetechno.de>; Heiko Stübner <heiko@sntech.de>; linux-arm-kernel@lists.infradead.org; linux-rockchip@lists.infradead.org; linux-kernel@vger.kernel.org; Linux MMC List <linux-mmc@vger.kernel.org>
Subject: [PATCH v2] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4
mmc/SD-card initialization may fail on NanoPi r4s with
"mmc1: problem reading SD Status register" /
"mmc1: error -110 whilst initialising SD card"
Moreover, rebooting would also sometimes hang.
This is caused by the gpio entry for the vcc3v0-sd regulator;
even though it appears to be the correct GPIO pin, the presence
of the binding causes these errors.
Fix the regulator to drop the gpio binding and add a comment
to prevent accidental reintroduction of that entry.
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 8c0ff6c96e03..d5f8a62e01be 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -67,7 +67,7 @@ vcc1v8_s3: vcc1v8-s3 {
vcc3v0_sd: vcc3v0-sd {
compatible = "regulator-fixed";
enable-active-high;
- gpio = <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>;
+ // gpio = <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>; // breaks SDHC card support
pinctrl-names = "default";
pinctrl-0 = <&sdmmc0_pwr_h>;
regulator-always-on;
--
2.36.1
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-14 16:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 22:22 [PATCH] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4 Christian Kohlschütter
2022-07-13 23:41 ` Heiko Stübner
2022-07-14 11:41 ` Robin Murphy
2022-07-14 12:14 ` Christian Kohlschütter
2022-07-14 13:14 ` Markus Reichl
2022-07-14 13:50 ` Robin Murphy
2022-07-14 16:24 ` Christian Kohlschütter
2022-07-14 16:26 ` [PATCH v2] " Christian Kohlschütter
2022-07-14 16:44 ` Christian Loehle [this message]
2022-07-14 17:20 ` Christian Kohlschütter
2022-07-15 17:02 ` Christian Loehle
2022-07-14 17:02 ` Chen-Yu Tsai
2022-07-14 17:35 ` Robin Murphy
2022-07-14 17:57 ` Christian Kohlschütter
2022-07-14 23:44 ` Robin Murphy
2022-07-15 17:01 ` [PATCH v3] " Christian Kohlschütter
2022-07-15 17:12 ` [PATCH v4] " Christian Kohlschütter
2022-07-15 17:16 ` Christian Kohlschütter
2022-07-15 18:11 ` Robin Murphy
2022-07-15 18:57 ` Christian Kohlschütter
2022-07-15 18:57 ` Robin Murphy
2022-07-15 19:04 ` Christian Kohlschütter
2022-07-15 19:38 ` Robin Murphy
2022-07-15 22:33 ` Christian Kohlschütter
2022-07-16 0:24 ` Christian Kohlschütter
2022-07-16 19:43 ` [PATCH v5] " Christian Kohlschütter
2022-07-18 12:04 ` [PATCH v6] " Christian Kohlschütter
2022-07-18 12:05 ` Christian Kohlschütter
2022-07-18 21:04 ` Christian Kohlschütter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec07acea8694191a75880acc397dafe@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=christian@kohlschutter.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).