linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
@ 2020-03-25 13:29 Colin King
  2020-03-25 15:03 ` Codrin.Ciubotariu
  2020-03-25 21:51 ` Applied "ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-03-25 13:29 UTC (permalink / raw)
  To: Codrin Ciubotariu, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Nicolas Ferre, Alexandre Belloni,
	Ludovic Desroches, alsa-devel, linux-arm-kernel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The signed 1 bit bitfields should be unsigned, so make them unsigned.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
index befc2a3a05b0..3cb63886195f 100644
--- a/sound/soc/atmel/mchp-i2s-mcc.c
+++ b/sound/soc/atmel/mchp-i2s-mcc.c
@@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
 	unsigned int				frame_length;
 	int					tdm_slots;
 	int					channels;
-	int					gclk_use:1;
-	int					gclk_running:1;
-	int					tx_rdy:1;
-	int					rx_rdy:1;
+	unsigned int				gclk_use:1;
+	unsigned int				gclk_running:1;
+	unsigned int				tx_rdy:1;
+	unsigned int				rx_rdy:1;
 };
 
 static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
  2020-03-25 13:29 [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned Colin King
@ 2020-03-25 15:03 ` Codrin.Ciubotariu
  2020-03-25 21:51 ` Applied "ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Codrin.Ciubotariu @ 2020-03-25 15:03 UTC (permalink / raw)
  To: colin.king, lgirdwood, broonie, perex, tiwai, Nicolas.Ferre,
	alexandre.belloni, Ludovic.Desroches, alsa-devel,
	linux-arm-kernel
  Cc: kernel-janitors, linux-kernel

On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
>          unsigned int                            frame_length;
>          int                                     tdm_slots;
>          int                                     channels;
> -       int                                     gclk_use:1;
> -       int                                     gclk_running:1;
> -       int                                     tx_rdy:1;
> -       int                                     rx_rdy:1;
> +       unsigned int                            gclk_use:1;
> +       unsigned int                            gclk_running:1;
> +       unsigned int                            tx_rdy:1;
> +       unsigned int                            rx_rdy:1;
>   };
> 
>   static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned" to the asoc tree
  2020-03-25 13:29 [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned Colin King
  2020-03-25 15:03 ` Codrin.Ciubotariu
@ 2020-03-25 21:51 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-03-25 21:51 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Alexandre Belloni, alsa-devel, linux-kernel, kernel-janitors,
	Liam Girdwood, Jaroslav Kysela, Ludovic Desroches, Mark Brown,
	Takashi Iwai, Codrin Ciubotariu, linux-arm-kernel

The patch

   ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 633fddee7355e46a5b5ec471abb58d65e1e41012 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 25 Mar 2020 13:29:13 +0000
Subject: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned

The signed 1 bit bitfields should be unsigned, so make them unsigned.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Link: https://lore.kernel.org/r/20200325132913.110115-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
index befc2a3a05b0..3cb63886195f 100644
--- a/sound/soc/atmel/mchp-i2s-mcc.c
+++ b/sound/soc/atmel/mchp-i2s-mcc.c
@@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
 	unsigned int				frame_length;
 	int					tdm_slots;
 	int					channels;
-	int					gclk_use:1;
-	int					gclk_running:1;
-	int					tx_rdy:1;
-	int					rx_rdy:1;
+	unsigned int				gclk_use:1;
+	unsigned int				gclk_running:1;
+	unsigned int				tx_rdy:1;
+	unsigned int				rx_rdy:1;
 };
 
 static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-25 21:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 13:29 [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned Colin King
2020-03-25 15:03 ` Codrin.Ciubotariu
2020-03-25 21:51 ` Applied "ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).