[PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Jerry Ray]

Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board
description yaml file.

Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
---
v5->v6:
 - No code change - patch prefix naming modified to match with others.
v4->v5:
 - No change
v3->v4:
 - No change
v2->v3:
 - No change
v1->v2:
 - Added Device Tree documentation for Microchip SAMA5D3-EDS board
---
 Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
index 2b7848bb7769..c7f067e13d20 100644
--- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
+++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
@@ -139,6 +139,13 @@ properties:
           - const: atmel,at91sam9g20
           - const: atmel,at91sam9
 
+      - description: Microchip SAMA5D3 Ethernet Development System Board
+        items:
+          - const: microchip,sama5d3-eds
+          - const: atmel,sama5d36
+          - const: atmel,sama5d3
+          - const: atmel,sama5
+
       - items:
           - enum:
               - atmel,sama5d31
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Jerry Ray]

The SAMA5D3-EDS board is an Ethernet Development Platform allowing for
evaluating many Microchip ethernet switch and PHY products.  Various
daughter cards can connect up via an RGMII connector or an RMII connector.

The EDS board is not intended for stand-alone use and has no ethernet
capabilities when no daughter board is connected.  As such, this device
tree is intended to be used with a DT overlay defining the add-on board.
To better ensure consistency, some items are defined here as a form of
documentation so that all add-on overlays will use the same terms.

Google search keywords: "Microchip SAMA5D3-EDS"

Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
---
v5->v6:
 - Replaced underscores in names where I can, improving naming.
v4->v5:
 - patch now applies to v6.0-rc2
v3->v4:
 - Fixed regulators as necessary to get the board to boot from SD Card.
v2->v3:
 - Alphabetized pinctrl entries.
 - cleaned up a warning in the regulators section.
 - License tweaked to 'OR MIT'
 - Included Makefile change
v1->v2:
 - Modified the compatible field in the device tree to reflect Microchip
   Ethernet Development System Board.
---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 +++++++++++++++++++++++++
 2 files changed, 310 insertions(+)
 create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 05d8aef6e5d2..e92e639a2dc3 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
 	at91-sama5d2_icp.dtb \
 	at91-sama5d2_ptc_ek.dtb \
 	at91-sama5d2_xplained.dtb \
+	at91-sama5d3_eds.dtb \
 	at91-sama5d3_ksz9477_evb.dtb \
 	at91-sama5d3_xplained.dtb \
 	at91-dvk_som60.dtb \
diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts
new file mode 100644
index 000000000000..b4fe1c5f2997
--- /dev/null
+++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
@@ -0,0 +1,309 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
+ *    Development System board.
+ *
+ * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
+ *
+ * Author: Jerry Ray <jerry.ray@microchip.com>
+ */
+/dts-v1/;
+#include "sama5d36.dtsi"
+
+/ {
+	model = "SAMA5D3 Ethernet Development System";
+	compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
+		     "atmel,sama5d3", "atmel,sama5";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	clocks {
+		slow_xtal {
+			clock-frequency = <32768>;
+		};
+
+		main_xtal {
+			clock-frequency = <12000000>;
+		};
+	};
+
+	gpio {
+		compatible = "gpio-keys";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_key_gpio>;
+
+		button-3 {
+			label = "PB_USER";
+			gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
+			linux,code = <0x104>;
+			wakeup-source;
+		};
+	};
+
+	memory@20000000 {
+		reg = <0x20000000 0x10000000>;
+	};
+
+	vcc_3v3_reg: buck-regulator-1 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	vcc_2v5_reg: ldo-regulator-2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_2V5";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+		vin-supply = <&vcc_3v3_reg>;
+	};
+
+	vcc_1v8_reg: ldo-regulator-3 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_1V8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		vin-supply = <&vcc_3v3_reg>;
+	};
+
+	vcc_1v2_reg: buck-regulator-4 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_1V2";
+		regulator-min-microvolt = <1200000>;
+		regulator-max-microvolt = <1200000>;
+		regulator-always-on;
+	};
+
+	vcc_mmc0_reg: fixedregulator-mmc0 {
+		compatible = "regulator-fixed";
+		regulator-name = "mmc0-card-supply";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>;
+		gpio = <&pioE 2 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&can0 {
+	status = "okay";
+};
+
+&dbgu {
+	status = "okay";
+};
+
+&ebi {
+	pinctrl-0 = <&pinctrl_ebi_nand_addr>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	nand_controller: nand-controller {
+		status = "okay";
+
+		nand@3 {
+			reg = <0x3 0x0 0x2>;
+			atmel,rb = <0>;
+			nand-bus-width = <8>;
+			nand-ecc-mode = "hw";
+			nand-ecc-strength = <4>;
+			nand-ecc-step-size = <512>;
+			nand-on-flash-bbt;
+			label = "atmel_nand";
+
+			partitions {
+				compatible = "fixed-partitions";
+				#address-cells = <1>;
+				#size-cells = <1>;
+
+				at91bootstrap@0 {
+					label = "at91bootstrap";
+					reg = <0x0 0x40000>;
+				};
+
+				bootloader@40000 {
+					label = "bootloader";
+					reg = <0x40000 0xc0000>;
+				};
+
+				bootloaderenvred@100000 {
+					label = "bootloader env redundant";
+					reg = <0x100000 0x40000>;
+				};
+
+				bootloaderenv@140000 {
+					label = "bootloader env";
+					reg = <0x140000 0x40000>;
+				};
+
+				dtb@180000 {
+					label = "device tree";
+					reg = <0x180000 0x80000>;
+				};
+
+				kernel@200000 {
+					label = "kernel";
+					reg = <0x200000 0x600000>;
+				};
+
+				rootfs@800000 {
+					label = "rootfs";
+					reg = <0x800000 0x0f800000>;
+				};
+			};
+		};
+	};
+};
+
+&i2c0 {
+	pinctrl-0 = <&pinctrl_i2c0_pu>;
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {
+	pinctrl-0 = <&pinctrl_i2c2_pu>;
+	status = "okay";
+};
+
+&mmc0 {
+	pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3
+		     &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>;
+	vmmc-supply = <&vcc_mmc0_reg>;
+	vqmmc-supply = <&vcc_3v3_reg>;
+	status = "okay";
+	slot@0 {
+		reg = <0>;
+		bus-width = <8>;
+		cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&pinctrl {
+	board {
+		pinctrl_i2c0_pu: i2c0-pu {
+			atmel,pins =
+				<AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>,
+				<AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>;
+		};
+
+		pinctrl_i2c2_pu: i2c2-pu {
+			atmel,pins =
+				<AT91_PIOA 18 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>,
+				<AT91_PIOA 19 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>;
+		};
+
+		pinctrl_key_gpio: key-gpio-0 {
+			atmel,pins =
+				<AT91_PIOE 29 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+		};
+
+		pinctrl_mmc0_cd: mmc0-cd {
+			atmel,pins =
+				<AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+		};
+
+		/* Reserved for reset signal to the RGMII connector. */
+		pinctrl_rgmii_rstn: rgmii-rstn {
+			atmel,pins =
+				<AT91_PIOD 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+		};
+
+		/* Reserved for an interrupt line from the RMII and RGMII connectors. */
+		pinctrl_spi_irqn: spi-irqn {
+			atmel,pins =
+				<AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>;
+		};
+
+		pinctrl_spi0_cs: spi0-cs-default {
+			atmel,pins =
+				<AT91_PIOD 13 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
+				 AT91_PIOD 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
+		};
+
+		pinctrl_spi1_cs: spi1-cs-default {
+			atmel,pins = <AT91_PIOC 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
+				      AT91_PIOC 28 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
+		};
+
+		pinctrl_usba_vbus: usba-vbus {
+			atmel,pins =
+				<AT91_PIOE 9 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>;
+		};
+
+		pinctrl_usb_default: usb-default {
+			atmel,pins =
+				<AT91_PIOE 3 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
+				 AT91_PIOE 4 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
+		};
+
+		/* Reserved for VBUS fault interrupt. */
+		pinctrl_vbusfault_irqn: vbusfault-irqn {
+			atmel,pins =
+				<AT91_PIOE 5 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>;
+		};
+
+		pinctrl_vcc_mmc0_reg_gpio: vcc-mmc0-reg-gpio-default {
+			atmel,pins = <AT91_PIOE 2 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>;
+		};
+	};
+};
+
+&spi0 {
+	pinctrl-names = "default", "cs";
+	pinctrl-1 = <&pinctrl_spi0_cs>;
+	cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>;
+	status = "okay";
+};
+
+&spi1 {
+	pinctrl-names = "default", "cs";
+	pinctrl-1 = <&pinctrl_spi1_cs>;
+	cs-gpios = <&pioC 25 0>, <0>, <0>, <&pioC 28 0>;
+	status = "okay";
+};
+
+&tcb0 {
+	timer0: timer@0 {
+		compatible = "atmel,tcb-timer";
+		reg = <0>;
+	};
+
+	timer1: timer@1 {
+		compatible = "atmel,tcb-timer";
+		reg = <1>;
+	};
+};
+
+&usb0 {	/* USB Device port with VBUS detection. */
+	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usba_vbus>;
+	status = "okay";
+};
+
+&usb1 {	/* 3-port Host. First port is unused. */
+	atmel,vbus-gpio = <0
+			   &pioE 3 GPIO_ACTIVE_HIGH
+			   &pioE 4 GPIO_ACTIVE_HIGH
+			  >;
+	num-ports = <3>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usb_default>;
+	status = "okay";
+};
+
+&usb2 {
+	status = "okay";
+};
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Krzysztof Kozlowski]

On 02/09/2022 21:22, Jerry Ray wrote:
> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board
> description yaml file.
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> ---
> v5->v6:
>  - No code change - patch prefix naming modified to match with others.
> v4->v5:
>  - No change
> v3->v4:
>  - No change
> v2->v3:
>  - No change
> v1->v2:
>  - Added Device Tree documentation for Microchip SAMA5D3-EDS board
> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 2b7848bb7769..c7f067e13d20 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -139,6 +139,13 @@ properties:
>            - const: atmel,at91sam9g20
>            - const: atmel,at91sam9
>  
> +      - description: Microchip SAMA5D3 Ethernet Development System Board
> +        items:
> +          - const: microchip,sama5d3-eds
> +          - const: atmel,sama5d36
> +          - const: atmel,sama5d3
> +          - const: atmel,sama5
> +

A bit weird order. I would expect this to be after atmel,sama5d3 boards
but before atmel,at91sam9...


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Krzysztof Kozlowski]

On 02/09/2022 21:22, Jerry Ray wrote:
> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for
> evaluating many Microchip ethernet switch and PHY products.  Various
> daughter cards can connect up via an RGMII connector or an RMII connector.
> 
> The EDS board is not intended for stand-alone use and has no ethernet
> capabilities when no daughter board is connected.  As such, this device
> tree is intended to be used with a DT overlay defining the add-on board.
> To better ensure consistency, some items are defined here as a form of
> documentation so that all add-on overlays will use the same terms.
> 
> Google search keywords: "Microchip SAMA5D3-EDS"
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> ---
> v5->v6:
>  - Replaced underscores in names where I can, improving naming.
> v4->v5:
>  - patch now applies to v6.0-rc2
> v3->v4:
>  - Fixed regulators as necessary to get the board to boot from SD Card.
> v2->v3:
>  - Alphabetized pinctrl entries.
>  - cleaned up a warning in the regulators section.
>  - License tweaked to 'OR MIT'
>  - Included Makefile change
> v1->v2:
>  - Modified the compatible field in the device tree to reflect Microchip
>    Ethernet Development System Board.
> ---
>  arch/arm/boot/dts/Makefile             |   1 +
>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 +++++++++++++++++++++++++
>  2 files changed, 310 insertions(+)
>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..e92e639a2dc3 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>  	at91-sama5d2_icp.dtb \
>  	at91-sama5d2_ptc_ek.dtb \
>  	at91-sama5d2_xplained.dtb \
> +	at91-sama5d3_eds.dtb \
>  	at91-sama5d3_ksz9477_evb.dtb \
>  	at91-sama5d3_xplained.dtb \
>  	at91-dvk_som60.dtb \
> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> new file mode 100644
> index 000000000000..b4fe1c5f2997
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> @@ -0,0 +1,309 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
> + *    Development System board.
> + *
> + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
> + *
> + * Author: Jerry Ray <jerry.ray@microchip.com>
> + */
> +/dts-v1/;
> +#include "sama5d36.dtsi"
> +
> +/ {
> +	model = "SAMA5D3 Ethernet Development System";
> +	compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
> +		     "atmel,sama5d3", "atmel,sama5";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	clocks {
> +		slow_xtal {

No underscores in node names. Override by label.

> +			clock-frequency = <32768>;
> +		};
> +
> +		main_xtal {
> +			clock-frequency = <12000000>;
> +		};
> +	};
> +
> +	gpio {
> +		compatible = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_key_gpio>;
> +
> +		button-3 {
> +			label = "PB_USER";
> +			gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
> +			linux,code = <0x104>;
> +			wakeup-source;
> +		};
> +	};
> +
> +	memory@20000000 {
> +		reg = <0x20000000 0x10000000>;
> +	};
> +
> +	vcc_3v3_reg: buck-regulator-1 {

Keep consistent prefix or suffix, so:
regulator-buck-1

> +		compatible = "regulator-fixed";
> +		regulator-name = "VCC_3V3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +	};
> +
> +	vcc_2v5_reg: ldo-regulator-2 {

regulator-ldo-1
(why numbering of LDO regulators starts from 2? keep some sense in this)


> +		compatible = "regulator-fixed";
> +		regulator-name = "VCC_2V5";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-always-on;
> +		vin-supply = <&vcc_3v3_reg>;
> +	};
> +
> +	vcc_1v8_reg: ldo-regulator-3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VCC_1V8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-always-on;
> +		vin-supply = <&vcc_3v3_reg>;
> +	};
> +
> +	vcc_1v2_reg: buck-regulator-4 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VCC_1V2";
> +		regulator-min-microvolt = <1200000>;
> +		regulator-max-microvolt = <1200000>;
> +		regulator-always-on;
> +	};
> +
> +	vcc_mmc0_reg: fixedregulator-mmc0 {

Just regulator-mmc0

> +		compatible = "regulator-fixed";
> +		regulator-name = "mmc0-card-supply";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>;
> +		gpio = <&pioE 2 GPIO_ACTIVE_LOW>;
> +	};


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Jerry.Ray]

>On 02/09/2022 21:22, Jerry Ray wrote:
>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for 
>> evaluating many Microchip ethernet switch and PHY products.  Various 
>> daughter cards can connect up via an RGMII connector or an RMII connector.
>>
>> The EDS board is not intended for stand-alone use and has no ethernet 
>> capabilities when no daughter board is connected.  As such, this 
>> device tree is intended to be used with a DT overlay defining the add-on board.
>> To better ensure consistency, some items are defined here as a form of 
>> documentation so that all add-on overlays will use the same terms.
>>
>> Google search keywords: "Microchip SAMA5D3-EDS"
>>
>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>> ---
>> v5->v6:
>>  - Replaced underscores in names where I can, improving naming.
>> v4->v5:
>>  - patch now applies to v6.0-rc2
>> v3->v4:
>>  - Fixed regulators as necessary to get the board to boot from SD Card.
>> v2->v3:
>>  - Alphabetized pinctrl entries.
>>  - cleaned up a warning in the regulators section.
>>  - License tweaked to 'OR MIT'
>>  - Included Makefile change
>> v1->v2:
>>  - Modified the compatible field in the device tree to reflect Microchip
>>    Ethernet Development System Board.
>> ---
>>  arch/arm/boot/dts/Makefile             |   1 +
>>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 
>> +++++++++++++++++++++++++
>>  2 files changed, 310 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
>> index 05d8aef6e5d2..e92e639a2dc3 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>>       at91-sama5d2_icp.dtb \
>>       at91-sama5d2_ptc_ek.dtb \
>>       at91-sama5d2_xplained.dtb \
>> +     at91-sama5d3_eds.dtb \
>>       at91-sama5d3_ksz9477_evb.dtb \
>>       at91-sama5d3_xplained.dtb \
>>       at91-dvk_som60.dtb \
>> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts 
>> b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>> new file mode 100644
>> index 000000000000..b4fe1c5f2997
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>> @@ -0,0 +1,309 @@
>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>> +/*
>> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
>> + *    Development System board.
>> + *
>> + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
>> + *
>> + * Author: Jerry Ray <jerry.ray@microchip.com>  */ /dts-v1/; #include 
>> +"sama5d36.dtsi"
>> +
>> +/ {
>> +     model = "SAMA5D3 Ethernet Development System";
>> +     compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
>> +                  "atmel,sama5d3", "atmel,sama5";
>> +
>> +     chosen {
>> +             stdout-path = "serial0:115200n8";
>> +     };
>> +
>> +     clocks {
>> +             slow_xtal {
>
>No underscores in node names. Override by label.
>
>> +                     clock-frequency = <32768>;
>> +             };
>> +
>> +             main_xtal {
>> +                     clock-frequency = <12000000>;
>> +             };
>> +     };
>> +
>> +     gpio {
>> +             compatible = "gpio-keys";
>> +
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&pinctrl_key_gpio>;
>> +
>> +             button-3 {
>> +                     label = "PB_USER";
>> +                     gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
>> +                     linux,code = <0x104>;
>> +                     wakeup-source;
>> +             };
>> +     };
>> +
>> +     memory@20000000 {
>> +             reg = <0x20000000 0x10000000>;
>> +     };
>> +
>> +     vcc_3v3_reg: buck-regulator-1 {
>
>Keep consistent prefix or suffix, so:
>regulator-buck-1
>
>> +             compatible = "regulator-fixed";
>> +             regulator-name = "VCC_3V3";
>> +             regulator-min-microvolt = <3300000>;
>> +             regulator-max-microvolt = <3300000>;
>> +             regulator-always-on;
>> +     };
>> +
>> +     vcc_2v5_reg: ldo-regulator-2 {
>
>regulator-ldo-1
>(why numbering of LDO regulators starts from 2? keep some sense in this)
>
>

There are N regulators on the board, so they are numbered 1 thru N.
Regulator 2 is regulator 2 whether it's a buck or LDO.

>> +             compatible = "regulator-fixed";
>> +             regulator-name = "VCC_2V5";
>> +             regulator-min-microvolt = <2500000>;
>> +             regulator-max-microvolt = <2500000>;
>> +             regulator-always-on;
>> +             vin-supply = <&vcc_3v3_reg>;
>> +     };
>> +
>> +     vcc_1v8_reg: ldo-regulator-3 {
>> +             compatible = "regulator-fixed";
>> +             regulator-name = "VCC_1V8";
>> +             regulator-min-microvolt = <1800000>;
>> +             regulator-max-microvolt = <1800000>;
>> +             regulator-always-on;
>> +             vin-supply = <&vcc_3v3_reg>;
>> +     };
>> +
>> +     vcc_1v2_reg: buck-regulator-4 {
>> +             compatible = "regulator-fixed";
>> +             regulator-name = "VCC_1V2";
>> +             regulator-min-microvolt = <1200000>;
>> +             regulator-max-microvolt = <1200000>;
>> +             regulator-always-on;
>> +     };
>> +
>> +     vcc_mmc0_reg: fixedregulator-mmc0 {
>
>Just regulator-mmc0
>

Okay.

>> +             compatible = "regulator-fixed";
>> +             regulator-name = "mmc0-card-supply";
>> +             regulator-min-microvolt = <3300000>;
>> +             regulator-max-microvolt = <3300000>;
>> +             regulator-always-on;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>;
>> +             gpio = <&pioE 2 GPIO_ACTIVE_LOW>;
>> +     };
>
>
>Best regards,
>Krzysztof
>

Regards,
Jerry.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Krzysztof Kozlowski]

On 08/09/2022 15:58, Jerry.Ray@microchip.com wrote:
>> On 02/09/2022 21:22, Jerry Ray wrote:
>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for 
>>> evaluating many Microchip ethernet switch and PHY products.  Various 
>>> daughter cards can connect up via an RGMII connector or an RMII connector.
>>>
>>> The EDS board is not intended for stand-alone use and has no ethernet 
>>> capabilities when no daughter board is connected.  As such, this 
>>> device tree is intended to be used with a DT overlay defining the add-on board.
>>> To better ensure consistency, some items are defined here as a form of 
>>> documentation so that all add-on overlays will use the same terms.
>>>
>>> Google search keywords: "Microchip SAMA5D3-EDS"
>>>
>>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>>> ---
>>> v5->v6:
>>>  - Replaced underscores in names where I can, improving naming.
>>> v4->v5:
>>>  - patch now applies to v6.0-rc2
>>> v3->v4:
>>>  - Fixed regulators as necessary to get the board to boot from SD Card.
>>> v2->v3:
>>>  - Alphabetized pinctrl entries.
>>>  - cleaned up a warning in the regulators section.
>>>  - License tweaked to 'OR MIT'
>>>  - Included Makefile change
>>> v1->v2:
>>>  - Modified the compatible field in the device tree to reflect Microchip
>>>    Ethernet Development System Board.
>>> ---
>>>  arch/arm/boot/dts/Makefile             |   1 +
>>>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 
>>> +++++++++++++++++++++++++
>>>  2 files changed, 310 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
>>> index 05d8aef6e5d2..e92e639a2dc3 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>>>       at91-sama5d2_icp.dtb \
>>>       at91-sama5d2_ptc_ek.dtb \
>>>       at91-sama5d2_xplained.dtb \
>>> +     at91-sama5d3_eds.dtb \
>>>       at91-sama5d3_ksz9477_evb.dtb \
>>>       at91-sama5d3_xplained.dtb \
>>>       at91-dvk_som60.dtb \
>>> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts 
>>> b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>> new file mode 100644
>>> index 000000000000..b4fe1c5f2997
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>> @@ -0,0 +1,309 @@
>>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>>> +/*
>>> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
>>> + *    Development System board.
>>> + *
>>> + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
>>> + *
>>> + * Author: Jerry Ray <jerry.ray@microchip.com>  */ /dts-v1/; #include 
>>> +"sama5d36.dtsi"
>>> +
>>> +/ {
>>> +     model = "SAMA5D3 Ethernet Development System";
>>> +     compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
>>> +                  "atmel,sama5d3", "atmel,sama5";
>>> +
>>> +     chosen {
>>> +             stdout-path = "serial0:115200n8";
>>> +     };
>>> +
>>> +     clocks {
>>> +             slow_xtal {
>>
>> No underscores in node names. Override by label.
>>
>>> +                     clock-frequency = <32768>;
>>> +             };
>>> +
>>> +             main_xtal {
>>> +                     clock-frequency = <12000000>;
>>> +             };
>>> +     };
>>> +
>>> +     gpio {
>>> +             compatible = "gpio-keys";
>>> +
>>> +             pinctrl-names = "default";
>>> +             pinctrl-0 = <&pinctrl_key_gpio>;
>>> +
>>> +             button-3 {
>>> +                     label = "PB_USER";
>>> +                     gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
>>> +                     linux,code = <0x104>;
>>> +                     wakeup-source;
>>> +             };
>>> +     };
>>> +
>>> +     memory@20000000 {
>>> +             reg = <0x20000000 0x10000000>;
>>> +     };
>>> +
>>> +     vcc_3v3_reg: buck-regulator-1 {
>>
>> Keep consistent prefix or suffix, so:
>> regulator-buck-1
>>
>>> +             compatible = "regulator-fixed";
>>> +             regulator-name = "VCC_3V3";
>>> +             regulator-min-microvolt = <3300000>;
>>> +             regulator-max-microvolt = <3300000>;
>>> +             regulator-always-on;
>>> +     };
>>> +
>>> +     vcc_2v5_reg: ldo-regulator-2 {
>>
>> regulator-ldo-1
>> (why numbering of LDO regulators starts from 2? keep some sense in this)
>>
>>
> 
> There are N regulators on the board, so they are numbered 1 thru N.
> Regulator 2 is regulator 2 whether it's a buck or LDO.

So if this is supposed to match board schematics (which is good idea),
then maybe just "regulator-2"? The point is to have same generic name
and customize either prefix or suffix, but not both.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Jerry.Ray]

>>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing 
>>>> for evaluating many Microchip ethernet switch and PHY products.  
>>>> Various daughter cards can connect up via an RGMII connector or an RMII connector.
>>>>
>>>> The EDS board is not intended for stand-alone use and has no 
>>>> ethernet capabilities when no daughter board is connected.  As such, 
>>>> this device tree is intended to be used with a DT overlay defining the add-on board.
>>>> To better ensure consistency, some items are defined here as a form 
>>>> of documentation so that all add-on overlays will use the same terms.
>>>>
>>>> Google search keywords: "Microchip SAMA5D3-EDS"
>>>>
>>>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>>>> ---
>>>> v5->v6:
>>>>  - Replaced underscores in names where I can, improving naming.
>>>> v4->v5:
>>>>  - patch now applies to v6.0-rc2
>>>> v3->v4:
>>>>  - Fixed regulators as necessary to get the board to boot from SD Card.
>>>> v2->v3:
>>>>  - Alphabetized pinctrl entries.
>>>>  - cleaned up a warning in the regulators section.
>>>>  - License tweaked to 'OR MIT'
>>>>  - Included Makefile change
>>>> v1->v2:
>>>>  - Modified the compatible field in the device tree to reflect Microchip
>>>>    Ethernet Development System Board.
>>>> ---
>>>>  arch/arm/boot/dts/Makefile             |   1 +
>>>>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309
>>>> +++++++++++++++++++++++++
>>>>  2 files changed, 310 insertions(+)
>>>>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>
>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
>>>> index 05d8aef6e5d2..e92e639a2dc3 100644
>>>> --- a/arch/arm/boot/dts/Makefile
>>>> +++ b/arch/arm/boot/dts/Makefile
>>>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>>>>       at91-sama5d2_icp.dtb \
>>>>       at91-sama5d2_ptc_ek.dtb \
>>>>       at91-sama5d2_xplained.dtb \
>>>> +     at91-sama5d3_eds.dtb \
>>>>       at91-sama5d3_ksz9477_evb.dtb \
>>>>       at91-sama5d3_xplained.dtb \
>>>>       at91-dvk_som60.dtb \
>>>> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>> b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>> new file mode 100644
>>>> index 000000000000..b4fe1c5f2997
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>> @@ -0,0 +1,309 @@
>>>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>>>> +/*
>>>> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
>>>> + *    Development System board.
>>>> + *
>>>> + * Copyright (C) 2022 Microchip Technology Inc. and its 
>>>> +subsidiaries
>>>> + *
>>>> + * Author: Jerry Ray <jerry.ray@microchip.com>  */ /dts-v1/; 
>>>> +#include "sama5d36.dtsi"
>>>> +
>>>> +/ {
>>>> +     model = "SAMA5D3 Ethernet Development System";
>>>> +     compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
>>>> +                  "atmel,sama5d3", "atmel,sama5";
>>>> +
>>>> +     chosen {
>>>> +             stdout-path = "serial0:115200n8";
>>>> +     };
>>>> +
>>>> +     clocks {
>>>> +             slow_xtal {
>>>
>>> No underscores in node names. Override by label.
>>>
>>>> +                     clock-frequency = <32768>;
>>>> +             };
>>>> +
>>>> +             main_xtal {
>>>> +                     clock-frequency = <12000000>;
>>>> +             };
>>>> +     };
>>>> +
>>>> +     gpio {
>>>> +             compatible = "gpio-keys";
>>>> +
>>>> +             pinctrl-names = "default";
>>>> +             pinctrl-0 = <&pinctrl_key_gpio>;
>>>> +
>>>> +             button-3 {
>>>> +                     label = "PB_USER";
>>>> +                     gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
>>>> +                     linux,code = <0x104>;
>>>> +                     wakeup-source;
>>>> +             };
>>>> +     };
>>>> +
>>>> +     memory@20000000 {
>>>> +             reg = <0x20000000 0x10000000>;
>>>> +     };
>>>> +
>>>> +     vcc_3v3_reg: buck-regulator-1 {
>>>
>>> Keep consistent prefix or suffix, so:
>>> regulator-buck-1
>>>
>>>> +             compatible = "regulator-fixed";
>>>> +             regulator-name = "VCC_3V3";
>>>> +             regulator-min-microvolt = <3300000>;
>>>> +             regulator-max-microvolt = <3300000>;
>>>> +             regulator-always-on;
>>>> +     };
>>>> +
>>>> +     vcc_2v5_reg: ldo-regulator-2 {
>>>
>>> regulator-ldo-1
>>> (why numbering of LDO regulators starts from 2? keep some sense in 
>>> this)
>>>
>>>
>>
>> There are N regulators on the board, so they are numbered 1 thru N.
>> Regulator 2 is regulator 2 whether it's a buck or LDO.
>
>So if this is supposed to match board schematics (which is good idea), then maybe just "regulator-2"? The point is to have same generic name and customize either prefix or suffix, but not both.
>
>Best regards,
>Krzysztof
>

I prefer names to be descriptive, but I suppose I can have the name generic and add a comment into the dts file.
However, the comment doesn't make it into the loaded device tree.  Would you be okay with "regulator-2-ldo"?

Regards,
Jerry.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Krzysztof Kozlowski]

On 08/09/2022 16:50, Jerry.Ray@microchip.com wrote:
>>>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing 
>>>>> for evaluating many Microchip ethernet switch and PHY products.  
>>>>> Various daughter cards can connect up via an RGMII connector or an RMII connector.
>>>>>
>>>>> The EDS board is not intended for stand-alone use and has no 
>>>>> ethernet capabilities when no daughter board is connected.  As such, 
>>>>> this device tree is intended to be used with a DT overlay defining the add-on board.
>>>>> To better ensure consistency, some items are defined here as a form 
>>>>> of documentation so that all add-on overlays will use the same terms.
>>>>>
>>>>> Google search keywords: "Microchip SAMA5D3-EDS"
>>>>>
>>>>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>>>>> ---
>>>>> v5->v6:
>>>>>  - Replaced underscores in names where I can, improving naming.
>>>>> v4->v5:
>>>>>  - patch now applies to v6.0-rc2
>>>>> v3->v4:
>>>>>  - Fixed regulators as necessary to get the board to boot from SD Card.
>>>>> v2->v3:
>>>>>  - Alphabetized pinctrl entries.
>>>>>  - cleaned up a warning in the regulators section.
>>>>>  - License tweaked to 'OR MIT'
>>>>>  - Included Makefile change
>>>>> v1->v2:
>>>>>  - Modified the compatible field in the device tree to reflect Microchip
>>>>>    Ethernet Development System Board.
>>>>> ---
>>>>>  arch/arm/boot/dts/Makefile             |   1 +
>>>>>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309
>>>>> +++++++++++++++++++++++++
>>>>>  2 files changed, 310 insertions(+)
>>>>>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
>>>>> index 05d8aef6e5d2..e92e639a2dc3 100644
>>>>> --- a/arch/arm/boot/dts/Makefile
>>>>> +++ b/arch/arm/boot/dts/Makefile
>>>>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>>>>>       at91-sama5d2_icp.dtb \
>>>>>       at91-sama5d2_ptc_ek.dtb \
>>>>>       at91-sama5d2_xplained.dtb \
>>>>> +     at91-sama5d3_eds.dtb \
>>>>>       at91-sama5d3_ksz9477_evb.dtb \
>>>>>       at91-sama5d3_xplained.dtb \
>>>>>       at91-dvk_som60.dtb \
>>>>> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>> b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>> new file mode 100644
>>>>> index 000000000000..b4fe1c5f2997
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>> @@ -0,0 +1,309 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>>>>> +/*
>>>>> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
>>>>> + *    Development System board.
>>>>> + *
>>>>> + * Copyright (C) 2022 Microchip Technology Inc. and its 
>>>>> +subsidiaries
>>>>> + *
>>>>> + * Author: Jerry Ray <jerry.ray@microchip.com>  */ /dts-v1/; 
>>>>> +#include "sama5d36.dtsi"
>>>>> +
>>>>> +/ {
>>>>> +     model = "SAMA5D3 Ethernet Development System";
>>>>> +     compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
>>>>> +                  "atmel,sama5d3", "atmel,sama5";
>>>>> +
>>>>> +     chosen {
>>>>> +             stdout-path = "serial0:115200n8";
>>>>> +     };
>>>>> +
>>>>> +     clocks {
>>>>> +             slow_xtal {
>>>>
>>>> No underscores in node names. Override by label.
>>>>
>>>>> +                     clock-frequency = <32768>;
>>>>> +             };
>>>>> +
>>>>> +             main_xtal {
>>>>> +                     clock-frequency = <12000000>;
>>>>> +             };
>>>>> +     };
>>>>> +
>>>>> +     gpio {
>>>>> +             compatible = "gpio-keys";
>>>>> +
>>>>> +             pinctrl-names = "default";
>>>>> +             pinctrl-0 = <&pinctrl_key_gpio>;
>>>>> +
>>>>> +             button-3 {
>>>>> +                     label = "PB_USER";
>>>>> +                     gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
>>>>> +                     linux,code = <0x104>;
>>>>> +                     wakeup-source;
>>>>> +             };
>>>>> +     };
>>>>> +
>>>>> +     memory@20000000 {
>>>>> +             reg = <0x20000000 0x10000000>;
>>>>> +     };
>>>>> +
>>>>> +     vcc_3v3_reg: buck-regulator-1 {
>>>>
>>>> Keep consistent prefix or suffix, so:
>>>> regulator-buck-1
>>>>
>>>>> +             compatible = "regulator-fixed";
>>>>> +             regulator-name = "VCC_3V3";
>>>>> +             regulator-min-microvolt = <3300000>;
>>>>> +             regulator-max-microvolt = <3300000>;
>>>>> +             regulator-always-on;
>>>>> +     };
>>>>> +
>>>>> +     vcc_2v5_reg: ldo-regulator-2 {
>>>>
>>>> regulator-ldo-1
>>>> (why numbering of LDO regulators starts from 2? keep some sense in 
>>>> this)
>>>>
>>>>
>>>
>>> There are N regulators on the board, so they are numbered 1 thru N.
>>> Regulator 2 is regulator 2 whether it's a buck or LDO.
>>
>> So if this is supposed to match board schematics (which is good idea), then maybe just "regulator-2"? The point is to have same generic name and customize either prefix or suffix, but not both.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I prefer names to be descriptive, but I suppose I can have the name generic and add a comment into the dts file.
> However, the comment doesn't make it into the loaded device tree.  Would you be okay with "regulator-2-ldo"?

You have the descriptive name in the regulator-name property, but ok,
can be in node name as well.




Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Jerry.Ray]

>>>>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing 
>>>>>> for evaluating many Microchip ethernet switch and PHY products.
>>>>>> Various daughter cards can connect up via an RGMII connector or an RMII connector.
>>>>>>
>>>>>> The EDS board is not intended for stand-alone use and has no 
>>>>>> ethernet capabilities when no daughter board is connected.  As 
>>>>>> such, this device tree is intended to be used with a DT overlay defining the add-on board.
>>>>>> To better ensure consistency, some items are defined here as a 
>>>>>> form of documentation so that all add-on overlays will use the same terms.
>>>>>>
>>>>>> Google search keywords: "Microchip SAMA5D3-EDS"
>>>>>>
>>>>>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>>>>>> ---
>>>>>> v5->v6:
>>>>>>  - Replaced underscores in names where I can, improving naming.
>>>>>> v4->v5:
>>>>>>  - patch now applies to v6.0-rc2
>>>>>> v3->v4:
>>>>>>  - Fixed regulators as necessary to get the board to boot from SD Card.
>>>>>> v2->v3:
>>>>>>  - Alphabetized pinctrl entries.
>>>>>>  - cleaned up a warning in the regulators section.
>>>>>>  - License tweaked to 'OR MIT'
>>>>>>  - Included Makefile change
>>>>>> v1->v2:
>>>>>>  - Modified the compatible field in the device tree to reflect Microchip
>>>>>>    Ethernet Development System Board.
>>>>>> ---
>>>>>>  arch/arm/boot/dts/Makefile             |   1 +
>>>>>>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 309
>>>>>> +++++++++++++++++++++++++
>>>>>>  2 files changed, 310 insertions(+)  create mode 100644 
>>>>>> arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/Makefile 
>>>>>> b/arch/arm/boot/dts/Makefile index 05d8aef6e5d2..e92e639a2dc3 
>>>>>> 100644
>>>>>> --- a/arch/arm/boot/dts/Makefile
>>>>>> +++ b/arch/arm/boot/dts/Makefile
>>>>>> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>>>>>>       at91-sama5d2_icp.dtb \
>>>>>>       at91-sama5d2_ptc_ek.dtb \
>>>>>>       at91-sama5d2_xplained.dtb \
>>>>>> +     at91-sama5d3_eds.dtb \
>>>>>>       at91-sama5d3_ksz9477_evb.dtb \
>>>>>>       at91-sama5d3_xplained.dtb \
>>>>>>       at91-dvk_som60.dtb \
>>>>>> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>>> b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>>> new file mode 100644
>>>>>> index 000000000000..b4fe1c5f2997
>>>>>> --- /dev/null
>>>>>> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
>>>>>> @@ -0,0 +1,309 @@
>>>>>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>>>>>> +/*
>>>>>> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
>>>>>> + *    Development System board.
>>>>>> + *
>>>>>> + * Copyright (C) 2022 Microchip Technology Inc. and its 
>>>>>> +subsidiaries
>>>>>> + *
>>>>>> + * Author: Jerry Ray <jerry.ray@microchip.com>  */ /dts-v1/; 
>>>>>> +#include "sama5d36.dtsi"
>>>>>> +
>>>>>> +/ {
>>>>>> +     model = "SAMA5D3 Ethernet Development System";
>>>>>> +     compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
>>>>>> +                  "atmel,sama5d3", "atmel,sama5";
>>>>>> +
>>>>>> +     chosen {
>>>>>> +             stdout-path = "serial0:115200n8";
>>>>>> +     };
>>>>>> +
>>>>>> +     clocks {
>>>>>> +             slow_xtal {
>>>>>
>>>>> No underscores in node names. Override by label.
>>>>>

I am not at liberty to change this as both node name and label are defined in the sama5d3.dtsi source file.
If there is a way to override the label, please share the syntax as nothing I have tried is working.

>>>>>> +                     clock-frequency = <32768>;
>>>>>> +             };
>>>>>> +
>>>>>> +             main_xtal {
>>>>>> +                     clock-frequency = <12000000>;
>>>>>> +             };
>>>>>> +     };
>>>>>> +
>>>>>> +     gpio {
>>>>>> +             compatible = "gpio-keys";
>>>>>> +
>>>>>> +             pinctrl-names = "default";
>>>>>> +             pinctrl-0 = <&pinctrl_key_gpio>;
>>>>>> +
>>>>>> +             button-3 {
>>>>>> +                     label = "PB_USER";
>>>>>> +                     gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
>>>>>> +                     linux,code = <0x104>;
>>>>>> +                     wakeup-source;
>>>>>> +             };
>>>>>> +     };
>>>>>> +
>>>>>> +     memory@20000000 {
>>>>>> +             reg = <0x20000000 0x10000000>;
>>>>>> +     };
>>>>>> +
>>>>>> +     vcc_3v3_reg: buck-regulator-1 {
>>>>>
>>>>> Keep consistent prefix or suffix, so:
>>>>> regulator-buck-1
>>>>>
>>>>>> +             compatible = "regulator-fixed";
>>>>>> +             regulator-name = "VCC_3V3";
>>>>>> +             regulator-min-microvolt = <3300000>;
>>>>>> +             regulator-max-microvolt = <3300000>;
>>>>>> +             regulator-always-on;
>>>>>> +     };
>>>>>> +
>>>>>> +     vcc_2v5_reg: ldo-regulator-2 {
>>>>>
>>>>> regulator-ldo-1
>>>>> (why numbering of LDO regulators starts from 2? keep some sense in
>>>>> this)
>>>>>
>>>>>
>>>>
>>>> There are N regulators on the board, so they are numbered 1 thru N.
>>>> Regulator 2 is regulator 2 whether it's a buck or LDO.
>>>
>>> So if this is supposed to match board schematics (which is good idea), then maybe just "regulator-2"? The point is to have same generic name and customize either prefix or suffix, but not both.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I prefer names to be descriptive, but I suppose I can have the name generic and add a comment into the dts file.
>> However, the comment doesn't make it into the loaded device tree.  Would you be okay with "regulator-2-ldo"?
>
>You have the descriptive name in the regulator-name property, but ok, can be in node name as well.
>
>Best regards,
>Krzysztof
>

Regards,
Jerry.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/2] ARM: dts: at91: Adding SAMA5D3-EDS board

[Krzysztof Kozlowski]

On 08/09/2022 17:32, Jerry.Ray@microchip.com wrote:
>>>>>>> +     chosen {
>>>>>>> +             stdout-path = "serial0:115200n8";
>>>>>>> +     };
>>>>>>> +
>>>>>>> +     clocks {
>>>>>>> +             slow_xtal {
>>>>>>
>>>>>> No underscores in node names. Override by label.
>>>>>>
> 
> I am not at liberty to change this as both node name and label are defined in the sama5d3.dtsi source file.
> If there is a way to override the label, please share the syntax as nothing I have tried is working.

Override *by* label. Not the label. Just like all things are being
customized.

&slow_xtal {
	...
};


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Rob Herring]

On Fri, Sep 02, 2022 at 02:22:35PM -0500, Jerry Ray wrote:
> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board
> description yaml file.
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> ---
> v5->v6:
>  - No code change - patch prefix naming modified to match with others.

You did 'git log --oneline Documentation/devicetree/bindings/arm/' for 
inspiration?

'ARM: dts' would be an arm32 .dts file which this is not.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Jerry.Ray]

>> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board 
>> description yaml file.
>>
>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>> ---
>> v5->v6:
>>  - No code change - patch prefix naming modified to match with others.
>
>You did 'git log --oneline Documentation/devicetree/bindings/arm/' for inspiration?
>
>'ARM: dts' would be an arm32 .dts file which this is not.
>
>Rob

Yes.  I'm trying to get it into the right bucket, but I guess I'm clueless as to how things get broken down.
I tried "dts: arm: at91:" but was asked to change it.  I can keep guessing, but would prefer if someone could
help me understand and get it right.

Regards,
Jerry.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Alexandre Belloni]

On 08/09/2022 21:38:48+0000, Jerry.Ray@microchip.com wrote:
> >> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board 
> >> description yaml file.
> >>
> >> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> >> ---
> >> v5->v6:
> >>  - No code change - patch prefix naming modified to match with others.
> >
> >You did 'git log --oneline Documentation/devicetree/bindings/arm/' for inspiration?
> >
> >'ARM: dts' would be an arm32 .dts file which this is not.
> >
> >Rob
> 
> Yes.  I'm trying to get it into the right bucket, but I guess I'm clueless as to how things get broken down.
> I tried "dts: arm: at91:" but was asked to change it.  I can keep guessing, but would prefer if someone could
> help me understand and get it right.

dt-bindings: arm: at91: is the right prefix

> 
> Regards,
> Jerry.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 1/2] ARM: dts: at91: Adding documentation for SAMA5D3-EDS

[Krzysztof Kozlowski]

On 08/09/2022 23:38, Jerry.Ray@microchip.com wrote:
>>> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board 
>>> description yaml file.
>>>
>>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>>> ---
>>> v5->v6:
>>>  - No code change - patch prefix naming modified to match with others.
>>
>> You did 'git log --oneline Documentation/devicetree/bindings/arm/' for inspiration?
>>
>> 'ARM: dts' would be an arm32 .dts file which this is not.
>>
>> Rob
> 
> Yes.  I'm trying to get it into the right bucket, but I guess I'm clueless as to how things get broken down.
> I tried "dts: arm: at91:" but was asked to change it.  I can keep guessing, but would prefer if someone could
> help me understand and get it right.

git log --oneline -- Documentation/devicetree/bindings/arm/

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel