From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit
Date: Mon, 21 Jul 2014 15:45:53 +0800 [thread overview]
Message-ID: <1405928755-19413-2-git-send-email-shawn.guo@freescale.com> (raw)
In-Reply-To: <1405928755-19413-1-git-send-email-shawn.guo@freescale.com>
Use macro instead of magic number for SCU enable bit.
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
arch/arm/kernel/smp_scu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c
index 1aafa0d785eb..c947508f84e6 100644
--- a/arch/arm/kernel/smp_scu.c
+++ b/arch/arm/kernel/smp_scu.c
@@ -17,6 +17,7 @@
#include <asm/cputype.h>
#define SCU_CTRL 0x00
+#define SCU_ENABLE (1 << 0)
#define SCU_CONFIG 0x04
#define SCU_CPU_STATUS 0x08
#define SCU_INVALIDATE 0x0c
@@ -50,10 +51,10 @@ void scu_enable(void __iomem *scu_base)
scu_ctrl = readl_relaxed(scu_base + SCU_CTRL);
/* already enabled? */
- if (scu_ctrl & 1)
+ if (scu_ctrl & SCU_ENABLE)
return;
- scu_ctrl |= 1;
+ scu_ctrl |= SCU_ENABLE;
writel_relaxed(scu_ctrl, scu_base + SCU_CTRL);
/*
--
1.9.1
next prev parent reply other threads:[~2014-07-21 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo
2014-07-21 7:45 ` Shawn Guo [this message]
2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo
2014-07-21 8:51 ` Will Deacon
2014-07-21 9:27 ` Shawn Guo
2014-07-21 9:44 ` Will Deacon
2014-07-22 1:56 ` Shawn Guo
2014-07-21 10:26 ` Catalin Marinas
2014-07-22 2:09 ` Shawn Guo
2014-07-22 16:13 ` Catalin Marinas
2014-07-23 4:50 ` Shawn Guo
2014-07-23 16:45 ` Catalin Marinas
2014-07-24 8:49 ` Shawn Guo
2014-07-21 7:45 ` [PATCH 3/3] ARM: imx: remove SCU standby enable code Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405928755-19413-2-git-send-email-shawn.guo@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).