From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: smp_scu: enable SCU standby support
Date: Tue, 22 Jul 2014 17:13:31 +0100 [thread overview]
Message-ID: <20140722161331.GN2219@arm.com> (raw)
In-Reply-To: <20140722020911.GO8537@dragon>
On Tue, Jul 22, 2014 at 03:09:12AM +0100, Shawn Guo wrote:
> On Mon, Jul 21, 2014 at 11:26:38AM +0100, Catalin Marinas wrote:
> > The usual question - could the firmware enable this bit before Linux
> > starts?
>
> It could, I guess. Actually, on i.MX we're setting this bit in platform
> code right now. But I think setting this bit makes sense for most of
> the platforms, so it can reasonably be done in SCU core function. Isn't
> it the point of having core/common function after all?
Only that it wouldn't be consistent. If a platform (like some OMAPs)
boots in non-secure mode, the SCU would be already enabled the firmware
and your patch would not have any effect (that's one reason on arm64 I
try to get some consistency between various platforms and not rely on
the kernel which may or may not be able to enable certain features; but
it's late to enforced this on arm32).
> > We already do a read/modify/write sequence here and are only
> > supposed to write the enable bit as the rest are implementation defined.
>
> Isn't standby bit implemented by all A9 SCU except a couple of very
> early revisions (per Will)?
And we don't know the behaviour of setting this bit on such A9 early
revisions. So we can try to (1) find out if there are any in the field,
(2) read the RTL to see if anything happens or (3) add a check in Linux
for such revisions. I think (3) should be the case but you need to figure
out which revisions these are.
--
Catalin
next prev parent reply other threads:[~2014-07-22 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo
2014-07-21 7:45 ` [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit Shawn Guo
2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo
2014-07-21 8:51 ` Will Deacon
2014-07-21 9:27 ` Shawn Guo
2014-07-21 9:44 ` Will Deacon
2014-07-22 1:56 ` Shawn Guo
2014-07-21 10:26 ` Catalin Marinas
2014-07-22 2:09 ` Shawn Guo
2014-07-22 16:13 ` Catalin Marinas [this message]
2014-07-23 4:50 ` Shawn Guo
2014-07-23 16:45 ` Catalin Marinas
2014-07-24 8:49 ` Shawn Guo
2014-07-21 7:45 ` [PATCH 3/3] ARM: imx: remove SCU standby enable code Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722161331.GN2219@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).