* [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 @ 2014-10-07 15:19 Darshana Padmadas 2014-10-07 15:19 ` [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas ` (4 more replies) 0 siblings, 5 replies; 11+ messages in thread From: Darshana Padmadas @ 2014-10-07 15:19 UTC (permalink / raw) To: linux-arm-kernel Patchset documents correct and the deprecated vendor-prefix found by checkpatch warning and also documents information of device isl29028 for compatibility. Patchset also includes corrected vendor-prefix and device name in compatible property for files with checkpatch warning of undocumented string "isil,isl29028". Darshana Padmadas (4): Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028 Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Staging: iio: light: Added correct vendor-prefix for device isl29028 arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Changes in v4: - In PATCH 1/4 gave appropriate description for string describing vendor/chip for deprecated vendor-prefix and device. Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++ Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- drivers/staging/iio/light/isl29028.c | 3 ++- 4 files changed, 6 insertions(+), 2 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas @ 2014-10-07 15:19 ` Darshana Padmadas 2014-10-07 15:36 ` Mark Rutland 2014-10-07 15:19 ` [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Darshana Padmadas ` (3 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Darshana Padmadas @ 2014-10-07 15:19 UTC (permalink / raw) To: linux-arm-kernel This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix found by checkpatch also documented for compatibility reasons. Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index 6af570e..32edf0b 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -57,6 +57,8 @@ gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) isl,isl12057 Intersil ISL12057 I2C RTC Chip +isil,isl29028 (deprecated, use isl) +isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs maxim,max6625 9-Bit/12-Bit Temperature Sensors with I?C-Compatible Serial Interface -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028 2014-10-07 15:19 ` [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas @ 2014-10-07 15:36 ` Mark Rutland 0 siblings, 0 replies; 11+ messages in thread From: Mark Rutland @ 2014-10-07 15:36 UTC (permalink / raw) To: linux-arm-kernel Hi Darshana, On Tue, Oct 07, 2014 at 04:19:26PM +0100, Darshana Padmadas wrote: > This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix > found by checkpatch also documented for compatibility reasons. > > Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> In future, when you receive an Acked-by (or Reviewed-by, Tested-by, etc), please add them here for subsequent postings, unless there have been substantial changes that mean said tags are not representative. For example, this patch you should have: Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Mark Rutland <mark.rutland@arm.com> That makes it obvious that others have looked at your patches, and will help maintainers when deciding whether to pick them up. Additionally, for those who have reviewed or tested patches, it gains them some recognition for that effort. Additionally, it's generally a good idea to wait for at least a day or so between postings so as to give others time to inspect patches. Thanks, Mark. > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > index 6af570e..32edf0b 100644 > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > @@ -57,6 +57,8 @@ gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) > isl,isl12057 Intersil ISL12057 I2C RTC Chip > +isil,isl29028 (deprecated, use isl) > +isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs > maxim,max6625 9-Bit/12-Bit Temperature Sensors with I?C-Compatible Serial Interface > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas 2014-10-07 15:19 ` [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas @ 2014-10-07 15:19 ` Darshana Padmadas 2014-10-07 16:33 ` Rob Herring 2014-10-07 15:19 ` [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 Darshana Padmadas ` (2 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Darshana Padmadas @ 2014-10-07 15:19 UTC (permalink / raw) To: linux-arm-kernel This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels. Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index ac7269f..ab97459 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -68,6 +68,7 @@ img Imagination Technologies Ltd. intel Intel Corporation intercontrol Inter Control Group isee ISEE 2007 S.L. +isil Intersil (deprecated, use isl) isl Intersil karo Ka-Ro electronics GmbH keymile Keymile GmbH -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning 2014-10-07 15:19 ` [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Darshana Padmadas @ 2014-10-07 16:33 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2014-10-07 16:33 UTC (permalink / raw) To: linux-arm-kernel On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas <darshanapadmadas@gmail.com> wrote: > This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels. Fix your line wrapping to 72 chars. You can shorten the subject "Documentation: devicetree: bindings:" to "dt-bindings:". We're horribly inconsistent there... Rob > Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index ac7269f..ab97459 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -68,6 +68,7 @@ img Imagination Technologies Ltd. > intel Intel Corporation > intercontrol Inter Control Group > isee ISEE 2007 S.L. > +isil Intersil (deprecated, use isl) > isl Intersil > karo Ka-Ro electronics GmbH > keymile Keymile GmbH > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas 2014-10-07 15:19 ` [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas 2014-10-07 15:19 ` [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Darshana Padmadas @ 2014-10-07 15:19 ` Darshana Padmadas 2014-10-09 19:43 ` Jonathan Cameron 2014-10-07 15:19 ` [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Darshana Padmadas 2014-10-08 9:15 ` [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Dan Carpenter 4 siblings, 1 reply; 11+ messages in thread From: Darshana Padmadas @ 2014-10-07 15:19 UTC (permalink / raw) To: linux-arm-kernel This patch adds the correct vendor-prefix for device isl29028 and maintains deprecated vendor-prefix found by checkpatch warning for older kernel releases. Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> --- drivers/staging/iio/light/isl29028.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 6014625..e969107 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = { MODULE_DEVICE_TABLE(i2c, isl29028_id); static const struct of_device_id isl29028_of_match[] = { - { .compatible = "isil,isl29028", }, + { .compatible = "isl,isl29028", }, + { .compatible = "isil,isl29028", },/* deprecated, don't use */ { }, }; MODULE_DEVICE_TABLE(of, isl29028_of_match); -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 2014-10-07 15:19 ` [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 Darshana Padmadas @ 2014-10-09 19:43 ` Jonathan Cameron 0 siblings, 0 replies; 11+ messages in thread From: Jonathan Cameron @ 2014-10-09 19:43 UTC (permalink / raw) To: linux-arm-kernel On 07/10/14 16:19, Darshana Padmadas wrote: > This patch adds the correct vendor-prefix for device isl29028 and > maintains deprecated vendor-prefix found by checkpatch warning > for older kernel releases. > > Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> Acked-by: Jonathan Cameron <jic23@kernel.org> Which tree does this series want to go through? (I'm happy to take it via IIO once the outstanding issues are cleaned up if no one else wants it). > --- > drivers/staging/iio/light/isl29028.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c > index 6014625..e969107 100644 > --- a/drivers/staging/iio/light/isl29028.c > +++ b/drivers/staging/iio/light/isl29028.c > @@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = { > MODULE_DEVICE_TABLE(i2c, isl29028_id); > > static const struct of_device_id isl29028_of_match[] = { > - { .compatible = "isil,isl29028", }, > + { .compatible = "isl,isl29028", }, > + { .compatible = "isil,isl29028", },/* deprecated, don't use */ > { }, > }; > MODULE_DEVICE_TABLE(of, isl29028_of_match); > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas ` (2 preceding siblings ...) 2014-10-07 15:19 ` [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 Darshana Padmadas @ 2014-10-07 15:19 ` Darshana Padmadas 2014-10-07 16:28 ` Rob Herring 2014-10-08 9:15 ` [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Dan Carpenter 4 siblings, 1 reply; 11+ messages in thread From: Darshana Padmadas @ 2014-10-07 15:19 UTC (permalink / raw) To: linux-arm-kernel This patch adds the correct vendor-prefix listed in Documentation/devicetree/bindings/vendor-prefixes.txt with the device name to compatible property. Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> --- arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index 2063795..dcc6c75 100644 --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi @@ -187,7 +187,7 @@ /* ALS and Proximity sensor */ isl29028 at 44 { - compatible = "isil,isl29028"; + compatible = "isl,isl29028"; reg = <0x44>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>; -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property 2014-10-07 15:19 ` [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Darshana Padmadas @ 2014-10-07 16:28 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2014-10-07 16:28 UTC (permalink / raw) To: linux-arm-kernel On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas <darshanapadmadas@gmail.com> wrote: > This patch adds the correct vendor-prefix listed in Documentation/devicetree/bindings/vendor-prefixes.txt > with the device name to compatible property. It would be nice if the subject and msg gave some clue as to which binding and platform you are changing. Look at prior commits and follow their pattern for subject. Rob > > Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com> > --- > arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > index 2063795..dcc6c75 100644 > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi > @@ -187,7 +187,7 @@ > > /* ALS and Proximity sensor */ > isl29028 at 44 { > - compatible = "isil,isl29028"; > + compatible = "isl,isl29028"; > reg = <0x44>; > interrupt-parent = <&gpio>; > interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas ` (3 preceding siblings ...) 2014-10-07 15:19 ` [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Darshana Padmadas @ 2014-10-08 9:15 ` Dan Carpenter 2014-10-08 12:50 ` Sergei Shtylyov 4 siblings, 1 reply; 11+ messages in thread From: Dan Carpenter @ 2014-10-08 9:15 UTC (permalink / raw) To: linux-arm-kernel These probably should have been sent to devicetree at vger.kernel.org. Use the maintainer.pl script. regards, dan carpenter ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 2014-10-08 9:15 ` [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Dan Carpenter @ 2014-10-08 12:50 ` Sergei Shtylyov 0 siblings, 0 replies; 11+ messages in thread From: Sergei Shtylyov @ 2014-10-08 12:50 UTC (permalink / raw) To: linux-arm-kernel Hello. On 10/8/2014 1:15 PM, Dan Carpenter wrote: > These probably should have been sent to devicetree at vger.kernel.org. Use > the maintainer.pl script. You surely meant scripts/get_maintainer.pl. :-) > regards, > dan carpenter WBR, Sergei ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-10-09 19:43 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-10-07 15:19 [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas 2014-10-07 15:19 ` [PATCH v4 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas 2014-10-07 15:36 ` Mark Rutland 2014-10-07 15:19 ` [PATCH v4 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Darshana Padmadas 2014-10-07 16:33 ` Rob Herring 2014-10-07 15:19 ` [PATCH v4 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 Darshana Padmadas 2014-10-09 19:43 ` Jonathan Cameron 2014-10-07 15:19 ` [PATCH v4 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Darshana Padmadas 2014-10-07 16:28 ` Rob Herring 2014-10-08 9:15 ` [PATCH v4 0/4] Correct vendor-prefix and document device isl29028 Dan Carpenter 2014-10-08 12:50 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).