linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities
@ 2015-03-20  6:49 Chen-Yu Tsai
  2015-03-20  6:49 ` [PATCH v2 1/2] ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting Chen-Yu Tsai
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2015-03-20  6:49 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Maxime,

Here's v2 of the sunxi cpufreq dts fixes, aimed at 4.0.

The first patch limits the Olimex A10-Lime to 912MHz, as a few people
reported on IRC that it was unstable at 1008MHz.

The second patch removes the overclocking settings from sun[457]i dts,
so all the boards will be stable, regardless of whether regulators
were added or not.

I would like to revisit this after the new OPP bindings are merged
and support added to cpufreq-dt.


Changes since v1:

  - Added sun4i dts fixes
  - Corrected A10-Lime settings to match sun4i


Regards
ChenYu


Chen-Yu Tsai (2):
  ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting
  ARM: dts: sunxi: Remove overclocked/overvoltaged OPP

 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 11 +++++++++++
 arch/arm/boot/dts/sun4i-a10.dtsi               |  3 +--
 arch/arm/boot/dts/sun5i-a13.dtsi               |  3 +--
 arch/arm/boot/dts/sun7i-a20.dtsi               |  3 +--
 4 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2 1/2] ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting
  2015-03-20  6:49 [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Chen-Yu Tsai
@ 2015-03-20  6:49 ` Chen-Yu Tsai
  2015-03-20  6:49 ` [PATCH v2 2/2] ARM: dts: sunxi: Remove overclocked/overvoltaged OPP Chen-Yu Tsai
  2015-03-21 18:20 ` [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Maxime Ripard
  2 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2015-03-20  6:49 UTC (permalink / raw)
  To: linux-arm-kernel

The Olimex A10-Lime is known to be unstable when running at 1008MHz.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
index 31dc2f1c3870..df9535b5009c 100644
--- a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
+++ b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
@@ -74,6 +74,17 @@
 	status = "okay";
 };
 
+&cpu0 {
+	/* The A10-Lime is known to be unstable when running at 1008 MHz */
+	operating-points = <
+		/* kHz    uV */
+		912000  1350000
+		864000  1300000
+		624000  1250000
+		>;
+	cooling-max-level = <2>;
+};
+
 &ehci0 {
 	status = "okay";
 };
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2 2/2] ARM: dts: sunxi: Remove overclocked/overvoltaged OPP
  2015-03-20  6:49 [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Chen-Yu Tsai
  2015-03-20  6:49 ` [PATCH v2 1/2] ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting Chen-Yu Tsai
@ 2015-03-20  6:49 ` Chen-Yu Tsai
  2015-03-21 18:20 ` [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Maxime Ripard
  2 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2015-03-20  6:49 UTC (permalink / raw)
  To: linux-arm-kernel

Without proper regulator support for individual boards, it is dangerous
to have overclocked/overvoltaged OPPs in the list. Cpufreq will increase
the frequency without the accompanying voltage increase, resulting in
an unstable system.

Remove them for now. We can revisit them with the new version of OPP
bindings, which support boost settings and frequency ranges, among
other things.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 3 +--
 arch/arm/boot/dts/sun5i-a13.dtsi | 3 +--
 arch/arm/boot/dts/sun7i-a20.dtsi | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index c66352bb977c..17e4598db176 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -111,7 +111,6 @@
 			clock-latency = <244144>; /* 8 32k periods */
 			operating-points = <
 				/* kHz    uV */
-				1056000 1500000
 				1008000 1400000
 				912000  1350000
 				864000  1300000
@@ -119,7 +118,7 @@
 				>;
 			#cooling-cells = <2>;
 			cooling-min-level = <0>;
-			cooling-max-level = <4>;
+			cooling-max-level = <3>;
 		};
 	};
 
diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
index 5d9ce84486bb..39264f7c7ae6 100644
--- a/arch/arm/boot/dts/sun5i-a13.dtsi
+++ b/arch/arm/boot/dts/sun5i-a13.dtsi
@@ -140,7 +140,6 @@
 	clock-latency = <244144>; /* 8 32k periods */
 	operating-points = <
 		/* kHz    uV */
-		1104000	1500000
 		1008000 1400000
 		912000  1350000
 		864000  1300000
@@ -150,7 +149,7 @@
 		>;
 	#cooling-cells = <2>;
 	cooling-min-level = <0>;
-	cooling-max-level = <6>;
+	cooling-max-level = <5>;
 };
 
 &ehci0 {
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 3a8530b79f1c..fdd181792b4b 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -105,7 +105,6 @@
 			clock-latency = <244144>; /* 8 32k periods */
 			operating-points = <
 				/* kHz    uV */
-				1008000 1450000
 				960000  1400000
 				912000  1400000
 				864000  1300000
@@ -116,7 +115,7 @@
 				>;
 			#cooling-cells = <2>;
 			cooling-min-level = <0>;
-			cooling-max-level = <7>;
+			cooling-max-level = <6>;
 		};
 
 		cpu at 1 {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities
  2015-03-20  6:49 [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Chen-Yu Tsai
  2015-03-20  6:49 ` [PATCH v2 1/2] ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting Chen-Yu Tsai
  2015-03-20  6:49 ` [PATCH v2 2/2] ARM: dts: sunxi: Remove overclocked/overvoltaged OPP Chen-Yu Tsai
@ 2015-03-21 18:20 ` Maxime Ripard
  2015-03-23 23:43   ` Chen-Yu Tsai
  2 siblings, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2015-03-21 18:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Mar 20, 2015 at 02:49:18PM +0800, Chen-Yu Tsai wrote:
> Hi Maxime,
> 
> Here's v2 of the sunxi cpufreq dts fixes, aimed at 4.0.
> 
> The first patch limits the Olimex A10-Lime to 912MHz, as a few people
> reported on IRC that it was unstable at 1008MHz.
> 
> The second patch removes the overclocking settings from sun[457]i dts,
> so all the boards will be stable, regardless of whether regulators
> were added or not.
> 
> I would like to revisit this after the new OPP bindings are merged
> and support added to cpufreq-dt.

Applied both, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150321/6037c727/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities
  2015-03-21 18:20 ` [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Maxime Ripard
@ 2015-03-23 23:43   ` Chen-Yu Tsai
  2015-03-24  0:07     ` Maxime Ripard
  0 siblings, 1 reply; 6+ messages in thread
From: Chen-Yu Tsai @ 2015-03-23 23:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Mar 21, 2015 at 11:20 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Fri, Mar 20, 2015 at 02:49:18PM +0800, Chen-Yu Tsai wrote:
>> Hi Maxime,
>>
>> Here's v2 of the sunxi cpufreq dts fixes, aimed at 4.0.
>>
>> The first patch limits the Olimex A10-Lime to 912MHz, as a few people
>> reported on IRC that it was unstable at 1008MHz.
>>
>> The second patch removes the overclocking settings from sun[457]i dts,
>> so all the boards will be stable, regardless of whether regulators
>> were added or not.
>>
>> I would like to revisit this after the new OPP bindings are merged
>> and support added to cpufreq-dt.
>
> Applied both, thanks!

I see you applied them under sunxi/dt-for-4.1.
Shouldn't we merge them for 4.0 fixes?

ChenYu

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities
  2015-03-23 23:43   ` Chen-Yu Tsai
@ 2015-03-24  0:07     ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2015-03-24  0:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 23, 2015 at 04:43:09PM -0700, Chen-Yu Tsai wrote:
> On Sat, Mar 21, 2015 at 11:20 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Fri, Mar 20, 2015 at 02:49:18PM +0800, Chen-Yu Tsai wrote:
> >> Hi Maxime,
> >>
> >> Here's v2 of the sunxi cpufreq dts fixes, aimed at 4.0.
> >>
> >> The first patch limits the Olimex A10-Lime to 912MHz, as a few people
> >> reported on IRC that it was unstable at 1008MHz.
> >>
> >> The second patch removes the overclocking settings from sun[457]i dts,
> >> so all the boards will be stable, regardless of whether regulators
> >> were added or not.
> >>
> >> I would like to revisit this after the new OPP bindings are merged
> >> and support added to cpufreq-dt.
> >
> > Applied both, thanks!
> 
> I see you applied them under sunxi/dt-for-4.1.
> Shouldn't we merge them for 4.0 fixes?

Your patch doesn't apply on 4.0 unfortunately.

I dropped it at the moment, would you care to resend it?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150323/ec649fec/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-24  0:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-20  6:49 [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Chen-Yu Tsai
2015-03-20  6:49 ` [PATCH v2 1/2] ARM: dts: sun4i: a10-lime: Override and remove 1008MHz OPP setting Chen-Yu Tsai
2015-03-20  6:49 ` [PATCH v2 2/2] ARM: dts: sunxi: Remove overclocked/overvoltaged OPP Chen-Yu Tsai
2015-03-21 18:20 ` [PATCH v2 0/2] ARM: dts: sunxi: Fix cpufreq instabilities Maxime Ripard
2015-03-23 23:43   ` Chen-Yu Tsai
2015-03-24  0:07     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).