linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114
@ 2015-08-08 13:58 Nicolas Chauvet
  2015-08-12 15:01 ` Paul Walmsley
  2015-08-13 14:16 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Chauvet @ 2015-08-08 13:58 UTC (permalink / raw)
  To: linux-arm-kernel

Current base address is wrong by 0x04 bytes for AHB bus device as shown in dmesg:
 tegra-ahb 6000c004.ahb: incorrect AHB base address in DT data - enabling workaround

To correct old dtbs,  the commit ce7a10b0ff3db63 checks for the low bit
of the base address and removes theses 0x04 bytes at runtime.

This patch fix the original dts, so upstream version doesn't need
the workaround of the base address.

As both addresses are valid, this patch doesn't break compatibility

Tested on tegra20-paz00 (aka ac100)

Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
---
 arch/arm/boot/dts/tegra114.dtsi | 4 ++--
 arch/arm/boot/dts/tegra20.dtsi  | 4 ++--
 arch/arm/boot/dts/tegra30.dtsi  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index f58a3d9..4bdf8f9 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -214,9 +214,9 @@
 		#dma-cells = <1>;
 	};
 
-	ahb: ahb at 6000c004 {
+	ahb: ahb at 6000c000 {
 		compatible = "nvidia,tegra114-ahb", "nvidia,tegra30-ahb";
-		reg = <0x6000c004 0x14c>;
+		reg = <0x6000c000 0x150>;
 	};
 
 	gpio: gpio at 6000d000 {
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index f444b67..f6f1461 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -225,9 +225,9 @@
 		#dma-cells = <1>;
 	};
 
-	ahb at 6000c004 {
+	ahb at 6000c000 {
 		compatible = "nvidia,tegra20-ahb";
-		reg = <0x6000c004 0x10c>; /* AHB Arbitration + Gizmo Controller */
+		reg = <0x6000c000 0x110>; /* AHB Arbitration + Gizmo Controller */
 	};
 
 	gpio: gpio at 6000d000 {
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index 782b11b..559763e 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -329,9 +329,9 @@
 		#dma-cells = <1>;
 	};
 
-	ahb: ahb at 6000c004 {
+	ahb: ahb at 6000c000 {
 		compatible = "nvidia,tegra30-ahb";
-		reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
+		reg = <0x6000c000 0x150>; /* AHB Arbitration + Gizmo Controller */
 	};
 
 	gpio: gpio at 6000d000 {
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114
  2015-08-08 13:58 [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114 Nicolas Chauvet
@ 2015-08-12 15:01 ` Paul Walmsley
  2015-08-13 14:16 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2015-08-12 15:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, 8 Aug 2015, Nicolas Chauvet wrote:

> Current base address is wrong by 0x04 bytes for AHB bus device as shown in dmesg:
>  tegra-ahb 6000c004.ahb: incorrect AHB base address in DT data - enabling workaround
> 
> To correct old dtbs,  the commit ce7a10b0ff3db63 checks for the low bit
> of the base address and removes theses 0x04 bytes at runtime.
> 
> This patch fix the original dts, so upstream version doesn't need
> the workaround of the base address.
> 
> As both addresses are valid, this patch doesn't break compatibility
> 
> Tested on tegra20-paz00 (aka ac100)
> 
> Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>

Reviewed-by: Paul Walmsley <paul@pwsan.com>


- Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114
  2015-08-08 13:58 [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114 Nicolas Chauvet
  2015-08-12 15:01 ` Paul Walmsley
@ 2015-08-13 14:16 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2015-08-13 14:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Aug 08, 2015 at 03:58:12PM +0200, Nicolas Chauvet wrote:
> Current base address is wrong by 0x04 bytes for AHB bus device as shown in dmesg:
>  tegra-ahb 6000c004.ahb: incorrect AHB base address in DT data - enabling workaround
> 
> To correct old dtbs,  the commit ce7a10b0ff3db63 checks for the low bit
> of the base address and removes theses 0x04 bytes at runtime.
> 
> This patch fix the original dts, so upstream version doesn't need
> the workaround of the base address.
> 
> As both addresses are valid, this patch doesn't break compatibility
> 
> Tested on tegra20-paz00 (aka ac100)
> 
> Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
> ---
>  arch/arm/boot/dts/tegra114.dtsi | 4 ++--
>  arch/arm/boot/dts/tegra20.dtsi  | 4 ++--
>  arch/arm/boot/dts/tegra30.dtsi  | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150813/f2090462/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-13 14:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-08 13:58 [PATCH] [ARM][TEGRA] Fix AHB base address on tegra20, tegra30 and tegra114 Nicolas Chauvet
2015-08-12 15:01 ` Paul Walmsley
2015-08-13 14:16 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).