From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn
Date: Tue, 01 Sep 2015 13:37:18 -0700 [thread overview]
Message-ID: <1441139838.12163.5.camel@perches.com> (raw)
In-Reply-To: <1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org>
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> Return value would give clear information about the actual root-cause
> of the failure.
I'm not sure why that is as nearly every error path in
sdhci_add_host emits a message.
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
[]
> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>
> ret = sdhci_add_host(host);
> if (ret) {
> - dev_err(&pdev->dev, "failed to add host\n");
> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret);
> goto err_add_host;
> }
>
If this is really desirable, there are many other callers of
sdhci_add_host with error messages just like this one.
next prev parent reply other threads:[~2015-09-01 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 19:24 [PATCH 0/2] mmc: sdhci-pxav3: Fix tabbing issue Vaibhav Hiremath
2015-09-01 19:24 ` [PATCH 1/2] " Vaibhav Hiremath
2015-09-01 20:31 ` Joe Perches
2015-09-02 6:29 ` Vaibhav Hiremath
2015-09-02 12:25 ` Vaibhav Hiremath
2015-09-02 6:54 ` Jisheng Zhang
2015-09-02 7:39 ` Vaibhav Hiremath
2015-09-01 19:24 ` [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath
2015-09-01 20:37 ` Joe Perches [this message]
2015-09-02 6:37 ` Vaibhav Hiremath
2015-09-02 13:07 ` Vaibhav Hiremath
2015-09-02 15:07 ` Joe Perches
2015-09-02 15:16 ` Vaibhav Hiremath
2015-09-15 11:53 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441139838.12163.5.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).