From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn
Date: Tue, 15 Sep 2015 13:53:59 +0200 [thread overview]
Message-ID: <CAPDyKFpteaVH16QG0OMYK2G8=nezQF9jdJgAS8sWAY_oDcqCiQ@mail.gmail.com> (raw)
In-Reply-To: <55E712E4.7080608@linaro.org>
On 2 September 2015 at 17:16, Vaibhav Hiremath
<vaibhav.hiremath@linaro.org> wrote:
>
>
> On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote:
>>
>> On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
>>>
>>> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
>>>>
>>>> On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
>>>>>
>>>>> Return value would give clear information about the actual root-cause
>>>>> of the failure.
>>>>> diff --git a/drivers/mmc/host/sdhci-pxav3.c
>>>>> b/drivers/mmc/host/sdhci-pxav3.c
>>>>> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device
>>>>> *pdev)
>>>>>
>>>>> ret = sdhci_add_host(host);
>>>>> if (ret) {
>>>>> - dev_err(&pdev->dev, "failed to add host\n");
>>>>> + dev_err(&pdev->dev, "failed to add host ret - %d\n",
>>>>> ret);
>>>>> goto err_add_host;
>>>>> }
>>>>
>>>>
>>>> If this is really desirable, there are many other callers of
>>>> sdhci_add_host with error messages just like this one.
>>>>
>>> How about this? If you are ok, I can change it and submit the patch
>>> again.
>>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>>
>> []
>>>
>>> @@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host)
>>> mmc->caps |= MMC_CAP_NEEDS_POLL;
>>>
>>> /* If there are external regulators, get them */
>>> - if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER)
>>> + if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) {
>>> + pr_err("%s: regulator supply unavailable, deferring
>>> probe. \n",
>>> + mmc_hostname(mmc));
>>> return -EPROBE_DEFER;
>>> + }
>>
>>
>> (your email client has inappropriate line wrapping)
>>
>> The KERN_<LEVEL> here probably isn't right.
>>
>> Deferring isn't an error, at best it's a notification
>
>
> I would consider it as an ERROR if it gets deferred
> continuously/multiple times due to same reason.
>
>> and perhaps should be at pr_notice/KERN_NOTICE
>>
>
> Yeah, KERN_NOTICE looks right here.
>
>> I don't know how often or how many times this deferral
>> can occur. Do you?
>>
>
> -EDEFER_PROBE usually means that driver has some dependency,
> for which it has to wait.
> In my case, during every boot, I pxav3_sdhci_probe gets deferred once
> due to regulator unavailability.
The driver core already prints a message on the debug level for
-EDEFER_PROBE. Please don't do that in the driver as well.
Kind regards
Uffe
prev parent reply other threads:[~2015-09-15 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 19:24 [PATCH 0/2] mmc: sdhci-pxav3: Fix tabbing issue Vaibhav Hiremath
2015-09-01 19:24 ` [PATCH 1/2] " Vaibhav Hiremath
2015-09-01 20:31 ` Joe Perches
2015-09-02 6:29 ` Vaibhav Hiremath
2015-09-02 12:25 ` Vaibhav Hiremath
2015-09-02 6:54 ` Jisheng Zhang
2015-09-02 7:39 ` Vaibhav Hiremath
2015-09-01 19:24 ` [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn Vaibhav Hiremath
2015-09-01 20:37 ` Joe Perches
2015-09-02 6:37 ` Vaibhav Hiremath
2015-09-02 13:07 ` Vaibhav Hiremath
2015-09-02 15:07 ` Joe Perches
2015-09-02 15:16 ` Vaibhav Hiremath
2015-09-15 11:53 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpteaVH16QG0OMYK2G8=nezQF9jdJgAS8sWAY_oDcqCiQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).