From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 9/9] vfio: platform: check reset call return code during release
Date: Mon, 20 Jun 2016 11:51:19 -0400 [thread overview]
Message-ID: <1466437879-32182-10-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1466437879-32182-1-git-send-email-okaya@codeaurora.org>
Release call is ignoring the return code from reset call and can
potentially continue even though reset call failed.
If reset_required module parameter is set, this patch is going
to validate the return code and will cause stack dump with
WARN_ON and warn the user of failure.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
---
drivers/vfio/platform/vfio_platform_common.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 8509189..900fd7f 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -243,7 +243,15 @@ static void vfio_platform_release(void *device_data)
mutex_lock(&driver_lock);
if (!(--vdev->refcnt)) {
- vfio_platform_call_reset(vdev, NULL);
+ const char *extra_dbg = NULL;
+ int ret;
+
+ ret = vfio_platform_call_reset(vdev, &extra_dbg);
+ if (ret && vdev->reset_required) {
+ dev_warn(vdev->device, "reset driver is required and reset call failed in release (%d) %s\n",
+ ret, extra_dbg ? extra_dbg : "");
+ WARN_ON(1);
+ }
vfio_platform_regions_cleanup(vdev);
vfio_platform_irq_cleanup(vdev);
}
--
1.8.2.1
next prev parent reply other threads:[~2016-06-20 15:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:51 [PATCH V8 0/9] vfio, platform: add ACPI support Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 1/9] vfio: platform: rename reset function Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-06-23 18:34 ` Alex Williamson
2016-07-13 19:36 ` Sinan Kaya
2016-07-13 20:09 ` Alex Williamson
2016-07-13 21:01 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-06-23 18:59 ` Alex Williamson
2016-07-13 20:12 ` Sinan Kaya
2016-07-13 20:55 ` Alex Williamson
2016-07-13 21:34 ` Sinan Kaya
2016-07-13 20:48 ` Sinan Kaya
2016-07-13 21:18 ` Alex Williamson
2016-06-20 15:51 ` [PATCH V8 8/9] vfio: platform: check reset call return code during open Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya [this message]
2016-06-23 7:58 ` [PATCH V8 0/9] vfio, platform: add ACPI support Auger Eric
2016-06-23 15:03 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466437879-32182-10-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).