From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 7/9] vfio, platform: make reset driver a requirement by default
Date: Wed, 13 Jul 2016 16:48:32 -0400 [thread overview]
Message-ID: <eeb13445-a4bb-9230-527c-d85ab4da4c3e@codeaurora.org> (raw)
In-Reply-To: <20160623125955.647008cb@t450s.home>
On 6/23/2016 2:59 PM, Alex Williamson wrote:
>> -static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
>> > +static int vfio_platform_get_reset(struct vfio_platform_device *vdev)
>> > {
>> > if (vdev->acpihid)
>> > - return;
>> > + return vfio_platform_acpi_has_reset(vdev) ? 0 : -ENOENT;
>> >
>> > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat,
>> > &vdev->reset_module);
>> > @@ -140,6 +140,8 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
>> > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat,
>> > &vdev->reset_module);
>> > }
>> > +
>> > + return vdev->of_reset ? 0 : -ENOENT;
>> > }
> nit, this looks more like a:
>
> static bool vfio_platform_has_reset(...)
> ...
> return vfio_platform_acpi_has_reset() == 0;
>
> ...
>
> return vdev->of_reset != NULL
>
Sorry, I didn't understand this comment. The code has get and put functions for DT.
These functions are not useful for ACPI. This is the reason for the above change.
Can you be more specific?
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-07-13 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:51 [PATCH V8 0/9] vfio, platform: add ACPI support Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 1/9] vfio: platform: rename reset function Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-06-23 18:34 ` Alex Williamson
2016-07-13 19:36 ` Sinan Kaya
2016-07-13 20:09 ` Alex Williamson
2016-07-13 21:01 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-06-23 18:59 ` Alex Williamson
2016-07-13 20:12 ` Sinan Kaya
2016-07-13 20:55 ` Alex Williamson
2016-07-13 21:34 ` Sinan Kaya
2016-07-13 20:48 ` Sinan Kaya [this message]
2016-07-13 21:18 ` Alex Williamson
2016-06-20 15:51 ` [PATCH V8 8/9] vfio: platform: check reset call return code during open Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 9/9] vfio: platform: check reset call return code during release Sinan Kaya
2016-06-23 7:58 ` [PATCH V8 0/9] vfio, platform: add ACPI support Auger Eric
2016-06-23 15:03 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb13445-a4bb-9230-527c-d85ab4da4c3e@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).