From: mturquette@baylibre.com (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/10] clk: add Clock driver for nuc970
Date: Mon, 11 Jul 2016 15:14:35 -0700 [thread overview]
Message-ID: <146827527560.73491.7859004638616123566@resonance> (raw)
In-Reply-To: <1468135649-19980-5-git-send-email-vw@iommu.org>
Quoting Wan Zongshun (2016-07-10 00:27:24)
> diff --git a/drivers/clk/nuc900/clk-apll.c b/drivers/clk/nuc900/clk-apll.c
> new file mode 100644
> index 0000000..a05aec7
> --- /dev/null
> +++ b/drivers/clk/nuc900/clk-apll.c
> @@ -0,0 +1,168 @@
> +/*
> + * Copyright 2016 Wan Zongshun <mcuos.com@gmail.com>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/clk-provider.h>
> +#include <linux/io.h>
> +#include <linux/slab.h>
> +#include <linux/kernel.h>
> +#include <linux/err.h>
> +
> +#include "clk-ccf.h"
Maybe call it clk-nuc.h?
> +static struct clk_ops clk_apll_ops = {
> + .recalc_rate = clk_apll_recalc_rate,
> + .enable = clk_apll_enable,
> + .disable = clk_apll_disable,
Can you provide a .is_enabled?
> +static void __init nuc970_clocks_init(struct device_node *np)
> +{
> + int i, ret;
> +
> + clkctrl = of_iomap(np, 0);
> + if (!clkctrl)
> + pr_err("%s: unable to map registers\n", np->full_name);
> +
> +
> + /* source */
> + clk[XIN] = nuc970_clk_fixed("xin", 12000000);
> + clk[XIN32K] = nuc970_clk_fixed("xin32k", 32768);
> + clk[APLL] = nuc970_clk_apll("apll", "xin", REG_CLK_APLLCON);
> + clk[UPLL] = nuc970_clk_upll("upll", "xin", REG_CLK_UPLLCON);
> + clk[XIN128_DIV] = nuc970_clk_fixed_factor("xin128_div", "xin", 1, 128);
> + clk[SYS_MUX] = nuc970_clk_mux("sys_mux", REG_CLK_DIV0, 3, 2,
> + sys_sel_clks,
> + ARRAY_SIZE(sys_sel_clks));
Instead of executing all of these registration functions, how about
initializing your clock data statically, and then simply calling
clk_hw_register?
For an example see the recently merged drivers/clk/meson/gxbb.c
> + for (i = 0; i < ARRAY_SIZE(clk); i++)
> + if (IS_ERR(clk[i]))
> + pr_err("nuc970 clk %d: register failed with %ld\n",
> + i, PTR_ERR(clk[i]));
Better to fail quickly, bail out and unwind your clk registration
instead of trying to register everything and then walk the list looking
for failures.
> +
> + clk_data.clks = clk;
> + clk_data.clk_num = ARRAY_SIZE(clk);
> +
> + ret = of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
> + if (ret)
> + pr_err("Failed to register OF clock provider\n");
> +
> + /* Register clock device */
> + clk_register_clkdev(clk[TIMER0_GATE], "timer0", NULL);
> + clk_register_clkdev(clk[TIMER1_GATE], "timer1", NULL);
Again, look at how the gxbb.c driver does this. Why do you need to call
clk_register_clkdev? You're using of_clk_add_provider above, so that
should be enough to perform lookups.
> + /* enable some important clocks */
> + clk_prepare_enable(clk_get(NULL, "cpu"));
> + clk_prepare_enable(clk_get(NULL, "hclk"));
> + clk_prepare_enable(clk_get(NULL, "sram"));
> + clk_prepare_enable(clk_get(NULL, "dram"));
> + clk_prepare_enable(clk_get(NULL, "ddr_hclk"));
You can use the CLK_IS_CRITICAL flag for these clocks if you want. It
would be better to have drivers that claim them and enable them of
course.
> +}
> +
> +CLK_OF_DECLARE(nuc970_clk, "nuvoton,nuc970-clk", nuc970_clocks_init);
Why do you need to use CLK_OF_DECLARE? Please convert this to a
platform_driver and load it at module_init.
Regards,
Mike
next prev parent reply other threads:[~2016-07-11 22:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 7:27 [PATCH v2 00/10] ARM: NUC900: Add NUC970 SoC support Wan Zongshun
2016-07-10 7:27 ` [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support Wan Zongshun
2016-07-10 22:11 ` Arnd Bergmann
2016-07-11 16:04 ` Arnd Bergmann
2016-07-12 4:30 ` Wan Zongshun
2016-07-12 7:14 ` Wan Zongshun
2016-07-12 8:23 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 Wan Zongshun
2016-07-10 21:51 ` Paul Gortmaker
2016-07-11 2:19 ` Wan Zongshun
2016-07-11 15:46 ` Arnd Bergmann
2016-07-12 7:04 ` Wan Zongshun
2016-07-12 8:26 ` Arnd Bergmann
2016-07-14 8:52 ` Wan Zongshun
2016-07-14 11:09 ` Arnd Bergmann
2016-07-13 20:09 ` Jason Cooper
2016-07-14 3:36 ` Wan Zongshun
2016-07-14 13:54 ` Jason Cooper
2016-07-15 5:15 ` Wan Zongshun
2016-07-15 7:00 ` Arnd Bergmann
2016-07-15 9:44 ` Wan ZongShun
2016-07-15 10:02 ` Arnd Bergmann
2016-07-21 18:45 ` Jason Cooper
2016-07-15 15:45 ` Jason Cooper
2016-07-10 7:27 ` [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver Wan Zongshun
2016-07-11 15:36 ` Arnd Bergmann
2016-07-12 7:32 ` Wan Zongshun
2016-07-12 8:28 ` Arnd Bergmann
2016-07-21 12:52 ` Daniel Lezcano
2016-07-21 12:54 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 04/10] clk: add Clock driver for nuc970 Wan Zongshun
2016-07-11 22:14 ` Michael Turquette [this message]
2016-07-10 7:27 ` [PATCH v2 05/10] power/reset: Add reset driver support for nuc900 Wan Zongshun
2016-07-10 21:56 ` Paul Gortmaker
2016-07-11 2:30 ` Wan Zongshun
2016-07-11 2:58 ` Paul Gortmaker
2016-07-10 7:27 ` [PATCH v2 06/10] soc: Add SoC specific " Wan Zongshun
2016-07-11 8:03 ` Arnd Bergmann
2016-07-11 9:07 ` Wan Zongshun
2016-07-11 10:24 ` Arnd Bergmann
2016-07-11 10:28 ` Wan ZongShun
2016-07-11 10:36 ` Arnd Bergmann
2016-07-12 9:06 ` Wan Zongshun
2016-07-12 9:50 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 07/10] ARM: dts: Add clock header file into dt-bindings Wan Zongshun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146827527560.73491.7859004638616123566@resonance \
--to=mturquette@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).