* [PATCH 0/2] dra7: add support for two PCIe ports
@ 2016-07-21 11:57 Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 1/2] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I
0 siblings, 2 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-21 11:57 UTC (permalink / raw)
To: linux-arm-kernel
This series adds patches to support 2 PCIe ports simultaneously
on dra7 based boards.
None of the supported boards exposes 2 PCIe ports. However these are
mandatory changes that would be required in order to support
2 PCIe ports.
This series has been tested to see if there are regressions with 1
PCIe port. Though testing of 2 PCIe ports is not done
while sending this patch series, it has been verified in
few of the customer boards.
Kishon Vijay Abraham I (2):
ARM: dts: DRA7: Add "linux,pci-domain" property for pci dt nodes
ARM: DRA7: select PCI_DOMAINS config
arch/arm/boot/dts/dra7.dtsi | 2 ++
arch/arm/mach-omap2/Kconfig | 1 +
2 files changed, 3 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes
2016-07-21 11:57 [PATCH 0/2] dra7: add support for two PCIe ports Kishon Vijay Abraham I
@ 2016-07-21 11:57 ` Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I
1 sibling, 0 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-21 11:57 UTC (permalink / raw)
To: linux-arm-kernel
Since DRA7 has multiple PCIe Rootcomplex, add "linux,pci-domain"
property to assign a PCI domain number to each of the host
bridges.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 3a8f397..b275f80 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -253,6 +253,7 @@
0x82000000 0 0x20013000 0x13000 0 0xffed000>;
#interrupt-cells = <1>;
num-lanes = <1>;
+ linux,pci-domain = <0>;
ti,hwmods = "pcie1";
phys = <&pcie1_phy>;
phy-names = "pcie-phy0";
@@ -288,6 +289,7 @@
0x82000000 0 0x30013000 0x13000 0 0xffed000>;
#interrupt-cells = <1>;
num-lanes = <1>;
+ linux,pci-domain = <1>;
ti,hwmods = "pcie2";
phys = <&pcie2_phy>;
phy-names = "pcie-phy0";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-21 11:57 [PATCH 0/2] dra7: add support for two PCIe ports Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 1/2] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
@ 2016-07-21 11:57 ` Kishon Vijay Abraham I
2016-07-21 12:04 ` Arnd Bergmann
1 sibling, 1 reply; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-21 11:57 UTC (permalink / raw)
To: linux-arm-kernel
PCI_DOMAINS is required for DRA7x SoCs since there are 2 PCIe
controllers and without PCI_DOMAINS config, only one PCIe
controller gets registered.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
arch/arm/mach-omap2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 1a648e9..8e6e2c0 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -86,6 +86,7 @@ config SOC_DRA7XX
select OMAP_INTERCONNECT_BARRIER
select PM_OPP if PM
select ZONE_DMA if ARM_LPAE
+ select PCI_DOMAINS if PCI
config ARCH_OMAP2PLUS
bool
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-21 11:57 ` [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I
@ 2016-07-21 12:04 ` Arnd Bergmann
2016-07-22 7:16 ` Tony Lindgren
0 siblings, 1 reply; 8+ messages in thread
From: Arnd Bergmann @ 2016-07-21 12:04 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 1a648e9..8e6e2c0 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -86,6 +86,7 @@ config SOC_DRA7XX
> select OMAP_INTERCONNECT_BARRIER
> select PM_OPP if PM
> select ZONE_DMA if ARM_LPAE
> + select PCI_DOMAINS if PCI
>
> config ARCH_OMAP2PLUS
> bool
>
Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-21 12:04 ` Arnd Bergmann
@ 2016-07-22 7:16 ` Tony Lindgren
2016-07-22 8:26 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 8+ messages in thread
From: Tony Lindgren @ 2016-07-22 7:16 UTC (permalink / raw)
To: linux-arm-kernel
* Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > index 1a648e9..8e6e2c0 100644
> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -86,6 +86,7 @@ config SOC_DRA7XX
> > select OMAP_INTERCONNECT_BARRIER
> > select PM_OPP if PM
> > select ZONE_DMA if ARM_LPAE
> > + select PCI_DOMAINS if PCI
> >
> > config ARCH_OMAP2PLUS
> > bool
> >
>
> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
Makes sense to me if many SoCs need this.
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-22 7:16 ` Tony Lindgren
@ 2016-07-22 8:26 ` Kishon Vijay Abraham I
2016-07-22 9:23 ` Sekhar Nori
2016-07-22 13:29 ` Arnd Bergmann
0 siblings, 2 replies; 8+ messages in thread
From: Kishon Vijay Abraham I @ 2016-07-22 8:26 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>> select OMAP_INTERCONNECT_BARRIER
>>> select PM_OPP if PM
>>> select ZONE_DMA if ARM_LPAE
>>> + select PCI_DOMAINS if PCI
>>>
>>> config ARCH_OMAP2PLUS
>>> bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
>
> Makes sense to me if many SoCs need this.
since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
select MULTI_IRQ_HANDLER
select SPARSE_IRQ
select USE_OF
+ select PCI_DOMAINS if PCI
config ARM_SINGLE_ARMV7M
bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"
Thanks
Kishon
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-22 8:26 ` Kishon Vijay Abraham I
@ 2016-07-22 9:23 ` Sekhar Nori
2016-07-22 13:29 ` Arnd Bergmann
1 sibling, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2016-07-22 9:23 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 22 July 2016 01:56 PM, Kishon Vijay Abraham I wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..0cccb50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
> select MULTI_IRQ_HANDLER
> select SPARSE_IRQ
> select USE_OF
> + select PCI_DOMAINS if PCI
Keep the select list in sorted order.
Regards,
Sekhar
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
2016-07-22 8:26 ` Kishon Vijay Abraham I
2016-07-22 9:23 ` Sekhar Nori
@ 2016-07-22 13:29 ` Arnd Bergmann
1 sibling, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-07-22 13:29 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, July 22, 2016 1:56:47 PM CEST Kishon Vijay Abraham I wrote:
>
> since it doesn't harm even if a platform has a single PCIe port, it should be
> okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
> okay.
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 90542db..0cccb50 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
> select MULTI_IRQ_HANDLER
> select SPARSE_IRQ
> select USE_OF
> + select PCI_DOMAINS if PCI
>
Sounds good, but please remove all other 'select PCI_DOMAINS if PCI'
statements in arch/arm then in the same patch.
I have checked that all of them are for ARCH_MULTIPLATFORM based machines.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-07-22 13:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 11:57 [PATCH 0/2] dra7: add support for two PCIe ports Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 1/2] ARM: dts: DRA7: Add "linux, pci-domain" property for pci dt nodes Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I
2016-07-21 12:04 ` Arnd Bergmann
2016-07-22 7:16 ` Tony Lindgren
2016-07-22 8:26 ` Kishon Vijay Abraham I
2016-07-22 9:23 ` Sekhar Nori
2016-07-22 13:29 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).