* [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
@ 2017-05-24 14:33 srishti sharma
2017-05-24 23:28 ` Tobin C. Harding
0 siblings, 1 reply; 4+ messages in thread
From: srishti sharma @ 2017-05-24 14:33 UTC (permalink / raw)
To: linux-arm-kernel
fixed a trailing */ issue
Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
/* bcm2835 supports only consumer mode and sets all other format flags
- * automatically. So the only thing left is signalling non-audio
- * content */
+ * automatically. So the only thing left is signalling non-audio content
+ */
ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
return 0;
}
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
2017-05-24 14:33 [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue srishti sharma
@ 2017-05-24 23:28 ` Tobin C. Harding
2017-05-25 5:22 ` srishti sharma
2017-05-25 6:59 ` Stefan Wahren
0 siblings, 2 replies; 4+ messages in thread
From: Tobin C. Harding @ 2017-05-24 23:28 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
This driver is not in Greg KH's staging tree. You may like to work off
of that tree when doing staging patches.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
To aid you future patches here are a couple of minor comments for you.
> fixed a trailing */ issue
You may like to be more explicit here using the format described in
Documentation/process/submitting-patches.rst (Section 2 Describe your
changes). This goes for your subject line as well.
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> index a4ffa1b..38fabab 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
> @@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
> struct snd_ctl_elem_value *ucontrol)
> {
> /* bcm2835 supports only consumer mode and sets all other format flags
> - * automatically. So the only thing left is signalling non-audio
> - * content */
> + * automatically. So the only thing left is signalling non-audio content
> + */
And for completeness this is the block comment style in networking
code, the rest of the kernel uses the format
/*
* block comment blah blah
* on multiple lines
*/
Good luck,
Tobin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
2017-05-24 23:28 ` Tobin C. Harding
@ 2017-05-25 5:22 ` srishti sharma
2017-05-25 6:59 ` Stefan Wahren
1 sibling, 0 replies; 4+ messages in thread
From: srishti sharma @ 2017-05-25 5:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 25, 2017 at 4:58 AM, Tobin C. Harding <me@tobin.cc> wrote:
> On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
>
> This driver is not in Greg KH's staging tree. You may like to work off
> of that tree when doing staging patches.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
>
> To aid you future patches here are a couple of minor comments for you.
>
>> fixed a trailing */ issue
>
> You may like to be more explicit here using the format described in
> Documentation/process/submitting-patches.rst (Section 2 Describe your
> changes). This goes for your subject line as well.
>
>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>> ---
>> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
>> index a4ffa1b..38fabab 100644
>> --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
>> +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
>> @@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
>> struct snd_ctl_elem_value *ucontrol)
>> {
>> /* bcm2835 supports only consumer mode and sets all other format flags
>> - * automatically. So the only thing left is signalling non-audio
>> - * content */
>> + * automatically. So the only thing left is signalling non-audio content
>> + */
>
> And for completeness this is the block comment style in networking
> code, the rest of the kernel uses the format
>
> /*
> * block comment blah blah
> * on multiple lines
> */
>
> Good luck,
> Tobin.
Okay, Thanks a lot .
Regards ,
Srishti
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.
2017-05-24 23:28 ` Tobin C. Harding
2017-05-25 5:22 ` srishti sharma
@ 2017-05-25 6:59 ` Stefan Wahren
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2017-05-25 6:59 UTC (permalink / raw)
To: linux-arm-kernel
> "Tobin C. Harding" <me@tobin.cc> hat am 25. Mai 2017 um 01:28 geschrieben:
>
>
> On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
>
> This driver is not in Greg KH's staging tree.
The driver has moved to drivers/staging/vc04_services/bcm2835-audio
> You may like to work off
> of that tree when doing staging patches.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-25 6:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-24 14:33 [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue srishti sharma
2017-05-24 23:28 ` Tobin C. Harding
2017-05-25 5:22 ` srishti sharma
2017-05-25 6:59 ` Stefan Wahren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).