* [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support
@ 2017-07-07 13:12 Biju Das
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
0 siblings, 2 replies; 11+ messages in thread
From: Biju Das @ 2017-07-07 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
This series aims to add device tree support for Ethernet AVB on R8A7743 SoC/iwg20d-q7 platform
This series has been tested against linux-next tag next-20170704.
It depends upon the patch
https://www.mail-archive.com/netdev at vger.kernel.org/msg176852.html
Biju Das (2):
ARM: dts: r8a7743: Add Ethernet AVB support
ARM: dts: iwg20d-q7: Add Ethernet AVB support
arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 21 +++++++++++++++++++++
arch/arm/boot/dts/r8a7743.dtsi | 13 +++++++++++++
2 files changed, 34 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-07 13:12 [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support Biju Das
@ 2017-07-07 13:12 ` Biju Das
2017-07-07 17:23 ` Sergei Shtylyov
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
1 sibling, 2 replies; 11+ messages in thread
From: Biju Das @ 2017-07-07 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Add Ethernet AVB support for r8a7743 SoC.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 8380859..ec8657f 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -605,6 +605,19 @@
#size-cells = <0>;
status = "disabled";
};
+
+ avb: ethernet at e6800000 {
+ compatible = "renesas,etheravb-r8a7743",
+ "renesas,etheravb-rcar-gen2";
+ reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
+ interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 812>;
+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+ resets = <&cpg 812>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
/* External root clock */
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v 2/2] ARM: dts: iwg20d-q7: Add Ethernet AVB support
2017-07-07 13:12 [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support Biju Das
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
@ 2017-07-07 13:12 ` Biju Das
2017-07-10 8:03 ` Geert Uytterhoeven
1 sibling, 1 reply; 11+ messages in thread
From: Biju Das @ 2017-07-07 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Define the iWave RainboW-G20D-Qseven board dependent part of the Ethernet
AVB device node.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
index 497aec0..081af01 100644
--- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
+++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
@@ -17,6 +17,7 @@
aliases {
serial0 = &scif0;
+ ethernet0 = &avb;
};
};
@@ -25,6 +26,11 @@
groups = "scif0_data_d";
function = "scif0";
};
+
+ avb_pins: avb {
+ groups = "avb_mdio", "avb_gmii";
+ function = "avb";
+ };
};
&scif0 {
@@ -33,3 +39,18 @@
status = "okay";
};
+
+&avb {
+ pinctrl-0 = <&avb_pins>;
+ pinctrl-names = "default";
+
+ phy-handle = <&phy3>;
+ phy-mode = "gmii";
+ renesas,no-ether-link;
+ status = "okay";
+
+ phy3: ethernet-phy at 3 {
+ reg = <3>;
+ micrel,led-mode = <1>;
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
@ 2017-07-07 17:23 ` Sergei Shtylyov
2017-07-10 7:54 ` Geert Uytterhoeven
1 sibling, 0 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2017-07-07 17:23 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 07/07/2017 04:12 PM, Biju Das wrote:
> Add Ethernet AVB support for r8a7743 SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
2017-07-07 17:23 ` Sergei Shtylyov
@ 2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 8:21 ` Biju Das
2017-07-10 8:23 ` Simon Horman
1 sibling, 2 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 7:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Biju,
On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add Ethernet AVB support for r8a7743 SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
With the minor nit below fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -605,6 +605,19 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + avb: ethernet at e6800000 {
> + compatible = "renesas,etheravb-r8a7743",
> + "renesas,etheravb-rcar-gen2";
> + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
s/0/GIC_SPI/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 2/2] ARM: dts: iwg20d-q7: Add Ethernet AVB support
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
@ 2017-07-10 8:03 ` Geert Uytterhoeven
2017-07-10 8:24 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 8:03 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Define the iWave RainboW-G20D-Qseven board dependent part of the Ethernet
> AVB device node.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-10 7:54 ` Geert Uytterhoeven
@ 2017-07-10 8:21 ` Biju Das
2017-07-10 8:23 ` Simon Horman
1 sibling, 0 replies; 11+ messages in thread
From: Biju Das @ 2017-07-10 8:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
Thanks for the review.
> -----Original Message-----
> From: geert.uytterhoeven at gmail.com [mailto:geert.uytterhoeven at gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Russell King <linux@armlinux.org.uk>; Sergei
> Shtylyov <sergei.shtylyov@cogentembedded.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; devicetree at vger.kernel.org; Linux-
> Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + avb: ethernet at e6800000 {
> > + compatible = "renesas,etheravb-r8a7743",
> > + "renesas,etheravb-rcar-gen2";
> > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>
OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 8:21 ` Biju Das
@ 2017-07-10 8:23 ` Simon Horman
2017-07-10 8:36 ` Simon Horman
1 sibling, 1 reply; 11+ messages in thread
From: Simon Horman @ 2017-07-10 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + avb: ethernet at e6800000 {
> > + compatible = "renesas,etheravb-r8a7743",
I do not see a patch to add "renesas,etheravb-r8a7743" to
Documentation/devicetree/bindings/net/renesas,ravb.txt
If you haven't already done so please post a patch to add this
once net-next re-opens.
> > + "renesas,etheravb-rcar-gen2";
> > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>
> s/0/GIC_SPI/
Thanks, I have applied this patch with the minor update above.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 2/2] ARM: dts: iwg20d-q7: Add Ethernet AVB support
2017-07-10 8:03 ` Geert Uytterhoeven
@ 2017-07-10 8:24 ` Simon Horman
0 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2017-07-10 8:24 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 10:03:52AM +0200, Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Define the iWave RainboW-G20D-Qseven board dependent part of the Ethernet
> > AVB device node.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-10 8:23 ` Simon Horman
@ 2017-07-10 8:36 ` Simon Horman
2017-07-10 9:17 ` Biju Das
0 siblings, 1 reply; 11+ messages in thread
From: Simon Horman @ 2017-07-10 8:36 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 10:23:51AM +0200, Simon Horman wrote:
> On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> > Hi Biju,
> >
> > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > > Add Ethernet AVB support for r8a7743 SoC.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> >
> > With the minor nit below fixed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > > @@ -605,6 +605,19 @@
> > > #size-cells = <0>;
> > > status = "disabled";
> > > };
> > > +
> > > + avb: ethernet at e6800000 {
> > > + compatible = "renesas,etheravb-r8a7743",
>
> I do not see a patch to add "renesas,etheravb-r8a7743" to
> Documentation/devicetree/bindings/net/renesas,ravb.txt
>
> If you haven't already done so please post a patch to add this
> once net-next re-opens.
I now see "ravb: Document binding for r8a7743 SoC"
>
> > > + "renesas,etheravb-rcar-gen2";
> > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
> >
> > s/0/GIC_SPI/
>
> Thanks, I have applied this patch with the minor update above.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
2017-07-10 8:36 ` Simon Horman
@ 2017-07-10 9:17 ` Biju Das
0 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2017-07-10 9:17 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
Thanks for the review.
Regards,
Biju
> -----Original Message-----
> From: Simon Horman [mailto:horms at verge.net.au]
> Sent: 10 July 2017 09:37
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Mark Rutland <mark.rutland@arm.com>; devicetree at vger.kernel.org;
> Chris Paterson <Chris.Paterson2@renesas.com>; Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>; Magnus Damm
> <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; Biju Das
> <biju.das@bp.renesas.com>; Linux-Renesas <linux-renesas-
> soc at vger.kernel.org>; Rob Herring <robh+dt@kernel.org>; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> On Mon, Jul 10, 2017 at 10:23:51AM +0200, Simon Horman wrote:
> > On Mon, Jul 10, 2017 at 09:54:40AM +0200, Geert Uytterhoeven wrote:
> > > Hi Biju,
> > >
> > > On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > > > Add Ethernet AVB support for r8a7743 SoC.
> > > >
> > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > >
> > > With the minor nit below fixed:
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > > > @@ -605,6 +605,19 @@
> > > > #size-cells = <0>;
> > > > status = "disabled";
> > > > };
> > > > +
> > > > + avb: ethernet at e6800000 {
> > > > + compatible = "renesas,etheravb-r8a7743",
> >
> > I do not see a patch to add "renesas,etheravb-r8a7743" to
> > Documentation/devicetree/bindings/net/renesas,ravb.txt
> >
> > If you haven't already done so please post a patch to add this once
> > net-next re-opens.
>
> I now see "ravb: Document binding for r8a7743 SoC"
I will send the patch with Rob's comments.
> >
> > > > + "renesas,etheravb-rcar-gen2";
> > > > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>;
> > > > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
> > >
> > > s/0/GIC_SPI/
> >
> > Thanks, I have applied this patch with the minor update above.
Thanks Simon.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-07-10 9:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 13:12 [PATCH v 0/2] Add R8A7743/iwg20d-q7 Ethernet AVB support Biju Das
2017-07-07 13:12 ` [PATCH v 1/2] ARM: dts: r8a7743: Add " Biju Das
2017-07-07 17:23 ` Sergei Shtylyov
2017-07-10 7:54 ` Geert Uytterhoeven
2017-07-10 8:21 ` Biju Das
2017-07-10 8:23 ` Simon Horman
2017-07-10 8:36 ` Simon Horman
2017-07-10 9:17 ` Biju Das
2017-07-07 13:12 ` [PATCH v 2/2] ARM: dts: iwg20d-q7: " Biju Das
2017-07-10 8:03 ` Geert Uytterhoeven
2017-07-10 8:24 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).