From: Ryder Lee <ryder.lee@mediatek.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
Sean Wang <sean.wang@kernel.org>,
Weijie Gao <weijie.gao@mediatek.com>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms"
Date: Fri, 18 Jan 2019 17:42:54 +0800 [thread overview]
Message-ID: <1547804574.8124.6.camel@mtkswgap22> (raw)
In-Reply-To: <20190118075925.noilab6glzm3cig6@pengutronix.de>
On Fri, 2019-01-18 at 08:59 +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Jan 18, 2019 at 11:24:41AM +0800, Ryder Lee wrote:
> > This adds a property "mediatek,num-pwms" to avoid having an endless
> > list of compatibles with no differences for the same driver.
> >
> > Thus, the driver should have backwards compatibility to older DTs.
>
> I still think Thierry should bless "num-pwms" without vendor prefix.
Okay.
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > Changes since v1: add some checks for backwards compatibility.
> > ---
> > drivers/pwm/pwm-mediatek.c | 27 ++++++++++++++++++---------
> > 1 file changed, 18 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> > index eb6674c..81b7e5e 100644
> > --- a/drivers/pwm/pwm-mediatek.c
> > +++ b/drivers/pwm/pwm-mediatek.c
> > @@ -55,7 +55,7 @@ enum {
> > };
> >
> > struct mtk_pwm_platform_data {
>
> Unrelated to this patch: This name is bad. This struct is not used as
> platform_data and so should better be named mtk_pwm_of_data. While at
> criticizing existing stuff: I'd prefer pwm_mediatek as common prefix to
> match the filename.
I think we can take care about that in another patch.
> > - unsigned int num_pwms;
> > + unsigned int num_pwms; /* it should not be used in the future SoCs */
>
> I'd drop this comment in favour of a runtime warning.
Sorry, I can't get you here.
> > bool pwm45_fixup;
> > bool has_clks;
> > };
> > @@ -226,27 +226,36 @@ static void mtk_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
> >
> > static int mtk_pwm_probe(struct platform_device *pdev)
> > {
> > - const struct mtk_pwm_platform_data *data;
> > + struct device_node *np = pdev->dev.of_node;
> > struct mtk_pwm_chip *pc;
> > struct resource *res;
> > - unsigned int i;
> > + unsigned int i, num_pwms;
> > int ret;
> >
> > pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
> > if (!pc)
> > return -ENOMEM;
> >
> > - data = of_device_get_match_data(&pdev->dev);
> > - if (data == NULL)
> > - return -EINVAL;
> > - pc->soc = data;
> > + pc->soc = of_device_get_match_data(&pdev->dev);
>
> This might return NULL which ...
The only way to call probe() is to match an entry in
mtk_pwm_of_match[], so match cannot be NULL.
> >
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > pc->regs = devm_ioremap_resource(&pdev->dev, res);
> > if (IS_ERR(pc->regs))
> > return PTR_ERR(pc->regs);
> >
> > - for (i = 0; i < data->num_pwms + 2 && pc->soc->has_clks; i++) {
> > + /* Check if we have set 'num-pwms' in DTs. */
> > + ret = of_property_read_u32(np, "mediatek,num-pwms", &num_pwms);
> > + if (ret < 0) {
> > + /* If no, fallback to use SoC data for backwards compatibility. */
> > + if (pc->soc->num_pwms) {
>
> ... here then results in a NULL pointer dereference. I think you want
So we have no chance to get a NULL pointer, right?
> if (pc->soc)
>
> here.
>
> > + num_pwms = pc->soc->num_pwms;
> > + } else {
> > + dev_err(&pdev->dev, "failed to get pwm number: %d\n", ret);
> > + return ret;
> > + }
> > + }
> > +
> > + for (i = 0; i < num_pwms + 2 && pc->soc->has_clks; i++) {
> > pc->clks[i] = devm_clk_get(&pdev->dev, mtk_pwm_clk_name[i]);
> > if (IS_ERR(pc->clks[i])) {
> > dev_err(&pdev->dev, "clock: %s fail: %ld\n",
> > @@ -260,7 +269,7 @@ static int mtk_pwm_probe(struct platform_device *pdev)
> > pc->chip.dev = &pdev->dev;
> > pc->chip.ops = &mtk_pwm_ops;
> > pc->chip.base = -1;
> > - pc->chip.npwm = data->num_pwms;
> > + pc->chip.npwm = num_pwms;
> >
> > ret = pwmchip_add(&pc->chip);
> > if (ret < 0) {
>
> Best regards
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-18 9:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 3:24 [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Ryder Lee
2019-01-18 3:24 ` [PATCH v1 2/5] dt-bindings: pwm: " Ryder Lee
2019-01-18 8:44 ` Matthias Brugger
2019-01-21 8:43 ` Uwe Kleine-König
2019-02-18 20:36 ` Rob Herring
2019-02-19 7:30 ` Uwe Kleine-König
2019-01-18 3:24 ` [PATCH v1 3/5] arm64: dts: mt7622: add a property "mediatek, num-pwms" for PWM Ryder Lee
2019-01-18 8:01 ` Uwe Kleine-König
2019-01-18 3:24 ` [PATCH v1 4/5] arm: dts: mt7623: " Ryder Lee
2019-01-18 3:24 ` [PATCH v1 5/5] dt-bindings: pwm: update bindings for MT7629 SoC Ryder Lee
2019-02-18 20:38 ` Rob Herring
2019-01-18 7:59 ` [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Uwe Kleine-König
2019-01-18 9:42 ` Ryder Lee [this message]
2019-01-18 9:53 ` Uwe Kleine-König
2019-01-18 10:01 ` Ryder Lee
2019-01-18 8:05 ` Uwe Kleine-König
2019-01-18 9:47 ` Ryder Lee
2019-01-18 8:43 ` Matthias Brugger
2019-01-19 2:54 ` Ryder Lee
2019-01-21 8:49 ` Uwe Kleine-König
2019-01-25 3:48 ` Ryder Lee
2019-01-25 3:52 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547804574.8124.6.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).