From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ryder Lee <ryder.lee@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
Sean Wang <sean.wang@kernel.org>,
Weijie Gao <weijie.gao@mediatek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/5] dt-bindings: pwm: add a property "mediatek,num-pwms"
Date: Fri, 18 Jan 2019 09:44:49 +0100 [thread overview]
Message-ID: <7d387d2a-74f0-c6c7-aa2d-cf9b87579682@gmail.com> (raw)
In-Reply-To: <7e1de17a43f2cde73aecd2773e2b3a5fdfd294f3.1547781007.git.ryder.lee@mediatek.com>
On 18/01/2019 04:24, Ryder Lee wrote:
> This adds a property "mediatek,num-pwms" in example so that we could
> set the number of PWM channels via device tree.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> Changes since v1: add a Reviewed-by tag.
> ---
> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> index 991728c..f9e2d1f 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> @@ -20,6 +20,7 @@ Required properties:
> - pinctrl-names: Must contain a "default" entry.
> - pinctrl-0: One property must exist for each entry in pinctrl-names.
> See pinctrl/pinctrl-bindings.txt for details of the property values.
> + - mediatek,num-pwms: the number of PWM channels.
>
> Example:
> pwm0: pwm@11006000 {
> @@ -37,4 +38,5 @@ Example:
> "pwm3", "pwm4", "pwm5";
> pinctrl-names = "default";
> pinctrl-0 = <&pwm0_pins>;
> + mediatek,num-pwms = <5>;
> };
>
Wasn't there a comment in the last version to use num-pwms instead of
mediatek,num-pwms?
Uwe I think you requested that.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-18 8:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 3:24 [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Ryder Lee
2019-01-18 3:24 ` [PATCH v1 2/5] dt-bindings: pwm: " Ryder Lee
2019-01-18 8:44 ` Matthias Brugger [this message]
2019-01-21 8:43 ` Uwe Kleine-König
2019-02-18 20:36 ` Rob Herring
2019-02-19 7:30 ` Uwe Kleine-König
2019-01-18 3:24 ` [PATCH v1 3/5] arm64: dts: mt7622: add a property "mediatek, num-pwms" for PWM Ryder Lee
2019-01-18 8:01 ` Uwe Kleine-König
2019-01-18 3:24 ` [PATCH v1 4/5] arm: dts: mt7623: " Ryder Lee
2019-01-18 3:24 ` [PATCH v1 5/5] dt-bindings: pwm: update bindings for MT7629 SoC Ryder Lee
2019-02-18 20:38 ` Rob Herring
2019-01-18 7:59 ` [PATCH v1 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Uwe Kleine-König
2019-01-18 9:42 ` Ryder Lee
2019-01-18 9:53 ` Uwe Kleine-König
2019-01-18 10:01 ` Ryder Lee
2019-01-18 8:05 ` Uwe Kleine-König
2019-01-18 9:47 ` Ryder Lee
2019-01-18 8:43 ` Matthias Brugger
2019-01-19 2:54 ` Ryder Lee
2019-01-21 8:49 ` Uwe Kleine-König
2019-01-25 3:48 ` Ryder Lee
2019-01-25 3:52 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d387d2a-74f0-c6c7-aa2d-cf9b87579682@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).