* [PATCH] usb: dwc3: exynos: Fix error handling of clk_prepare_enable @ 2019-01-18 21:17 ` Alexey Khoroshilov 2019-01-21 9:56 ` Marek Szyprowski 0 siblings, 1 reply; 2+ messages in thread From: Alexey Khoroshilov @ 2019-01-18 21:17 UTC (permalink / raw) To: Marek Szyprowski, Felipe Balbi Cc: ldv-project, linux-samsung-soc, linux-usb, linux-kernel, Krzysztof Kozlowski, Kukjin Kim, Alexey Khoroshilov, linux-arm-kernel If clk_prepare_enable() fails in dwc3_exynos_probe(), exynos->clks[0] is left undisabled because of usage preincrement in while condition. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants") --- drivers/usb/dwc3/dwc3-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index cb7fcd7c0ad8..e7f6cff27b9a 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c @@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev) for (i = 0; i < exynos->num_clks; i++) { ret = clk_prepare_enable(exynos->clks[i]); if (ret) { - while (--i > 0) + while (i-- > 0) clk_disable_unprepare(exynos->clks[i]); return ret; } -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: exynos: Fix error handling of clk_prepare_enable 2019-01-18 21:17 ` [PATCH] usb: dwc3: exynos: Fix error handling of clk_prepare_enable Alexey Khoroshilov @ 2019-01-21 9:56 ` Marek Szyprowski 0 siblings, 0 replies; 2+ messages in thread From: Marek Szyprowski @ 2019-01-21 9:56 UTC (permalink / raw) To: Alexey Khoroshilov, Felipe Balbi Cc: ldv-project, linux-samsung-soc, linux-usb, linux-kernel, Krzysztof Kozlowski, Kukjin Kim, linux-arm-kernel Hi Alexey, On 2019-01-18 22:17, Alexey Khoroshilov wrote: > If clk_prepare_enable() fails in dwc3_exynos_probe(), > exynos->clks[0] is left undisabled because of usage > preincrement in while condition. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants") My fault. There is also a similar issue dwc3_exynos_resume(), so please fix it too if possible. > --- > drivers/usb/dwc3/dwc3-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index cb7fcd7c0ad8..e7f6cff27b9a 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > for (i = 0; i < exynos->num_clks; i++) { > ret = clk_prepare_enable(exynos->clks[i]); > if (ret) { > - while (--i > 0) > + while (i-- > 0) > clk_disable_unprepare(exynos->clks[i]); > return ret; > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-21 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190118211823epcas1p32d11bff9f7822eb48c0387c85a94da70@epcas1p3.samsung.com>
2019-01-18 21:17 ` [PATCH] usb: dwc3: exynos: Fix error handling of clk_prepare_enable Alexey Khoroshilov
2019-01-21 9:56 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).