* [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages
@ 2019-03-29 15:49 Yannick Fertré
2019-04-01 9:20 ` Philippe CORNU
0 siblings, 1 reply; 3+ messages in thread
From: Yannick Fertré @ 2019-03-29 15:49 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
From: Philippe Cornu <philippe.cornu@st.com>
Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
inform the user in case of fifo underruns or
transfer errors.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index b1741a9..15d8a02 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
mutex_lock(&ldev->err_lock);
if (ldev->error_status & ISR_FUIF) {
- DRM_DEBUG_DRIVER("Fifo underrun\n");
+ DRM_WARN("ltdc fifo underrun: please verify display mode\n");
ldev->error_status &= ~ISR_FUIF;
}
if (ldev->error_status & ISR_TERRIF) {
- DRM_DEBUG_DRIVER("Transfer error\n");
+ DRM_WARN("ltdc transfer error\n");
ldev->error_status &= ~ISR_TERRIF;
}
mutex_unlock(&ldev->err_lock);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages
2019-03-29 15:49 [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages Yannick Fertré
@ 2019-04-01 9:20 ` Philippe CORNU
2019-04-24 12:26 ` Benjamin Gaignard
0 siblings, 1 reply; 3+ messages in thread
From: Philippe CORNU @ 2019-04-01 9:20 UTC (permalink / raw)
To: Yannick FERTRE, Vincent ABRIOU, David Airlie, Daniel Vetter,
Maxime Coquelin, Alexandre TORGUE, dri-devel, linux-stm32,
linux-arm-kernel, linux-kernel
Dear Yannick,
Fully agree with this approach,
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 3/29/19 4:49 PM, Yannick Fertré wrote:
> From: Philippe Cornu <philippe.cornu@st.com>
>
> Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> inform the user in case of fifo underruns or
> transfer errors.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index b1741a9..15d8a02 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
>
> mutex_lock(&ldev->err_lock);
> if (ldev->error_status & ISR_FUIF) {
> - DRM_DEBUG_DRIVER("Fifo underrun\n");
> + DRM_WARN("ltdc fifo underrun: please verify display mode\n");
> ldev->error_status &= ~ISR_FUIF;
> }
> if (ldev->error_status & ISR_TERRIF) {
> - DRM_DEBUG_DRIVER("Transfer error\n");
> + DRM_WARN("ltdc transfer error\n");
> ldev->error_status &= ~ISR_TERRIF;
> }
> mutex_unlock(&ldev->err_lock);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages
2019-04-01 9:20 ` Philippe CORNU
@ 2019-04-24 12:26 ` Benjamin Gaignard
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2019-04-24 12:26 UTC (permalink / raw)
To: Philippe CORNU
Cc: Daniel Vetter, David Airlie, linux-kernel, dri-devel,
Yannick FERTRE, Maxime Coquelin, Vincent ABRIOU, linux-stm32,
linux-arm-kernel, Alexandre TORGUE
Le lun. 1 avr. 2019 à 11:20, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
> Dear Yannick,
> Fully agree with this approach,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
Applied on drm-misc-next,
Thanks,
Benjamin
> Philippe :-)
>
> On 3/29/19 4:49 PM, Yannick Fertré wrote:
> > From: Philippe Cornu <philippe.cornu@st.com>
> >
> > Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> > inform the user in case of fifo underruns or
> > transfer errors.
> >
> > Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..15d8a02 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
> >
> > mutex_lock(&ldev->err_lock);
> > if (ldev->error_status & ISR_FUIF) {
> > - DRM_DEBUG_DRIVER("Fifo underrun\n");
> > + DRM_WARN("ltdc fifo underrun: please verify display mode\n");
> > ldev->error_status &= ~ISR_FUIF;
> > }
> > if (ldev->error_status & ISR_TERRIF) {
> > - DRM_DEBUG_DRIVER("Transfer error\n");
> > + DRM_WARN("ltdc transfer error\n");
> > ldev->error_status &= ~ISR_TERRIF;
> > }
> > mutex_unlock(&ldev->err_lock);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-24 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 15:49 [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages Yannick Fertré
2019-04-01 9:20 ` Philippe CORNU
2019-04-24 12:26 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).