From: Stu Hsieh <stu.hsieh@mediatek.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>, CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Stu Hsieh <stu.hsieh@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v3 04/13] [media] mtk-mipicsi: add the check for non-supported color format
Date: Tue, 14 May 2019 14:13:41 +0800 [thread overview]
Message-ID: <1557814430-9675-5-git-send-email-stu.hsieh@mediatek.com> (raw)
In-Reply-To: <1557814430-9675-1-git-send-email-stu.hsieh@mediatek.com>
This patch add the check for non-supported color format
Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
---
.../media/platform/mtk-mipicsi/mtk_mipicsi.c | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
index 9142564baf1d..9c65b96456c4 100644
--- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
+++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
@@ -172,6 +172,20 @@ static void mtk_mipicsi_remove_device(struct soc_camera_device *icd)
(void)pm_runtime_put_sync(icd->parent);
}
+static bool is_supported(const u32 pixformat)
+{
+ switch (pixformat) {
+ /* YUV422 */
+ case V4L2_PIX_FMT_YUYV:
+ case V4L2_PIX_FMT_UYVY:
+ case V4L2_PIX_FMT_YVYU:
+ case V4L2_PIX_FMT_VYUY:
+ return true;
+ }
+
+ return false;
+}
+
static int mtk_mipicsi_set_fmt(struct soc_camera_device *icd,
struct v4l2_format *f)
{
@@ -187,6 +201,12 @@ static int mtk_mipicsi_set_fmt(struct soc_camera_device *icd,
struct v4l2_mbus_framefmt *mf = &format.format;
int ret = 0;
+ if (!is_supported(pix->pixelformat)) {
+ dev_err(dev, "Format %x not support. set V4L2_PIX_FMT_YUYV as default\n",
+ pix->pixelformat);
+ pix->pixelformat = V4L2_PIX_FMT_YUYV;
+ }
+
xlate = soc_camera_xlate_by_fourcc(icd, pix->pixelformat);
if (xlate == NULL) {
dev_err(dev, "Format 0x%x not found\n", pix->pixelformat);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-14 6:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 6:13 [PATCH v3 00/13] Add mediatek mipicsi driver for Mediatek SOC MT2712 Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 01/13] dt-bindings: media: Add binding for MT2712 MIPI-CSI2 Stu Hsieh
2019-05-14 19:28 ` Rob Herring
2019-05-14 6:13 ` [PATCH v3 02/13] [media] mtk-mipicsi: add mediatek mipicsi driver for mt2712 Stu Hsieh
2019-05-17 7:37 ` CK Hu
2019-05-14 6:13 ` [PATCH v3 03/13] [media] mtk-mipicsi: register the soc_camera host Stu Hsieh
2019-05-14 6:13 ` Stu Hsieh [this message]
2019-05-14 6:13 ` [PATCH v3 05/13] [media] mtk-mipicsi: get the w/h/bytepwerline for mtk_mipicsi Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 06/13] [media] mtk-mipicsi: add function to support SerDes for link number Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 07/13] [media] mtk-mipicsi: enable/disable ana clk Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 08/13] [media] mtk-mipicsi: enable/disable cmos for mt2712 Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 09/13] [media] mtk-mipicsi: add ISR for writing the data to buffer Stu Hsieh
2019-05-17 9:05 ` CK Hu
2019-05-14 6:13 ` [PATCH v3 10/13] [media] mtk-mipicsi: set the output address in HW reg Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 11/13] [media] mtk-mipicsi: add function to get the format Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 12/13] [media] mtk-mipicsi: add debug message for mipicsi driver Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 13/13] [media] mtk-mipicsi: add debugfs " Stu Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557814430-9675-5-git-send-email-stu.hsieh@mediatek.com \
--to=stu.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).