From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Biju Das <biju.das@bp.renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Biju Das <biju.das@bp.renesas.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Min Guo <min.guo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node
Date: Mon, 27 May 2019 11:08:35 +0800 [thread overview]
Message-ID: <1558926515.10179.439.camel@mhfsdcap03> (raw)
In-Reply-To: <20190524124445.GP1887@kuha.fi.intel.com>
Hi Heikki & Biju,
On Fri, 2019-05-24 at 15:44 +0300, Heikki Krogerus wrote:
> On Wed, May 22, 2019 at 02:57:33PM +0000, Biju Das wrote:
> > Hi Heikki,
> >
> > Thanks for the patch
> >
> > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by
> > > node
> > >
> > > On Wed, May 22, 2019 at 10:55:17AM +0000, Biju Das wrote:
> > > > Hi Chunfeng Yun,
> > > >
> > > > Thanks for the feedback.
> > > >
> > > > > Subject: RE: [PATCH v5 4/6] usb: roles: add API to get
> > > > > usb_role_switch by node
> > > > >
> > > > > Hi Biju,
> > > > > On Wed, 2019-05-22 at 08:05 +0000, Biju Das wrote:
> > > > > > Hi Heikki,
> > > > > >
> > > > > > Thanks for the feedback.
> > > > > >
> > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get
> > > > > > > usb_role_switch by node
> > > > > > >
> > > > > > > On Mon, May 20, 2019 at 09:45:46AM +0000, Biju Das wrote:
> > > > > > > >
> > > > > > > >
> > > > > > > > Hi Heikki,
> > > > > > > >
> > > > > > > > Thanks for the feedback.
> > > > > > > >
> > > > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get
> > > > > > > > > usb_role_switch by node
> > > > > > > > >
> > > > > > > > > On Mon, May 20, 2019 at 08:06:41AM +0000, Biju Das wrote:
> > > > > > > > > > Hi Heikki,
> > > > > > > > > >
> > > > > > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get
> > > > > > > > > > > usb_role_switch by node
> > > > > > > > > > >
> > > > > > > > > > > On Mon, May 20, 2019 at 10:39:11AM +0800, Chunfeng Yun
> > > wrote:
> > > > > > > > > > > > Hi,
> > > > > > > > > > > > On Fri, 2019-05-17 at 16:05 +0300, Heikki Krogerus wrote:
> > > > > > > > > > > > > Hi,
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Fri, May 17, 2019 at 01:37:36PM +0300, Heikki
> > > > > > > > > > > > > Krogerus
> > > > > wrote:
> > > > > > > > > > > > > > On Tue, May 14, 2019 at 04:47:21PM +0800, Chunfeng
> > > > > > > > > > > > > > Yun
> > > > > > > wrote:
> > > > > > > > > > > > > > > Add fwnode_usb_role_switch_get() to make easier
> > > > > > > > > > > > > > > to get usb_role_switch by fwnode which register it.
> > > > > > > > > > > > > > > It's useful when there is not device_connection
> > > > > > > > > > > > > > > registered between two drivers and only knows
> > > > > > > > > > > > > > > the fwnode which register usb_role_switch.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Signed-off-by: Chunfeng Yun
> > > > > > > > > > > > > > > <chunfeng.yun@mediatek.com>
> > > > > > > > > > > > > > > Tested-by: Biju Das <biju.das@bp.renesas.com>
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Acked-by: Heikki Krogerus
> > > > > > > > > > > > > > <heikki.krogerus@linux.intel.com>
> > > > > > > > > > > > >
> > > > > > > > > > > > > Hold on. I just noticed Rob's comment on patch 2/6,
> > > > > > > > > > > > > where he points out that you don't need to use
> > > > > > > > > > > > > device graph since the controller is the parent of
> > > > > > > > > > > > > the connector. Doesn't that mean you don't really need
> > > this API?
> > > > > > > > > > > > No, I still need it.
> > > > > > > > > > > > The change is about the way how to get fwnode; when
> > > > > > > > > > > > use device graph, get fwnode by
> > > > > > > > > > > > of_graph_get_remote_node(); but now will get fwnode by
> > > > > > > > > > > > of_get_parent();
> > > > > > > > > > >
> > > > > > > > > > > OK, I get that, but I'm still not convinced about if
> > > > > > > > > > > something like this function is needed at all. I also
> > > > > > > > > > > have concerns regarding how you are using the function.
> > > > > > > > > > > I'll explain in comment to the patch 5/6 in this
> > > > > > > > > series...
> > > > > > > > > >
> > > > > > > > > > FYI, Currently I am also using this api in my patch series.
> > > > > > > > > > https://patchwork.kernel.org/patch/10944637/
> > > > > > > > >
> > > > > > > > > Yes, and I have the same question for you I jusb asked in
> > > > > > > > > comment I added to the patch 5/6 of this series. Why isn't
> > > > > > > > > usb_role_switch_get()
> > > > > > > enough?
> > > > > > > >
> > > > > > > > Currently no issue. It will work with this api as well, since
> > > > > > > > the port node is
> > > > > > > part of controller node.
> > > > > > > > For eg:-
> > > > > > > > https://patchwork.kernel.org/patch/10944627/
> > > > > > > >
> > > > > > > > However if any one adds port node inside the connector node,
> > > > > > > > then this
> > > > > > > api may won't work as expected.
> > > > > > > > Currently I get below error
> > > > > > > >
> > > > > > > > [ 2.299703] OF: graph: no port node found in
> > > > > > > /soc/i2c@e6500000/hd3ss3220@47
> > > > > > >
> > > > > > > We need to understand why is that happening?
> > > > > > >
> > > > > >
> > > > > > Form the stack trace the parent node is
> > > > > > "parent_node=hd3ss3220@47" ,
> > > > > instead of the "connector" node.
> > > > > > That is the reason for the above error.
> > > > > >
> > > > > > [ 2.442429] of_graph_get_next_endpoint.part.0+0x28/0x168
> > > > > > [ 2.447889] of_fwnode_graph_get_next_endpoint+0x5c/0xb0
> > > > > > [ 2.453267] fwnode_graph_get_next_endpoint+0x20/0x30
> > > > > > [ 2.458374] device_connection_find_match+0x74/0x1a0
> > > > > > [ 2.463399] usb_role_switch_get+0x20/0x28
> > > > > > [ 2.467542] hd3ss3220_probe+0xc4/0x218
> > > > > >
> > > > > > The use case is
> > > > > >
> > > > > > &i2c0 {
> > > > > > hd3ss3220@47 {
> > > > > > compatible = "ti,hd3ss3220";
> > > > > >
> > > > > > usb_con: connector {
> > > > > > compatible = "usb-c-connector";
> > > > > > port {
> > > > > > hd3ss3220_ep: endpoint {
> > > > > > remote-endpoint =
> > > > > <&usb3_role_switch>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > &usb3_peri0 {
> > > > > > companion = <&xhci0>;
> > > > > > usb-role-switch;
> > > > > >
> > > > > > port {
> > > > > > usb3_role_switch: endpoint {
> > > > > > remote-endpoint = <&hd3ss3220_ep>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > Q1) How do we modify the usb_role_switch_get() function to search
> > > > > > Child(connector) and child's endpoint?
> > > > > How about firstly finding connector node in
> > > > > fwnode_graph_devcon_match(), then search each endpoint?
> > > >
> > > > I have done a quick prototyping with the changes you suggested and it
> > > works.
> > > >
> > > > - struct fwnode_handle *ep;
> > > > + struct fwnode_handle *ep,*child,*tmp = fwnode;
> > > >
> > > > - fwnode_graph_for_each_endpoint(fwnode, ep) {
> > > > + child = fwnode_get_named_child_node(fwnode, "connector");
> > > > + if (child)
> > > > + tmp = child;
> > > > +
> > > > + fwnode_graph_for_each_endpoint(tmp, ep) {
> > > >
> > > > Form the stack trace the parent node is "parent_node= connector" .
> > > >
> > > > [ 2.440922] of_graph_get_next_endpoint.part.0+0x28/0x168
> > > > [ 2.446381] of_fwnode_graph_get_next_endpoint+0x5c/0xb0
> > > > [ 2.451758] fwnode_graph_get_next_endpoint+0x20/0x30
> > > > [ 2.456866] device_connection_find_match+0x84/0x1c0
> > > > [ 2.461888] usb_role_switch_get+0x20/0x28
> > > >
> > > > Heikki,
> > > > Are you ok with the above changes?
> > >
> > > Doesn't that mean that if we made fwnode_usb_role_switch_get() the way I
> > > proposed, there is no problem? You just find the "connector" child node in
> > > your driver, and pass that to fwnode_usb_role_switch_get():
> >
> > Yes, That is correct.
> >
> > > struct fwnode_handle *connector;
> > > ...
> > > connector = device_get_named_child_node(&client->dev, "connector");
> > > if (IS_ERR(connector))
> > > <do something>
> > >
> > > hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
> > > ...
> > >
> > > The difference is that instead of just converting a device node of an usb role
> > > switch to the usb role switch, it works just like usb_role_switch_get(), just
> > > taking fwnode instead of device entry as parameter.
> > >
> > > I prepared the patches implementing fwnode_usb_role_switch_get() the
> > > way I though it needs to work for my own tests. Please find the patches
> > > attached.
> >
> > I have tested this patches and conform it works.
> > Do you plan to post this patches to ML?
>
> Could make them part of this series?
I'll do it, thanks
>
>
> thanks,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-27 3:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 8:47 [v5 PATCH 0/6] add USB Type-B GPIO connector driver Chunfeng Yun
2019-05-14 8:47 ` [PATCH v5 1/6] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-05-14 8:47 ` [PATCH v5 2/6] dt-bindings: usb: add binding for Type-B GPIO connector driver Chunfeng Yun
2019-05-14 18:12 ` Rob Herring
2019-05-15 9:36 ` Chunfeng Yun
2019-05-14 8:47 ` [PATCH v5 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-05-14 18:17 ` Rob Herring
2019-05-14 8:47 ` [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node Chunfeng Yun
2019-05-17 10:37 ` Heikki Krogerus
2019-05-17 13:05 ` Heikki Krogerus
2019-05-20 2:39 ` Chunfeng Yun
2019-05-20 8:03 ` Heikki Krogerus
2019-05-20 8:06 ` Biju Das
2019-05-20 8:36 ` Heikki Krogerus
2019-05-20 9:45 ` Biju Das
2019-05-21 7:35 ` Chunfeng Yun
2019-05-21 10:33 ` Heikki Krogerus
2019-05-22 3:37 ` Chunfeng Yun
2019-05-21 9:58 ` Heikki Krogerus
2019-05-22 8:05 ` Biju Das
2019-05-22 9:30 ` Chunfeng Yun
2019-05-22 10:55 ` Biju Das
2019-05-22 14:26 ` Heikki Krogerus
2019-05-22 14:57 ` Biju Das
2019-05-24 12:44 ` Heikki Krogerus
2019-05-27 3:08 ` Chunfeng Yun [this message]
2019-05-28 6:52 ` Biju Das
2019-05-28 9:23 ` Chunfeng Yun
2019-05-23 10:16 ` Chunfeng Yun
2019-05-24 11:40 ` Heikki Krogerus
2019-05-27 3:07 ` Chunfeng Yun
2019-05-27 10:45 ` Heikki Krogerus
2019-05-14 8:47 ` [PATCH v5 5/6] usb: roles: add USB Type-B GPIO connector driver Chunfeng Yun
2019-05-20 8:31 ` Heikki Krogerus
2019-05-21 7:44 ` Chunfeng Yun
2019-05-14 8:47 ` [PATCH v5 6/6] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558926515.10179.439.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).