* [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node
@ 2019-06-09 4:19 Andy Gross
2019-06-10 8:17 ` Niklas Cassel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Gross @ 2019-06-09 4:19 UTC (permalink / raw)
To: linux-arm-msm; +Cc: arm, Andy Gross, linux-arm-kernel, Bjorn Andersson
This patch adds a reset-cells property to the gcc controller on the QCS404.
Without this in place, we get warnings like the following if nodes reference
a gcc reset:
arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
/soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
/soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb
arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
/soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
/soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
Signed-off-by: Andy Gross <agross@kernel.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 342788a..086cadb 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -426,6 +426,7 @@
compatible = "qcom,gcc-qcs404";
reg = <0x01800000 0x80000>;
#clock-cells = <1>;
+ #reset-cells = <1>;
assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>;
assigned-clock-rates = <19200000>;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node
2019-06-09 4:19 [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node Andy Gross
@ 2019-06-10 8:17 ` Niklas Cassel
2019-06-10 15:58 ` Vinod Koul
2019-06-19 13:17 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Niklas Cassel @ 2019-06-10 8:17 UTC (permalink / raw)
To: Andy Gross; +Cc: linux-arm-msm, arm, linux-arm-kernel, Bjorn Andersson
On Sat, Jun 08, 2019 at 11:19:32PM -0500, Andy Gross wrote:
> This patch adds a reset-cells property to the gcc controller on the QCS404.
> Without this in place, we get warnings like the following if nodes reference
> a gcc reset:
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
> DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
>
> Signed-off-by: Andy Gross <agross@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 342788a..086cadb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -426,6 +426,7 @@
> compatible = "qcom,gcc-qcs404";
> reg = <0x01800000 0x80000>;
> #clock-cells = <1>;
> + #reset-cells = <1>;
>
> assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>;
> assigned-clock-rates = <19200000>;
> --
> 2.7.4
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node
2019-06-09 4:19 [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node Andy Gross
2019-06-10 8:17 ` Niklas Cassel
@ 2019-06-10 15:58 ` Vinod Koul
2019-06-19 13:17 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2019-06-10 15:58 UTC (permalink / raw)
To: Andy Gross; +Cc: linux-arm-msm, arm, linux-arm-kernel, Bjorn Andersson
On 08-06-19, 23:19, Andy Gross wrote:
> This patch adds a reset-cells property to the gcc controller on the QCS404.
> Without this in place, we get warnings like the following if nodes reference
> a gcc reset:
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
> DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node
2019-06-09 4:19 [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node Andy Gross
2019-06-10 8:17 ` Niklas Cassel
2019-06-10 15:58 ` Vinod Koul
@ 2019-06-19 13:17 ` Olof Johansson
2 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2019-06-19 13:17 UTC (permalink / raw)
To: Andy Gross; +Cc: linux-arm-msm, arm, linux-arm-kernel, Bjorn Andersson
On Sat, Jun 08, 2019 at 11:19:32PM -0500, Andy Gross wrote:
> This patch adds a reset-cells property to the gcc controller on the QCS404.
> Without this in place, we get warnings like the following if nodes reference
> a gcc reset:
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
> DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
>
> Signed-off-by: Andy Gross <agross@kernel.org>
Applied to arm/dt. Thanks!
-Olof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-19 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-09 4:19 [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node Andy Gross
2019-06-10 8:17 ` Niklas Cassel
2019-06-10 15:58 ` Vinod Koul
2019-06-19 13:17 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).