* [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on
@ 2019-05-28 8:06 Leonard Crestez
2019-05-28 11:35 ` Fabio Estevam
2019-06-25 16:22 ` Lucas Stach
0 siblings, 2 replies; 4+ messages in thread
From: Leonard Crestez @ 2019-05-28 8:06 UTC (permalink / raw)
To: Lucas Stach, Lorenzo Pieralisi
Cc: Aisheng Dong, Richard Zhu, Andrey Smirnov, Stefan Agner,
dl-linux-imx, kernel, Fabio Estevam, Shawn Guo, linux-arm-kernel,
Trent Piepho
This driver can be used on imx6sx without enabling support for
imx6q or imx7d but the "depends on" condition doesn't allow that.
Instead of making the condition even longer just drop the per-soc
defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead,
similar to many other drivers.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/pci/controller/dwc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Link to v1: https://patchwork.kernel.org/patch/10848143/
No objections were raised other than a request for Lucas to Ack the
patch.
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 6ea74b1c0d94..21747fd0e799 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -88,11 +88,11 @@ config PCI_EXYNOS
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST
config PCI_IMX6
bool "Freescale i.MX6/7/8 PCIe controller"
- depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
+ depends on ARCH_MXC || COMPILE_TEST
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST
config PCIE_SPEAR13XX
bool "STMicroelectronics SPEAr PCIe controller"
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on
2019-05-28 8:06 [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on Leonard Crestez
@ 2019-05-28 11:35 ` Fabio Estevam
2019-06-25 16:13 ` Fabio Estevam
2019-06-25 16:22 ` Lucas Stach
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2019-05-28 11:35 UTC (permalink / raw)
To: Leonard Crestez
Cc: Aisheng Dong, Lorenzo Pieralisi, Richard Zhu, Andrey Smirnov,
Stefan Agner, dl-linux-imx, kernel, Fabio Estevam, Trent Piepho,
Shawn Guo, linux-arm-kernel, Lucas Stach
On Tue, May 28, 2019 at 5:06 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> This driver can be used on imx6sx without enabling support for
> imx6q or imx7d but the "depends on" condition doesn't allow that.
>
> Instead of making the condition even longer just drop the per-soc
> defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead,
> similar to many other drivers.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Tested-by: Fabio Estevam <festevam@gmail.com>
I have also noticed this issue and sent the same fix as I haven't seen
this patch earlier.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on
2019-05-28 11:35 ` Fabio Estevam
@ 2019-06-25 16:13 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-06-25 16:13 UTC (permalink / raw)
To: Leonard Crestez
Cc: Aisheng Dong, Lorenzo Pieralisi, Richard Zhu, Andrey Smirnov,
Stefan Agner, dl-linux-imx, kernel, Fabio Estevam, Trent Piepho,
Shawn Guo, linux-arm-kernel, Lucas Stach
Hi Lucas,
On Tue, May 28, 2019 at 8:35 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Tue, May 28, 2019 at 5:06 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
> >
> > This driver can be used on imx6sx without enabling support for
> > imx6q or imx7d but the "depends on" condition doesn't allow that.
> >
> > Instead of making the condition even longer just drop the per-soc
> > defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead,
> > similar to many other drivers.
> >
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>
> Tested-by: Fabio Estevam <festevam@gmail.com>
>
> I have also noticed this issue and sent the same fix as I haven't seen
> this patch earlier.
A gentle ping.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on
2019-05-28 8:06 [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on Leonard Crestez
2019-05-28 11:35 ` Fabio Estevam
@ 2019-06-25 16:22 ` Lucas Stach
1 sibling, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2019-06-25 16:22 UTC (permalink / raw)
To: Leonard Crestez, Lorenzo Pieralisi
Cc: Aisheng Dong, Richard Zhu, Andrey Smirnov, Stefan Agner,
dl-linux-imx, kernel, Fabio Estevam, Shawn Guo, linux-arm-kernel,
Trent Piepho
Am Dienstag, den 28.05.2019, 08:06 +0000 schrieb Leonard Crestez:
> This driver can be used on imx6sx without enabling support for
> imx6q or imx7d but the "depends on" condition doesn't allow that.
>
> Instead of making the condition even longer just drop the per-soc
> defines and make it depend on "ARCH_MXC || COMPILE_TEST" instead,
> similar to many other drivers.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Urgh, sorry I thought I had done this long time ago:
Acked-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/controller/dwc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Link to v1: https://patchwork.kernel.org/patch/10848143/
>
> No objections were raised other than a request for Lucas to Ack the
> patch.
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 6ea74b1c0d94..21747fd0e799 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -88,11 +88,11 @@ config PCI_EXYNOS
> > depends on PCI_MSI_IRQ_DOMAIN
> > select PCIE_DW_HOST
>
> config PCI_IMX6
> > bool "Freescale i.MX6/7/8 PCIe controller"
> > - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
> > + depends on ARCH_MXC || COMPILE_TEST
> > depends on PCI_MSI_IRQ_DOMAIN
> > select PCIE_DW_HOST
>
> config PCIE_SPEAR13XX
> > bool "STMicroelectronics SPEAr PCIe controller"
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-25 16:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 8:06 [PATCH RESEND] PCI: Kconfig: Simplify PCI_IMX6 depends on Leonard Crestez
2019-05-28 11:35 ` Fabio Estevam
2019-06-25 16:13 ` Fabio Estevam
2019-06-25 16:22 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).