* [PATCH v2] serial: 8250-mtk: modify mtk uart power and clock management
@ 2019-07-18 12:58 Changqi Hu
0 siblings, 0 replies; only message in thread
From: Changqi Hu @ 2019-07-18 12:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Matthias Brugger
Cc: Peter Shih, Changqi Hu, Gustavo A. R. Silva, linux-kernel,
srv_heupstream, linux-mediatek, linux-serial, Yingjoe Chen,
Eddie Huang, linux-arm-kernel
modify mtk uart runtime interface, enable uart clock before register.
Signed-off-by: Changqi Hu <changqi.hu@mediatek.com>
---
drivers/tty/serial/8250/8250_mtk.c | 21 ++++++++-------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index b0113d1..a07c8ae 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -389,7 +389,7 @@ static int __maybe_unused mtk8250_runtime_suspend(struct device *dev)
struct mtk8250_data *data = dev_get_drvdata(dev);
struct uart_8250_port *up = serial8250_get_port(data->line);
- /*wait until UART in idle status*/
+ /* wait until UART in idle status */
while
(serial_in(up, MTK_UART_DEBUG0));
@@ -426,23 +426,15 @@ static int __maybe_unused mtk8250_runtime_resume(struct device *dev)
static void
mtk8250_do_pm(struct uart_port *port, unsigned int state, unsigned int old)
{
- struct uart_8250_port *up = up_to_u8250p(port);
-
- if (!state) {
- if (!(up->capabilities & UART_CAP_RPM))
- mtk8250_runtime_resume(port->dev);
- else
+ if (!state)
+ if (!mtk8250_runtime_resume(port->dev))
pm_runtime_get_sync(port->dev);
- }
serial8250_do_pm(port, state, old);
- if (state) {
- if (!(up->capabilities & UART_CAP_RPM))
+ if (state)
+ if (!pm_runtime_put_sync_suspend(port->dev))
mtk8250_runtime_suspend(port->dev);
- else
- pm_runtime_put_sync_suspend(port->dev);
- }
}
#ifdef CONFIG_SERIAL_8250_DMA
@@ -554,6 +546,9 @@ static int mtk8250_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, data);
pm_runtime_enable(&pdev->dev);
+ err = mtk8250_runtime_resume(&pdev->dev);
+ if (err)
+ return err;
data->line = serial8250_register_8250_port(&uart);
if (data->line < 0)
--
1.8.1.1.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-18 12:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 12:58 [PATCH v2] serial: 8250-mtk: modify mtk uart power and clock management Changqi Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).