* [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build
@ 2019-08-02 10:55 Guido Günther
2019-08-02 11:03 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Guido Günther @ 2019-08-02 10:55 UTC (permalink / raw)
To: Philipp Zabel, David Airlie, Daniel Vetter, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, linux-arm-kernel, linux-kernel
Since
commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
extra entry with a non existing config value (CONFIG_DRM_IMX_IPUV3).
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/gpu/drm/imx/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile
index ab6c83caceb7..21cdcc2faabc 100644
--- a/drivers/gpu/drm/imx/Makefile
+++ b/drivers/gpu/drm/imx/Makefile
@@ -8,5 +8,4 @@ obj-$(CONFIG_DRM_IMX_PARALLEL_DISPLAY) += parallel-display.o
obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
-obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crtc.o
obj-$(CONFIG_DRM_IMX_HDMI) += dw_hdmi-imx.o
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build
2019-08-02 10:55 [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build Guido Günther
@ 2019-08-02 11:03 ` Fabio Estevam
2019-08-02 12:03 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2019-08-02 11:03 UTC (permalink / raw)
To: Guido Günther
Cc: Philipp Zabel, David Airlie, Sascha Hauer, linux-kernel,
DRI mailing list, NXP Linux Team, Daniel Vetter, Shawn Guo,
Pengutronix Kernel Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Guido,
Good catch!
On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Since
>
> commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
>
> imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
imx-ipuv3-crtc.o.
Apart from that:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build
2019-08-02 11:03 ` Fabio Estevam
@ 2019-08-02 12:03 ` Philipp Zabel
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2019-08-02 12:03 UTC (permalink / raw)
To: Fabio Estevam, Guido Günther
Cc: Daniel Vetter, David Airlie, Sascha Hauer, linux-kernel,
DRI mailing list, NXP Linux Team, Pengutronix Kernel Team,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Guido, Fabio,
On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
>
> Good catch!
>
> On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@sigxcpu.org> wrote:
> >
> > Since
> >
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
> >
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
>
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
>
> Apart from that:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:
drm/imx: Drop unused imx-ipuv3-crtc.o build
Since
commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
the former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
there's no need to keep an extra entry with a non existing config value
(CONFIG_DRM_IMX_IPUV3).
Fixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
no action necessary if you agree, otherwise just send a v2 and I'll
replace it.
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-02 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 10:55 [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build Guido Günther
2019-08-02 11:03 ` Fabio Estevam
2019-08-02 12:03 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).