* [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support
@ 2019-09-19 9:46 Anson Huang
2019-09-19 9:46 ` [PATCH 2/2] arm64: dts: imx8mm-evk: Enable pca6416 on i2c3 bus Anson Huang
2019-10-07 12:23 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Anson Huang @ 2019-09-19 9:46 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
leonard.crestez, daniel.baluta, ping.bai, jun.li, devicetree,
linux-arm-kernel, linux-kernel
Cc: Linux-imx
Enable i2c3 for i.MX8MM EVK board.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index f7a15f3..7758c1c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -306,6 +306,13 @@
};
};
+&i2c3 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3>;
+ status = "okay";
+};
+
&iomuxc {
pinctrl-names = "default";
@@ -355,6 +362,13 @@
>;
};
+ pinctrl_i2c3: i2c3grp {
+ fsl,pins = <
+ MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
+ MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
+ >;
+ };
+
pinctrl_pmic: pmicirq {
fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: imx8mm-evk: Enable pca6416 on i2c3 bus
2019-09-19 9:46 [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Anson Huang
@ 2019-09-19 9:46 ` Anson Huang
2019-10-07 12:23 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Anson Huang @ 2019-09-19 9:46 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
leonard.crestez, daniel.baluta, ping.bai, jun.li, devicetree,
linux-arm-kernel, linux-kernel
Cc: Linux-imx
Enable pca6416 on i.MX8MM EVK board's i2c3 bus.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index 7758c1c..c3189f2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -311,6 +311,13 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";
+
+ pca6416: gpio@20 {
+ compatible = "ti,tca6416";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
};
&iomuxc {
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support
2019-09-19 9:46 [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Anson Huang
2019-09-19 9:46 ` [PATCH 2/2] arm64: dts: imx8mm-evk: Enable pca6416 on i2c3 bus Anson Huang
@ 2019-10-07 12:23 ` Shawn Guo
2019-10-08 1:28 ` Anson Huang
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-10-07 12:23 UTC (permalink / raw)
To: Anson Huang
Cc: mark.rutland, devicetree, ping.bai, daniel.baluta, s.hauer,
linux-kernel, robh+dt, Linux-imx, kernel, leonard.crestez,
festevam, linux-arm-kernel, jun.li
On Thu, Sep 19, 2019 at 05:46:47PM +0800, Anson Huang wrote:
> Enable i2c3 for i.MX8MM EVK board.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index f7a15f3..7758c1c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -306,6 +306,13 @@
> };
> };
>
> +&i2c3 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> + status = "okay";
> +};
> +
> &iomuxc {
The iomuxc node is being put at end of file because of its huge pinctrl
data. I2C devices should be placed in alphabetical sort though. Can
you please have a patch moving i2c1 and i2c2 to correct place first,
and then add i2c3?
Shawn
> pinctrl-names = "default";
>
> @@ -355,6 +362,13 @@
> >;
> };
>
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
> + >;
> + };
> +
> pinctrl_pmic: pmicirq {
> fsl,pins = <
> MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support
2019-10-07 12:23 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Shawn Guo
@ 2019-10-08 1:28 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2019-10-08 1:28 UTC (permalink / raw)
To: Shawn Guo
Cc: mark.rutland, devicetree, Jacky Bai, Daniel Baluta, s.hauer,
linux-kernel, robh+dt, dl-linux-imx, kernel, Leonard Crestez,
festevam, linux-arm-kernel, Jun Li
Hi, Shawn
> On Thu, Sep 19, 2019 at 05:46:47PM +0800, Anson Huang wrote:
> > Enable i2c3 for i.MX8MM EVK board.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index f7a15f3..7758c1c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -306,6 +306,13 @@
> > };
> > };
> >
> > +&i2c3 {
> > + clock-frequency = <400000>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_i2c3>;
> > + status = "okay";
> > +};
> > +
> > &iomuxc {
>
> The iomuxc node is being put at end of file because of its huge pinctrl data.
> I2C devices should be placed in alphabetical sort though. Can you please
> have a patch moving i2c1 and i2c2 to correct place first, and then add i2c3?
Done in V2.
Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-08 1:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 9:46 [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Anson Huang
2019-09-19 9:46 ` [PATCH 2/2] arm64: dts: imx8mm-evk: Enable pca6416 on i2c3 bus Anson Huang
2019-10-07 12:23 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Shawn Guo
2019-10-08 1:28 ` Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).