From: Stefan Wahren <wahrenst@gmx.net>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
linux-bluetooth@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <wahrenst@gmx.net>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 01/10] bluetooth: hci_bcm: Fix RTS handling during startup
Date: Sun, 6 Oct 2019 17:28:19 +0200 [thread overview]
Message-ID: <1570375708-26965-2-git-send-email-wahrenst@gmx.net> (raw)
In-Reply-To: <1570375708-26965-1-git-send-email-wahrenst@gmx.net>
The RPi 4 uses the hardware handshake lines for CYW43455, but the chip
doesn't react to HCI requests during DT probe. The reason is the inproper
handling of the RTS line during startup. According to the startup
signaling sequence in the CYW43455 datasheet, the hosts RTS line must
be driven after BT_REG_ON and BT_HOST_WAKE.
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
drivers/bluetooth/hci_bcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 7646636..0f73f6a 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -445,9 +445,11 @@ static int bcm_open(struct hci_uart *hu)
out:
if (bcm->dev) {
+ hci_uart_set_flow_control(hu, true);
hu->init_speed = bcm->dev->init_speed;
hu->oper_speed = bcm->dev->oper_speed;
err = bcm_gpio_set_power(bcm->dev, true);
+ hci_uart_set_flow_control(hu, false);
if (err)
goto err_unset_hu;
}
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-06 15:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 15:28 [PATCH V4 00/10] ARM: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-10-06 15:28 ` Stefan Wahren [this message]
2019-10-20 21:17 ` [PATCH V4 01/10] bluetooth: hci_bcm: Fix RTS handling during startup Stefan Wahren
2019-12-16 13:25 ` Ondřej Jirman
2019-12-16 18:28 ` Stefan Wahren
2019-12-16 19:42 ` Ondřej Jirman
2019-12-16 19:56 ` Stefan Wahren
2019-12-17 12:59 ` Stefan Wahren
2019-12-17 13:41 ` Ondřej Jirman
2019-12-19 19:54 ` Marcel Holtmann
2019-10-21 15:05 ` Marcel Holtmann
2019-10-06 15:28 ` [PATCH V4 02/10] ARM: dts: bcm283x: Remove simple-bus from fixed clocks Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 03/10] ARM: dts: bcm283x: Remove brcm, bcm2835-pl011 compatible Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 04/10] ARM: dts: bcm283x: Move BCM2835/6/7 specific to bcm2835-common.dtsi Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 05/10] dt-bindings: arm: Convert BCM2835 board/soc bindings to json-schema Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 06/10] dt-bindings: arm: bcm2835: Add Raspberry Pi 4 to DT schema Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 07/10] ARM: bcm: Add support for BCM2711 SoC Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 08/10] ARM: dts: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 09/10] arm64: dts: broadcom: Add reference to RPi 4 B Stefan Wahren
2019-10-06 15:28 ` [PATCH V4 10/10] MAINTAINERS: Add BCM2711 to BCM2835 ARCH Stefan Wahren
2019-10-07 10:07 ` [PATCH V4 00/10] ARM: Add minimal Raspberry Pi 4 support Matthias Brugger
2019-10-11 14:46 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570375708-26965-2-git-send-email-wahrenst@gmx.net \
--to=wahrenst@gmx.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).