From: Walter Wu <walter-zh.wu@mediatek.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Qian Cai <cai@lca.pw>, wsd_upstream <wsd_upstream@mediatek.com>,
linux-mediatek@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
Alexander Potapenko <glider@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y
Date: Mon, 14 Oct 2019 10:19:42 +0800 [thread overview]
Message-ID: <1571019582.26230.8.camel@mtksdccf07> (raw)
In-Reply-To: <CACT4Y+Zbx-2yR-mN5GioaKUgGH1TpTE2D-OgLbR2Dy09ezyGGQ@mail.gmail.com>
On Tue, 2019-10-08 at 14:11 +0200, Dmitry Vyukov wrote:
> On Tue, Oct 8, 2019 at 1:42 PM Qian Cai <cai@lca.pw> wrote:
> > > On Oct 8, 2019, at 7:02 AM, Walter Wu <walter-zh.wu@mediatek.com> wrote:
> > > I don't know very well in UBSAN, but I try to build ubsan kernel and
> > > test a negative number in memset and kmalloc_memmove_invalid_size(), it
> > > look like no check.
> >
> > It sounds like more important to figure out why the UBSAN is not working in this case rather than duplicating functionality elsewhere.
>
> Detecting out-of-bounds accesses is the direct KASAN responsibility.
> Even more direct than for KUBSAN. We are not even adding
> functionality, it's just a plain bug in KASAN code, it tricks itself
> into thinking that access size is 0.
> Maybe it's already detected by KUBSAN too?
Thanks for your response.
I survey the KUBSAN, it don't check size is negative in
memset/memcpy/memmove, we try to verify our uni testing too, it don't
report the bug in KUBSAN, so it needs to report this bug by KASAN. The
reason is like what you said. so we still send the patch.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-14 2:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 3:43 [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y Walter Wu
2019-09-27 13:07 ` Dmitry Vyukov
2019-09-27 14:22 ` Walter Wu
2019-09-27 19:41 ` Dmitry Vyukov
2019-09-30 4:36 ` Walter Wu
2019-09-30 8:57 ` Marc Gonzalez
2019-10-01 2:36 ` Walter Wu
2019-10-01 3:01 ` Dmitry Vyukov
2019-10-01 3:18 ` Walter Wu
2019-10-02 12:15 ` Walter Wu
2019-10-02 13:57 ` Dmitry Vyukov
2019-10-03 2:17 ` Walter Wu
2019-10-03 6:26 ` Dmitry Vyukov
2019-10-03 9:38 ` Walter Wu
2019-10-03 13:51 ` Walter Wu
2019-10-03 14:53 ` Dmitry Vyukov
2019-10-04 4:42 ` Walter Wu
2019-10-04 8:02 ` Walter Wu
2019-10-04 9:18 ` Dmitry Vyukov
2019-10-04 9:44 ` Walter Wu
2019-10-04 9:54 ` Dmitry Vyukov
2019-10-04 12:05 ` Walter Wu
2019-10-04 13:52 ` Dmitry Vyukov
2019-10-07 3:22 ` Walter Wu
2019-10-07 7:29 ` Dmitry Vyukov
2019-10-07 8:18 ` Walter Wu
2019-10-07 8:24 ` Dmitry Vyukov
2019-10-07 8:51 ` Walter Wu
2019-10-07 8:54 ` Dmitry Vyukov
2019-10-07 9:03 ` Walter Wu
2019-10-07 9:10 ` Dmitry Vyukov
2019-10-07 9:28 ` Walter Wu
2019-10-07 9:50 ` Walter Wu
2019-10-07 10:51 ` Dmitry Vyukov
2019-10-07 12:03 ` Walter Wu
2019-10-07 12:19 ` Dmitry Vyukov
2019-10-07 12:32 ` Walter Wu
2019-10-07 13:33 ` Dmitry Vyukov
2019-10-08 6:15 ` Walter Wu
2019-10-08 9:47 ` Qian Cai
2019-10-08 11:02 ` Walter Wu
2019-10-08 11:42 ` Qian Cai
2019-10-08 12:07 ` Walter Wu
2019-10-08 12:11 ` Dmitry Vyukov
2019-10-14 2:19 ` Walter Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571019582.26230.8.camel@mtksdccf07 \
--to=walter-zh.wu@mediatek.com \
--cc=aryabinin@virtuozzo.com \
--cc=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).