linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nvmem: imx: scu: fix write SIP
@ 2019-12-03  2:32 Peng Fan
  2019-12-19 10:52 ` Srinivas Kandagatla
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan @ 2019-12-03  2:32 UTC (permalink / raw)
  To: srinivas.kandagatla, shawnguo, s.hauer
  Cc: Aisheng Dong, Peng Fan, Alice Guo, linux-kernel, dl-linux-imx,
	kernel, festevam, linux-arm-kernel

From: Peng Fan <peng.fan@nxp.com>

SIP number 0xC200000A is for reading, 0xC200000B is for writing.
And the following two args for write are word index, data to write.

Fixes: 885ce72a09d0 ("nvmem: imx: scu: support write")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/nvmem/imx-ocotp-scu.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
index 03f1ab23ad51..455675dd8efe 100644
--- a/drivers/nvmem/imx-ocotp-scu.c
+++ b/drivers/nvmem/imx-ocotp-scu.c
@@ -15,8 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
-#define IMX_SIP_OTP			0xC200000A
-#define IMX_SIP_OTP_WRITE		0x2
+#define IMX_SIP_OTP_WRITE		0xc200000B
 
 enum ocotp_devtype {
 	IMX8QXP,
@@ -212,8 +211,7 @@ static int imx_scu_ocotp_write(void *context, unsigned int offset,
 
 	mutex_lock(&scu_ocotp_mutex);
 
-	arm_smccc_smc(IMX_SIP_OTP, IMX_SIP_OTP_WRITE, index, *buf,
-		      0, 0, 0, 0, &res);
+	arm_smccc_smc(IMX_SIP_OTP_WRITE, index, *buf, 0, 0, 0, 0, 0, &res);
 
 	mutex_unlock(&scu_ocotp_mutex);
 
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] nvmem: imx: scu: fix write SIP
  2019-12-03  2:32 [PATCH] nvmem: imx: scu: fix write SIP Peng Fan
@ 2019-12-19 10:52 ` Srinivas Kandagatla
  0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2019-12-19 10:52 UTC (permalink / raw)
  To: Peng Fan, shawnguo, s.hauer
  Cc: Aisheng Dong, Alice Guo, linux-kernel, dl-linux-imx, kernel,
	festevam, linux-arm-kernel



On 03/12/2019 02:32, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> SIP number 0xC200000A is for reading, 0xC200000B is for writing.
> And the following two args for write are word index, data to write.
> 
> Fixes: 885ce72a09d0 ("nvmem: imx: scu: support write")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied Thanks,
srini

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-19 10:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03  2:32 [PATCH] nvmem: imx: scu: fix write SIP Peng Fan
2019-12-19 10:52 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).