* [PATCH] ARM:alignment:correct variable type of nr_regs
@ 2020-01-05 2:39 hanterliu
0 siblings, 0 replies; 3+ messages in thread
From: hanterliu @ 2020-01-05 2:39 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: hanter Liu, linux
From: hanter Liu <hanterliu@gmail.com>
if ldmstm instruction U bit is unset, nr_regs
should be negative value, so change variable
type of nr_regs from unsigned int to int.
Signed-off-by: hanter Liu <hanterliu@gmail.com>
---
arch/arm/mm/alignment.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
index 788c5cf..d8e3bd9 100644
--- a/arch/arm/mm/alignment.c
+++ b/arch/arm/mm/alignment.c
@@ -499,7 +499,8 @@ do_alignment_ldrstr(unsigned long addr, u32 instr, struct pt_regs *regs)
static int
do_alignment_ldmstm(unsigned long addr, u32 instr, struct pt_regs *regs)
{
- unsigned int rd, rn, correction, nr_regs, regbits;
+ int nr_regs;
+ unsigned int rd, rn, correction, regbits;
unsigned long eaddr, newaddr;
if (LDM_S_BIT(instr))
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM:alignment:correct variable type of nr_regs
2020-01-05 2:17 hanterliu
@ 2020-01-05 14:00 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2020-01-05 14:00 UTC (permalink / raw)
To: hanterliu; +Cc: hanter Liu, linux-arm-kernel
On Sun, Jan 05, 2020 at 10:17:36AM +0800, hanterliu@gmail.com wrote:
> From: hanter Liu <hanterliu@gamil.com>
>
> if ldmstm instruction U bit is unset, nr_regs
> should be negative value, so change variable
> type of nr_regs from unsigned int to int.
>
> Signed-off-by: hanter Liu <hanterliu@gamil.com>
Hi,
What observable bug is this fixing, or is this just a clean up? Please
clarify.
Thanks.
> ---
> arch/arm/mm/alignment.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
> index 788c5cf..d8e3bd9 100644
> --- a/arch/arm/mm/alignment.c
> +++ b/arch/arm/mm/alignment.c
> @@ -499,7 +499,8 @@ do_alignment_ldrstr(unsigned long addr, u32 instr, struct pt_regs *regs)
> static int
> do_alignment_ldmstm(unsigned long addr, u32 instr, struct pt_regs *regs)
> {
> - unsigned int rd, rn, correction, nr_regs, regbits;
> + int nr_regs;
> + unsigned int rd, rn, correction, regbits;
> unsigned long eaddr, newaddr;
>
> if (LDM_S_BIT(instr))
> --
> 2.7.4
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM:alignment:correct variable type of nr_regs
@ 2020-01-05 2:17 hanterliu
2020-01-05 14:00 ` Russell King - ARM Linux admin
0 siblings, 1 reply; 3+ messages in thread
From: hanterliu @ 2020-01-05 2:17 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: hanter Liu, linux
From: hanter Liu <hanterliu@gamil.com>
if ldmstm instruction U bit is unset, nr_regs
should be negative value, so change variable
type of nr_regs from unsigned int to int.
Signed-off-by: hanter Liu <hanterliu@gamil.com>
---
arch/arm/mm/alignment.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
index 788c5cf..d8e3bd9 100644
--- a/arch/arm/mm/alignment.c
+++ b/arch/arm/mm/alignment.c
@@ -499,7 +499,8 @@ do_alignment_ldrstr(unsigned long addr, u32 instr, struct pt_regs *regs)
static int
do_alignment_ldmstm(unsigned long addr, u32 instr, struct pt_regs *regs)
{
- unsigned int rd, rn, correction, nr_regs, regbits;
+ int nr_regs;
+ unsigned int rd, rn, correction, regbits;
unsigned long eaddr, newaddr;
if (LDM_S_BIT(instr))
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-05 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-05 2:39 [PATCH] ARM:alignment:correct variable type of nr_regs hanterliu
-- strict thread matches above, loose matches on Subject: below --
2020-01-05 2:17 hanterliu
2020-01-05 14:00 ` Russell King - ARM Linux admin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).