* [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states
@ 2020-01-14 10:11 James Liao
2020-01-14 11:14 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: James Liao @ 2020-01-14 10:11 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Matthias Brugger
Cc: devicetree, srv_heupstream, James Liao, linux-kernel,
linux-mediatek, linux-arm-kernel
Enable mcdi-cpu and mcdi-cluster on MT8183 CPUs.
Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
---
This patch bases on v5.5-rc6, adds idle-states for MT8183 CPUs.
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 10b3247..a022325 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -73,6 +73,7 @@
reg = <0x000>;
enable-method = "psci";
capacity-dmips-mhz = <741>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu1: cpu@1 {
@@ -81,6 +82,7 @@
reg = <0x001>;
enable-method = "psci";
capacity-dmips-mhz = <741>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu2: cpu@2 {
@@ -89,6 +91,7 @@
reg = <0x002>;
enable-method = "psci";
capacity-dmips-mhz = <741>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu3: cpu@3 {
@@ -97,6 +100,7 @@
reg = <0x003>;
enable-method = "psci";
capacity-dmips-mhz = <741>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu4: cpu@100 {
@@ -105,6 +109,7 @@
reg = <0x100>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu5: cpu@101 {
@@ -113,6 +118,7 @@
reg = <0x101>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu6: cpu@102 {
@@ -121,6 +127,7 @@
reg = <0x102>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
};
cpu7: cpu@103 {
@@ -129,6 +136,29 @@
reg = <0x103>;
enable-method = "psci";
capacity-dmips-mhz = <1024>;
+ cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
+ };
+
+ idle-states {
+ entry-method = "arm,psci";
+
+ MCDI_CPU: mcdi-cpu {
+ compatible = "arm,idle-state";
+ local-timer-stop;
+ arm,psci-suspend-param = <0x00010001>;
+ entry-latency-us = <200>;
+ exit-latency-us = <200>;
+ min-residency-us = <800>;
+ };
+
+ MCDI_CLUSTER: mcdi-cluster {
+ compatible = "arm,idle-state";
+ local-timer-stop;
+ arm,psci-suspend-param = <0x01010001>;
+ entry-latency-us = <250>;
+ exit-latency-us = <400>;
+ min-residency-us = <1300>;
+ };
};
};
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states
2020-01-14 10:11 [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states James Liao
@ 2020-01-14 11:14 ` Matthias Brugger
2020-01-15 5:32 ` James Liao
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Brugger @ 2020-01-14 11:14 UTC (permalink / raw)
To: James Liao, Rob Herring, Mark Rutland
Cc: linux-arm-kernel, devicetree, linux-mediatek, linux-kernel,
srv_heupstream
On 14/01/2020 11:11, James Liao wrote:
> Enable mcdi-cpu and mcdi-cluster on MT8183 CPUs.
>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
> This patch bases on v5.5-rc6, adds idle-states for MT8183 CPUs.
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 10b3247..a022325 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -73,6 +73,7 @@
> reg = <0x000>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu1: cpu@1 {
> @@ -81,6 +82,7 @@
> reg = <0x001>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu2: cpu@2 {
> @@ -89,6 +91,7 @@
> reg = <0x002>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu3: cpu@3 {
> @@ -97,6 +100,7 @@
> reg = <0x003>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu4: cpu@100 {
> @@ -105,6 +109,7 @@
> reg = <0x100>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu5: cpu@101 {
> @@ -113,6 +118,7 @@
> reg = <0x101>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu6: cpu@102 {
> @@ -121,6 +127,7 @@
> reg = <0x102>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu7: cpu@103 {
> @@ -129,6 +136,29 @@
> reg = <0x103>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> + };
> +
> + idle-states {
> + entry-method = "arm,psci";
reading idle-states.txt the entry-method should be "psci".
> +
> + MCDI_CPU: mcdi-cpu {
I wonder what MCDI stands for. Normally we have CPU_SLEEP and CLUSTER_SLEEP here.
Regards,
Matthias
> + compatible = "arm,idle-state";
> + local-timer-stop;
> + arm,psci-suspend-param = <0x00010001>;
> + entry-latency-us = <200>;
> + exit-latency-us = <200>;
> + min-residency-us = <800>;
> + };
> +
> + MCDI_CLUSTER: mcdi-cluster {
> + compatible = "arm,idle-state";
> + local-timer-stop;
> + arm,psci-suspend-param = <0x01010001>;
> + entry-latency-us = <250>;
> + exit-latency-us = <400>;
> + min-residency-us = <1300>;
> + };
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states
2020-01-14 11:14 ` Matthias Brugger
@ 2020-01-15 5:32 ` James Liao
0 siblings, 0 replies; 3+ messages in thread
From: James Liao @ 2020-01-15 5:32 UTC (permalink / raw)
To: Matthias Brugger
Cc: Mark Rutland, devicetree, srv_heupstream, linux-kernel,
Rob Herring, linux-mediatek, linux-arm-kernel
On Tue, 2020-01-14 at 12:14 +0100, Matthias Brugger wrote:
>
> > + idle-states {
> > + entry-method = "arm,psci";
>
> reading idle-states.txt the entry-method should be "psci".
It will be correct in next patch.
> > +
> > + MCDI_CPU: mcdi-cpu {
>
> I wonder what MCDI stands for. Normally we have CPU_SLEEP and CLUSTER_SLEEP here.
It means MCU Deep Idle. But you are right, CPU/CLUSTER_SLEEP is more
readable. So I'll change their name in next patch.
Best regards,
James
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-15 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 10:11 [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states James Liao
2020-01-14 11:14 ` Matthias Brugger
2020-01-15 5:32 ` James Liao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).