* [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
@ 2020-03-11 4:51 ` Joe Perches
2020-03-11 5:15 ` Masahiro Yamada
2020-03-11 4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
` (6 subsequent siblings)
7 siblings, 1 reply; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Greg Kroah-Hartman, linux-kernel, linux-arm-kernel, linux-serial,
Jiri Slaby
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/tty/serial/8250/8250_uniphier.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index e0b73a5..a2978ab 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
break;
case UART_LCR:
valshift = 8;
- /* fall through */
+ fallthrough;
case UART_MCR:
offset = UNIPHIER_UART_LCR_MCR;
break;
@@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
case UART_SCR:
/* No SCR for this hardware. Use CHAR as a scratch register */
valshift = 8;
- /* fall through */
+ fallthrough;
case UART_FCR:
offset = UNIPHIER_UART_CHAR_FCR;
break;
@@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
valshift = 8;
/* Divisor latch access bit does not exist. */
value &= ~UART_LCR_DLAB;
- /* fall through */
+ fallthrough;
case UART_MCR:
offset = UNIPHIER_UART_LCR_MCR;
break;
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
2020-03-12 10:11 ` Russell King - ARM Linux admin
2020-03-11 4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
` (5 subsequent siblings)
7 siblings, 1 reply; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Russell King
Cc: linux-scsi, James E.J. Bottomley, linux-arm-kernel,
Martin K. Petersen, linux-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm/mach-rpc/riscpc.c | 2 +-
drivers/scsi/arm/fas216.c | 17 ++++++-----------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-rpc/riscpc.c b/arch/arm/mach-rpc/riscpc.c
index ea2c842..d23970b 100644
--- a/arch/arm/mach-rpc/riscpc.c
+++ b/arch/arm/mach-rpc/riscpc.c
@@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag)
switch (tag->u.acorn.vram_pages) {
case 512:
vram_size += PAGE_SIZE * 256;
- /* Fall through - ??? */
+ fallthrough; /* ??? */
case 256:
vram_size += PAGE_SIZE * 256;
default:
diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
index 6c68c230..bb18be 100644
--- a/drivers/scsi/arm/fas216.c
+++ b/drivers/scsi/arm/fas216.c
@@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg)
msgqueue_flush(&info->scsi.msgs);
msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT);
info->scsi.phase = PHASE_MSGOUT_EXPECT;
- /* fall through */
-
+ fallthrough;
case async:
dev->period = info->ifcfg.asyncperiod / 4;
dev->sof = 0;
@@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info)
fas216_done(info, DID_ABORT);
break;
}
- /* else, fall through */
-
+ fallthrough;
default: /* huh? */
printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n",
info->host->host_no, fas216_target(info), fas216_drv_phase(info));
@@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out -> Status */
case STATE(STAT_STATUS, PHASE_DATAIN): /* Data In -> Status */
fas216_stoptransfer(info);
- /* fall through */
-
+ fallthrough;
case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status */
case STATE(STAT_STATUS, PHASE_MSGOUT): /* Message Out -> Status */
case STATE(STAT_STATUS, PHASE_COMMAND): /* Command -> Status */
@@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out -> Message In */
case STATE(STAT_MESGIN, PHASE_DATAIN): /* Data In -> Message In */
fas216_stoptransfer(info);
- /* fall through */
-
+ fallthrough;
case STATE(STAT_MESGIN, PHASE_COMMAND): /* Command -> Message In */
case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In */
case STATE(STAT_MESGIN, PHASE_MSGOUT): /* Message Out -> Message In */
@@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned
fas216_message(info);
break;
}
- /* else, fall through */
-
+ fallthrough;
default:
fas216_log(info, 0, "internal phase %s for function done?"
" What do I do with this?",
@@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info)
switch (where_from) {
case TYPE_QUEUE:
fas216_allocate_tag(info, SCpnt);
- /* fall through */
+ fallthrough;
case TYPE_OTHER:
fas216_start_command(info, SCpnt);
break;
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Joe Perches
2020-03-11 4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
` (4 subsequent siblings)
7 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Julien Thierry, Suzuki K Poulose
Cc: Catalin Marinas, Will Deacon, kvmarm, linux-arm-kernel, linux-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm64/kvm/handle_exit.c | 2 +-
arch/arm64/kvm/hyp/debug-sr.c | 60 +++++++++++++++++------------------
virt/kvm/arm/hyp/vgic-v3-sr.c | 16 +++++-----
3 files changed, 39 insertions(+), 39 deletions(-)
diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
index aacfc5..b14d6a 100644
--- a/arch/arm64/kvm/handle_exit.c
+++ b/arch/arm64/kvm/handle_exit.c
@@ -128,7 +128,7 @@ static int kvm_handle_guest_debug(struct kvm_vcpu *vcpu, struct kvm_run *run)
switch (ESR_ELx_EC(hsr)) {
case ESR_ELx_EC_WATCHPT_LOW:
run->debug.arch.far = vcpu->arch.fault.far_el2;
- /* fall through */
+ fallthrough;
case ESR_ELx_EC_SOFTSTP_LOW:
case ESR_ELx_EC_BREAKPT_LOW:
case ESR_ELx_EC_BKPT32:
diff --git a/arch/arm64/kvm/hyp/debug-sr.c b/arch/arm64/kvm/hyp/debug-sr.c
index 0fc987..b074d3 100644
--- a/arch/arm64/kvm/hyp/debug-sr.c
+++ b/arch/arm64/kvm/hyp/debug-sr.c
@@ -18,70 +18,70 @@
#define save_debug(ptr,reg,nr) \
switch (nr) { \
case 15: ptr[15] = read_debug(reg, 15); \
- /* Fall through */ \
+ fallthrough; \
case 14: ptr[14] = read_debug(reg, 14); \
- /* Fall through */ \
+ fallthrough; \
case 13: ptr[13] = read_debug(reg, 13); \
- /* Fall through */ \
+ fallthrough; \
case 12: ptr[12] = read_debug(reg, 12); \
- /* Fall through */ \
+ fallthrough; \
case 11: ptr[11] = read_debug(reg, 11); \
- /* Fall through */ \
+ fallthrough; \
case 10: ptr[10] = read_debug(reg, 10); \
- /* Fall through */ \
+ fallthrough; \
case 9: ptr[9] = read_debug(reg, 9); \
- /* Fall through */ \
+ fallthrough; \
case 8: ptr[8] = read_debug(reg, 8); \
- /* Fall through */ \
+ fallthrough; \
case 7: ptr[7] = read_debug(reg, 7); \
- /* Fall through */ \
+ fallthrough; \
case 6: ptr[6] = read_debug(reg, 6); \
- /* Fall through */ \
+ fallthrough; \
case 5: ptr[5] = read_debug(reg, 5); \
- /* Fall through */ \
+ fallthrough; \
case 4: ptr[4] = read_debug(reg, 4); \
- /* Fall through */ \
+ fallthrough; \
case 3: ptr[3] = read_debug(reg, 3); \
- /* Fall through */ \
+ fallthrough; \
case 2: ptr[2] = read_debug(reg, 2); \
- /* Fall through */ \
+ fallthrough; \
case 1: ptr[1] = read_debug(reg, 1); \
- /* Fall through */ \
+ fallthrough; \
default: ptr[0] = read_debug(reg, 0); \
}
#define restore_debug(ptr,reg,nr) \
switch (nr) { \
case 15: write_debug(ptr[15], reg, 15); \
- /* Fall through */ \
+ fallthrough; \
case 14: write_debug(ptr[14], reg, 14); \
- /* Fall through */ \
+ fallthrough; \
case 13: write_debug(ptr[13], reg, 13); \
- /* Fall through */ \
+ fallthrough; \
case 12: write_debug(ptr[12], reg, 12); \
- /* Fall through */ \
+ fallthrough; \
case 11: write_debug(ptr[11], reg, 11); \
- /* Fall through */ \
+ fallthrough; \
case 10: write_debug(ptr[10], reg, 10); \
- /* Fall through */ \
+ fallthrough; \
case 9: write_debug(ptr[9], reg, 9); \
- /* Fall through */ \
+ fallthrough; \
case 8: write_debug(ptr[8], reg, 8); \
- /* Fall through */ \
+ fallthrough; \
case 7: write_debug(ptr[7], reg, 7); \
- /* Fall through */ \
+ fallthrough; \
case 6: write_debug(ptr[6], reg, 6); \
- /* Fall through */ \
+ fallthrough; \
case 5: write_debug(ptr[5], reg, 5); \
- /* Fall through */ \
+ fallthrough; \
case 4: write_debug(ptr[4], reg, 4); \
- /* Fall through */ \
+ fallthrough; \
case 3: write_debug(ptr[3], reg, 3); \
- /* Fall through */ \
+ fallthrough; \
case 2: write_debug(ptr[2], reg, 2); \
- /* Fall through */ \
+ fallthrough; \
case 1: write_debug(ptr[1], reg, 1); \
- /* Fall through */ \
+ fallthrough; \
default: write_debug(ptr[0], reg, 0); \
}
diff --git a/virt/kvm/arm/hyp/vgic-v3-sr.c b/virt/kvm/arm/hyp/vgic-v3-sr.c
index ccf1fde..93331f2 100644
--- a/virt/kvm/arm/hyp/vgic-v3-sr.c
+++ b/virt/kvm/arm/hyp/vgic-v3-sr.c
@@ -349,10 +349,10 @@ void __hyp_text __vgic_v3_save_aprs(struct kvm_vcpu *vcpu)
case 7:
cpu_if->vgic_ap0r[3] = __vgic_v3_read_ap0rn(3);
cpu_if->vgic_ap0r[2] = __vgic_v3_read_ap0rn(2);
- /* Fall through */
+ fallthrough;
case 6:
cpu_if->vgic_ap0r[1] = __vgic_v3_read_ap0rn(1);
- /* Fall through */
+ fallthrough;
default:
cpu_if->vgic_ap0r[0] = __vgic_v3_read_ap0rn(0);
}
@@ -361,10 +361,10 @@ void __hyp_text __vgic_v3_save_aprs(struct kvm_vcpu *vcpu)
case 7:
cpu_if->vgic_ap1r[3] = __vgic_v3_read_ap1rn(3);
cpu_if->vgic_ap1r[2] = __vgic_v3_read_ap1rn(2);
- /* Fall through */
+ fallthrough;
case 6:
cpu_if->vgic_ap1r[1] = __vgic_v3_read_ap1rn(1);
- /* Fall through */
+ fallthrough;
default:
cpu_if->vgic_ap1r[0] = __vgic_v3_read_ap1rn(0);
}
@@ -386,10 +386,10 @@ void __hyp_text __vgic_v3_restore_aprs(struct kvm_vcpu *vcpu)
case 7:
__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[3], 3);
__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[2], 2);
- /* Fall through */
+ fallthrough;
case 6:
__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[1], 1);
- /* Fall through */
+ fallthrough;
default:
__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[0], 0);
}
@@ -398,10 +398,10 @@ void __hyp_text __vgic_v3_restore_aprs(struct kvm_vcpu *vcpu)
case 7:
__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[3], 3);
__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[2], 2);
- /* Fall through */
+ fallthrough;
case 6:
__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[1], 1);
- /* Fall through */
+ fallthrough;
default:
__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[0], 0);
}
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
` (2 preceding siblings ...)
2020-03-11 4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
2020-03-13 19:26 ` Alexander Sverdlin
2020-03-11 4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
` (3 subsequent siblings)
7 siblings, 1 reply; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Hartley Sweeten, Alexander Sverdlin
Cc: Russell King, linux-arm-kernel, linux-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm/mach-ep93xx/crunch.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
index 1c05c5b..f02e978 100644
--- a/arch/arm/mach-ep93xx/crunch.c
+++ b/arch/arm/mach-ep93xx/crunch.c
@@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
* FALLTHROUGH: Ensure we don't try to overwrite our newly
* initialised state information on the first fault.
*/
- /* Fall through */
-
+ fallthrough;
case THREAD_NOTIFY_EXIT:
crunch_task_release(thread);
break;
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH -next 009/491] ARM/Amlogic Meson SoC support: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
` (3 preceding siblings ...)
2020-03-11 4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
` (2 subsequent siblings)
7 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Kevin Hilman
Cc: linux-amlogic, Ulf Hansson, linux-mmc, linux-kernel, linux-arm-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/mmc/host/meson-mx-sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
index 8b038e..d35d81 100644
--- a/drivers/mmc/host/meson-mx-sdio.c
+++ b/drivers/mmc/host/meson-mx-sdio.c
@@ -291,7 +291,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
switch (ios->power_mode) {
case MMC_POWER_OFF:
vdd = 0;
- /* fall through */
+ fallthrough;
case MMC_POWER_UP:
if (!IS_ERR(mmc->supply.vmmc)) {
host->error = mmc_regulator_set_ocr(mmc,
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
` (4 preceding siblings ...)
2020-03-11 4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
2020-03-13 14:26 ` Wolfram Sang
2020-03-14 1:17 ` Stephen Boyd
2020-03-11 4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
[not found] ` <2e6818291503f032e7662f1fa45fb64c7751a7ae.1583896348.git.joe@perches.com>
7 siblings, 2 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Sylwester Nawrocki, Tomasz Figa,
Chanwoo Choi
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette, linux-kernel,
linux-i2c, linux-clk, linux-arm-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/clk/samsung/clk-s3c2443.c | 2 +-
drivers/i2c/busses/i2c-s3c2410.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/samsung/clk-s3c2443.c b/drivers/clk/samsung/clk-s3c2443.c
index 5f30fe7..c7aba1e 100644
--- a/drivers/clk/samsung/clk-s3c2443.c
+++ b/drivers/clk/samsung/clk-s3c2443.c
@@ -387,7 +387,7 @@ void __init s3c2443_common_clk_init(struct device_node *np, unsigned long xti_f,
ARRAY_SIZE(s3c2450_gates));
samsung_clk_register_alias(ctx, s3c2450_aliases,
ARRAY_SIZE(s3c2450_aliases));
- /* fall through - as s3c2450 extends the s3c2416 clocks */
+ fallthrough; /* as s3c2450 extends the s3c2416 clocks */
case S3C2416:
samsung_clk_register_div(ctx, s3c2416_dividers,
ARRAY_SIZE(s3c2416_dividers));
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index c98ef4c..dd1264 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -435,8 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
* fall through to the write state, as we will need to
* send a byte as well
*/
- /* Fall through */
-
+ fallthrough;
case STATE_WRITE:
/*
* we are writing data to the device... check for the
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: Use fallthrough;
[not found] <cover.1583896344.git.joe@perches.com>
` (5 preceding siblings ...)
2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
@ 2020-03-11 4:51 ` Joe Perches
[not found] ` <2e6818291503f032e7662f1fa45fb64c7751a7ae.1583896348.git.joe@perches.com>
7 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw)
To: Jun Nie, Shawn Guo
Cc: alsa-devel, linux-kernel, Takashi Iwai, Liam Girdwood,
Mark Brown, Jaroslav Kysela, linux-arm-kernel
Convert the various uses of fallthrough comments to fallthrough;
Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Signed-off-by: Joe Perches <joe@perches.com>
---
sound/soc/zte/zx-i2s.c | 4 ++--
sound/soc/zte/zx-spdif.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/zte/zx-i2s.c b/sound/soc/zte/zx-i2s.c
index 568cde6..1c1a44 100644
--- a/sound/soc/zte/zx-i2s.c
+++ b/sound/soc/zte/zx-i2s.c
@@ -294,7 +294,7 @@ static int zx_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
zx_i2s_rx_dma_en(zx_i2s->reg_base, true);
else
zx_i2s_tx_dma_en(zx_i2s->reg_base, true);
- /* fall thru */
+ fallthrough;
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (capture)
@@ -308,7 +308,7 @@ static int zx_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
zx_i2s_rx_dma_en(zx_i2s->reg_base, false);
else
zx_i2s_tx_dma_en(zx_i2s->reg_base, false);
- /* fall thru */
+ fallthrough;
case SNDRV_PCM_TRIGGER_SUSPEND:
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
if (capture)
diff --git a/sound/soc/zte/zx-spdif.c b/sound/soc/zte/zx-spdif.c
index a3a07c0..b4168bd 100644
--- a/sound/soc/zte/zx-spdif.c
+++ b/sound/soc/zte/zx-spdif.c
@@ -218,7 +218,7 @@ static int zx_spdif_trigger(struct snd_pcm_substream *substream, int cmd,
val = readl_relaxed(zx_spdif->reg_base + ZX_FIFOCTRL);
val |= ZX_FIFOCTRL_TX_FIFO_RST;
writel_relaxed(val, zx_spdif->reg_base + ZX_FIFOCTRL);
- /* fall thru */
+ fallthrough;
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
zx_spdif_cfg_tx(zx_spdif->reg_base, true);
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Joe Perches
@ 2020-03-11 5:15 ` Masahiro Yamada
2020-03-11 14:31 ` Joe Perches
0 siblings, 1 reply; 24+ messages in thread
From: Masahiro Yamada @ 2020-03-11 5:15 UTC (permalink / raw)
To: Joe Perches
Cc: Greg Kroah-Hartman, Linux Kernel Mailing List, linux-arm-kernel,
linux-serial, Jiri Slaby
On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
>
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"
> ---
> drivers/tty/serial/8250/8250_uniphier.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index e0b73a5..a2978ab 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
> break;
> case UART_LCR:
> valshift = 8;
> - /* fall through */
> + fallthrough;
> case UART_MCR:
> offset = UNIPHIER_UART_LCR_MCR;
> break;
> @@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
> case UART_SCR:
> /* No SCR for this hardware. Use CHAR as a scratch register */
> valshift = 8;
> - /* fall through */
> + fallthrough;
> case UART_FCR:
> offset = UNIPHIER_UART_CHAR_FCR;
> break;
> @@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
> valshift = 8;
> /* Divisor latch access bit does not exist. */
> value &= ~UART_LCR_DLAB;
> - /* fall through */
> + fallthrough;
> case UART_MCR:
> offset = UNIPHIER_UART_LCR_MCR;
> break;
> --
> 2.24.0
>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;
[not found] ` <2e6818291503f032e7662f1fa45fb64c7751a7ae.1583896348.git.joe@perches.com>
@ 2020-03-11 8:46 ` Marc Gonzalez
2020-03-11 14:30 ` Joe Perches
0 siblings, 1 reply; 24+ messages in thread
From: Marc Gonzalez @ 2020-03-11 8:46 UTC (permalink / raw)
To: Joe Perches; +Cc: LKML, Linux ARM
[ Trimming recipients list ]
On 11/03/2020 05:51, Joe Perches wrote:
> Convert the various uses of fallthrough comments to fallthrough;
What is the rationale for such a change?
Portability to different tool-chains? Something else?
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
Message-ID <b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com>
not found
1 partial match found:
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;
2020-03-11 8:46 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Marc Gonzalez
@ 2020-03-11 14:30 ` Joe Perches
0 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-11 14:30 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: LKML, Linux ARM
On Wed, 2020-03-11 at 09:46 +0100, Marc Gonzalez wrote:
> On 11/03/2020 05:51, Joe Perches wrote:
> > Convert the various uses of fallthrough comments to fallthrough;
>
> What is the rationale for such a change?
> Portability to different tool-chains? Something else?
Converting /* fallthrough */ style comments to the pseudo-keyword fallthrough
allows clang 10 and higher to work at finding missing fallthroughs too.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-11 5:15 ` Masahiro Yamada
@ 2020-03-11 14:31 ` Joe Perches
2020-03-12 8:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 24+ messages in thread
From: Joe Perches @ 2020-03-11 14:31 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Greg Kroah-Hartman, Linux Kernel Mailing List, linux-arm-kernel,
linux-serial, Jiri Slaby
On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > Convert the various uses of fallthrough comments to fallthrough;
> >
> > Done via script
> > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
> But, I think the patch subject should be prefixed:
> "serial: 8250_uniphier:"
Yeah thanks, that's difficult to script though.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-11 14:31 ` Joe Perches
@ 2020-03-12 8:56 ` Greg Kroah-Hartman
2020-03-12 9:02 ` Masahiro Yamada
2020-03-12 9:03 ` Joe Perches
0 siblings, 2 replies; 24+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-12 8:56 UTC (permalink / raw)
To: Joe Perches
Cc: Linux Kernel Mailing List, Masahiro Yamada, linux-arm-kernel,
linux-serial, Jiri Slaby
On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > > Convert the various uses of fallthrough comments to fallthrough;
> > >
> > > Done via script
> > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> >
> > But, I think the patch subject should be prefixed:
> > "serial: 8250_uniphier:"
>
> Yeah thanks, that's difficult to script though.
>
>
Kernel development is hard :)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 8:56 ` Greg Kroah-Hartman
@ 2020-03-12 9:02 ` Masahiro Yamada
2020-03-12 9:36 ` Greg Kroah-Hartman
2020-03-12 9:37 ` Joe Perches
2020-03-12 9:03 ` Joe Perches
1 sibling, 2 replies; 24+ messages in thread
From: Masahiro Yamada @ 2020-03-12 9:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Joe Perches, Linux Kernel Mailing List, linux-arm-kernel,
linux-serial, Jiri Slaby
On Thu, Mar 12, 2020 at 5:56 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> > On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > > > Convert the various uses of fallthrough comments to fallthrough;
> > > >
> > > > Done via script
> > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > > >
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > >
> > > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > >
> > >
> > > But, I think the patch subject should be prefixed:
> > > "serial: 8250_uniphier:"
> >
> > Yeah thanks, that's difficult to script though.
> >
> >
>
> Kernel development is hard :)
It is strange to process this per-platform
and to send out a giant series that
consists of 491 patches.
This is very trivial conversion.
I think it is better to have a single patch
to convert all files under drivers/tty/serial/,
with the patch subject "serial:".
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 8:56 ` Greg Kroah-Hartman
2020-03-12 9:02 ` Masahiro Yamada
@ 2020-03-12 9:03 ` Joe Perches
1 sibling, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-12 9:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Linux Kernel Mailing List, Masahiro Yamada, linux-arm-kernel,
linux-serial, Jiri Slaby
On Thu, 2020-03-12 at 09:56 +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> > On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > > > Convert the various uses of fallthrough comments to fallthrough;
> > > >
> > > > Done via script
> > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > > >
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > >
> > > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > >
> > >
> > > But, I think the patch subject should be prefixed:
> > > "serial: 8250_uniphier:"
> >
> > Yeah thanks, that's difficult to script though.
> >
> >
>
> Kernel development is hard :)
Not really, kernel development processes are pretty stupid sometimes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 9:02 ` Masahiro Yamada
@ 2020-03-12 9:36 ` Greg Kroah-Hartman
2020-03-12 9:37 ` Joe Perches
1 sibling, 0 replies; 24+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-12 9:36 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Joe Perches, Linux Kernel Mailing List, linux-arm-kernel,
linux-serial, Jiri Slaby
On Thu, Mar 12, 2020 at 06:02:19PM +0900, Masahiro Yamada wrote:
> On Thu, Mar 12, 2020 at 5:56 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> > > On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > > > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > > > > Convert the various uses of fallthrough comments to fallthrough;
> > > > >
> > > > > Done via script
> > > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > > > >
> > > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > >
> > > > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > >
> > > >
> > > > But, I think the patch subject should be prefixed:
> > > > "serial: 8250_uniphier:"
> > >
> > > Yeah thanks, that's difficult to script though.
> > >
> > >
> >
> > Kernel development is hard :)
>
>
> It is strange to process this per-platform
> and to send out a giant series that
> consists of 491 patches.
>
> This is very trivial conversion.
>
> I think it is better to have a single patch
> to convert all files under drivers/tty/serial/,
> with the patch subject "serial:".
I agree.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 9:02 ` Masahiro Yamada
2020-03-12 9:36 ` Greg Kroah-Hartman
@ 2020-03-12 9:37 ` Joe Perches
2020-03-12 13:47 ` Theodore Y. Ts'o
1 sibling, 1 reply; 24+ messages in thread
From: Joe Perches @ 2020-03-12 9:37 UTC (permalink / raw)
To: Masahiro Yamada, Greg Kroah-Hartman
Cc: Linux Kernel Mailing List, linux-arm-kernel, linux-serial, Jiri Slaby
On Thu, 2020-03-12 at 18:02 +0900, Masahiro Yamada wrote:
> On Thu, Mar 12, 2020 at 5:56 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> > > On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > > > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
> > > > > Convert the various uses of fallthrough comments to fallthrough;
> > > > >
> > > > > Done via script
> > > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > > > >
> > > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > >
> > > > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > >
> > > >
> > > > But, I think the patch subject should be prefixed:
> > > > "serial: 8250_uniphier:"
> > >
> > > Yeah thanks, that's difficult to script though.
> > >
> > >
> >
> > Kernel development is hard :)
>
> It is strange to process this per-platform
> and to send out a giant series that
> consists of 491 patches.
>
> This is very trivial conversion.
>
> I think it is better to have a single patch
> to convert all files under drivers/tty/serial/,
> with the patch subject "serial:".
The difficulty there is determining where these
subsystem spanning blocks should begin and end.
That could not be done for instance with drivers/net.
As I have suggested a few times, better still
would be to have a mechanism for scripted patches
applied possibly as single treewide patch.
Likely applied only at an -rc1.
The stated negatives to a treewide mechanism
have been difficulty to backport to -stable.
Perhaps a mechanism like
git format-patch --stdout <treewide_commit_to_backport> | \
git apply --include=<specific_files>
with some automated rewrite of the treewide patch subject
then commit could help.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough;
2020-03-11 4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
@ 2020-03-12 10:11 ` Russell King - ARM Linux admin
2020-03-12 10:19 ` Joe Perches
0 siblings, 1 reply; 24+ messages in thread
From: Russell King - ARM Linux admin @ 2020-03-12 10:11 UTC (permalink / raw)
To: Joe Perches
Cc: linux-scsi, James E.J. Bottomley, linux-arm-kernel,
Martin K. Petersen, linux-kernel
On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote:
> Convert the various uses of fallthrough comments to fallthrough;
And the point of what on the face of it seems to be useless churn is?
What compilers support this?
I'd check the gcc manual, but debian doesn't provide it.
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/mach-rpc/riscpc.c | 2 +-
> drivers/scsi/arm/fas216.c | 17 ++++++-----------
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/mach-rpc/riscpc.c b/arch/arm/mach-rpc/riscpc.c
> index ea2c842..d23970b 100644
> --- a/arch/arm/mach-rpc/riscpc.c
> +++ b/arch/arm/mach-rpc/riscpc.c
> @@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag)
> switch (tag->u.acorn.vram_pages) {
> case 512:
> vram_size += PAGE_SIZE * 256;
> - /* Fall through - ??? */
> + fallthrough; /* ??? */
> case 256:
> vram_size += PAGE_SIZE * 256;
> default:
> diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
> index 6c68c230..bb18be 100644
> --- a/drivers/scsi/arm/fas216.c
> +++ b/drivers/scsi/arm/fas216.c
> @@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg)
> msgqueue_flush(&info->scsi.msgs);
> msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT);
> info->scsi.phase = PHASE_MSGOUT_EXPECT;
> - /* fall through */
> -
> + fallthrough;
> case async:
> dev->period = info->ifcfg.asyncperiod / 4;
> dev->sof = 0;
> @@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info)
> fas216_done(info, DID_ABORT);
> break;
> }
> - /* else, fall through */
> -
> + fallthrough;
> default: /* huh? */
> printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n",
> info->host->host_no, fas216_target(info), fas216_drv_phase(info));
> @@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
> case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out -> Status */
> case STATE(STAT_STATUS, PHASE_DATAIN): /* Data In -> Status */
> fas216_stoptransfer(info);
> - /* fall through */
> -
> + fallthrough;
> case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status */
> case STATE(STAT_STATUS, PHASE_MSGOUT): /* Message Out -> Status */
> case STATE(STAT_STATUS, PHASE_COMMAND): /* Command -> Status */
> @@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
> case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out -> Message In */
> case STATE(STAT_MESGIN, PHASE_DATAIN): /* Data In -> Message In */
> fas216_stoptransfer(info);
> - /* fall through */
> -
> + fallthrough;
> case STATE(STAT_MESGIN, PHASE_COMMAND): /* Command -> Message In */
> case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In */
> case STATE(STAT_MESGIN, PHASE_MSGOUT): /* Message Out -> Message In */
> @@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned
> fas216_message(info);
> break;
> }
> - /* else, fall through */
> -
> + fallthrough;
> default:
> fas216_log(info, 0, "internal phase %s for function done?"
> " What do I do with this?",
> @@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info)
> switch (where_from) {
> case TYPE_QUEUE:
> fas216_allocate_tag(info, SCpnt);
> - /* fall through */
> + fallthrough;
> case TYPE_OTHER:
> fas216_start_command(info, SCpnt);
> break;
> --
> 2.24.0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough;
2020-03-12 10:11 ` Russell King - ARM Linux admin
@ 2020-03-12 10:19 ` Joe Perches
0 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-12 10:19 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: linux-scsi, James E.J. Bottomley, linux-arm-kernel,
Martin K. Petersen, linux-kernel
On Thu, 2020-03-12 at 10:11 +0000, Russell King - ARM Linux admin wrote:
> On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote:
> > Convert the various uses of fallthrough comments to fallthrough;
>
> And the point of what on the face of it seems to be useless churn is?
>
> What compilers support this?
gcc 7.1, clang 9
clang does not support the /* fallthrough */ comment styles.
clang does support the __attribute__((__fallthrough__))
and the c++17 [[fallthrough]] weirdness.
see:
commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo
keyword for switch/case use")
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 9:37 ` Joe Perches
@ 2020-03-12 13:47 ` Theodore Y. Ts'o
2020-03-12 14:15 ` Joe Perches
0 siblings, 1 reply; 24+ messages in thread
From: Theodore Y. Ts'o @ 2020-03-12 13:47 UTC (permalink / raw)
To: Joe Perches
Cc: Greg Kroah-Hartman, Masahiro Yamada, Linux Kernel Mailing List,
linux-serial, Jiri Slaby, linux-arm-kernel
On Thu, Mar 12, 2020 at 02:37:31AM -0700, Joe Perches wrote:
> As I have suggested a few times, better still
> would be to have a mechanism for scripted patches
> applied possibly as single treewide patch.
>
> Likely applied only at an -rc1.
>
> The stated negatives to a treewide mechanism
> have been difficulty to backport to -stable.
Any time we do a massive, disruptive change to the code base, it's
going to cause problems to -stable. It means that bug fix patches
won't necessarily auto-apply, and some will require manual fixups
afterwards
Given that this change doesn't really fix any bugs, I'd have to ask
the question --- is it *worth* it? We really need to apply a certain
amount of cost/benefit analysis around this.
If it were really important, the thing we could do is to apply a
single treewide patch at some point after the merge window. I'd
suggest after -rc2, myself, but reasonable people can differ. And
then, if it were *really* important we could run the same script on
the stable kernels.
But for changing "/* fallthrough */" to "fallthrough;"
Does this ***really*** matter? Why are we tying ourselves up in knots
trying to do this all at once?
- Ted
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
2020-03-12 13:47 ` Theodore Y. Ts'o
@ 2020-03-12 14:15 ` Joe Perches
0 siblings, 0 replies; 24+ messages in thread
From: Joe Perches @ 2020-03-12 14:15 UTC (permalink / raw)
To: Theodore Y. Ts'o
Cc: Greg Kroah-Hartman, Masahiro Yamada, Linux Kernel Mailing List,
linux-serial, Jiri Slaby, linux-arm-kernel
On Thu, 2020-03-12 at 09:47 -0400, Theodore Y. Ts'o wrote:
> On Thu, Mar 12, 2020 at 02:37:31AM -0700, Joe Perches wrote:
> > As I have suggested a few times, better still
> > would be to have a mechanism for scripted patches
> > applied possibly as single treewide patch.
> >
> > Likely applied only at an -rc1.
> >
> > The stated negatives to a treewide mechanism
> > have been difficulty to backport to -stable.
>
> Any time we do a massive, disruptive change to the code base, it's
> going to cause problems to -stable. It means that bug fix patches
> won't necessarily auto-apply, and some will require manual fixups
> afterwards
That's mostly a tools problem than a real problem.
> Given that this change doesn't really fix any bugs, I'd have to ask
> the question --- is it *worth* it? We really need to apply a certain
> amount of cost/benefit analysis around this.
>
> If it were really important, the thing we could do is to apply a
> single treewide patch at some point after the merge window. I'd
> suggest after -rc2, myself, but reasonable people can differ. And
> then, if it were *really* important we could run the same script on
> the stable kernels.
>
> But for changing "/* fallthrough */" to "fallthrough;"
>
> Does this ***really*** matter?
That depends a bit on whether clang is your
compiler of choice.
> Why are we tying ourselves up in knots
> trying to do this all at once?
Discretely or treewide, all at once or done over time,
the impact problem to backports is the same.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;
2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
@ 2020-03-13 14:26 ` Wolfram Sang
2020-03-14 1:17 ` Stephen Boyd
1 sibling, 0 replies; 24+ messages in thread
From: Wolfram Sang @ 2020-03-13 14:26 UTC (permalink / raw)
To: Joe Perches
Cc: linux-samsung-soc, Stephen Boyd, Michael Turquette, Tomasz Figa,
Krzysztof Kozlowski, linux-kernel, Chanwoo Choi, Kukjin Kim,
linux-i2c, Sylwester Nawrocki, linux-clk, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 375 bytes --]
On Tue, Mar 10, 2020 at 09:51:24PM -0700, Joe Perches wrote:
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de> # for the I2C part
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;
2020-03-11 4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
@ 2020-03-13 19:26 ` Alexander Sverdlin
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Sverdlin @ 2020-03-13 19:26 UTC (permalink / raw)
To: Joe Perches; +Cc: Hartley Sweeten, Russell King, linux-arm-kernel, linux-kernel
Hello Joe,
On Tue, 10 Mar 2020 21:51:22 -0700
Joe Perches <joe@perches.com> wrote:
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
I think the patch is OK, but the automatically-generated first
commit message line has a room for improvement.
But, as I understood, it has chances to be re-sent as one patch for
all files.
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/mach-ep93xx/crunch.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
> index 1c05c5b..f02e978 100644
> --- a/arch/arm/mach-ep93xx/crunch.c
> +++ b/arch/arm/mach-ep93xx/crunch.c
> @@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
> * FALLTHROUGH: Ensure we don't try to overwrite our newly
> * initialised state information on the first fault.
> */
> - /* Fall through */
> -
> + fallthrough;
> case THREAD_NOTIFY_EXIT:
> crunch_task_release(thread);
> break;
--
Alexander Sverdlin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;
2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-13 14:26 ` Wolfram Sang
@ 2020-03-14 1:17 ` Stephen Boyd
2020-05-13 11:59 ` Sylwester Nawrocki
1 sibling, 1 reply; 24+ messages in thread
From: Stephen Boyd @ 2020-03-14 1:17 UTC (permalink / raw)
To: Chanwoo Choi, Joe Perches, Krzysztof Kozlowski, Kukjin Kim,
Sylwester Nawrocki, Tomasz Figa
Cc: linux-samsung-soc, Michael Turquette, linux-kernel, linux-i2c,
linux-clk, linux-arm-kernel
Quoting Joe Perches (2020-03-10 21:51:24)
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
This link doesn't work for me. It leads to a redirect for
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
> drivers/clk/samsung/clk-s3c2443.c | 2 +-
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;
2020-03-14 1:17 ` Stephen Boyd
@ 2020-05-13 11:59 ` Sylwester Nawrocki
0 siblings, 0 replies; 24+ messages in thread
From: Sylwester Nawrocki @ 2020-05-13 11:59 UTC (permalink / raw)
To: Stephen Boyd, Joe Perches
Cc: linux-samsung-soc, Michael Turquette, Tomasz Figa,
Krzysztof Kozlowski, linux-kernel, Chanwoo Choi, Kukjin Kim,
linux-i2c, linux-clk, linux-arm-kernel
On 14.03.2020 02:17, Stephen Boyd wrote:
> Quoting Joe Perches (2020-03-10 21:51:24)
>> Convert the various uses of fallthrough comments to fallthrough;
>>
>> Done via script
>> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>>
>
> This link doesn't work for me. It leads to a redirect for
>
> https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
>
>> drivers/clk/samsung/clk-s3c2443.c | 2 +-
>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
I have changed the link to
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
and applied.
--
Thanks,
Sylwester
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-05-13 11:59 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Joe Perches
2020-03-11 5:15 ` Masahiro Yamada
2020-03-11 14:31 ` Joe Perches
2020-03-12 8:56 ` Greg Kroah-Hartman
2020-03-12 9:02 ` Masahiro Yamada
2020-03-12 9:36 ` Greg Kroah-Hartman
2020-03-12 9:37 ` Joe Perches
2020-03-12 13:47 ` Theodore Y. Ts'o
2020-03-12 14:15 ` Joe Perches
2020-03-12 9:03 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
2020-03-12 10:11 ` Russell King - ARM Linux admin
2020-03-12 10:19 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
2020-03-11 4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
2020-03-13 19:26 ` Alexander Sverdlin
2020-03-11 4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
2020-03-11 4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-13 14:26 ` Wolfram Sang
2020-03-14 1:17 ` Stephen Boyd
2020-05-13 11:59 ` Sylwester Nawrocki
2020-03-11 4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
[not found] ` <2e6818291503f032e7662f1fa45fb64c7751a7ae.1583896348.git.joe@perches.com>
2020-03-11 8:46 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Marc Gonzalez
2020-03-11 14:30 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).