* [PATCH v1] pinctrl: actions: fix function group name for i2c0_group
@ 2020-04-13 6:05 Amit Singh Tomar
2020-04-16 11:10 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Amit Singh Tomar @ 2020-04-13 6:05 UTC (permalink / raw)
To: andre.przywara, matheus, manivannan.sadhasivam, afaerber, linus.walleij
Cc: linux-gpio, linux-actions, linux-arm-kernel, Amit Singh Tomar
After commit 6f87359e8bca ("pinctrl: actions: Fix functions groups names
for S700 SoC") following error has been observed while booting Linux on
Cubieboard7-lite(based on S700 SoC).
[ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
This commit fixes it by using correct name for i2c0_group.
Fixes: 6f87359e8bca ("pinctrl: actions: Fix functions groups names for S700 SoC")
Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
---
Changes since previous version:
* Removed the white space from commit message.
* Used the 12 digits for commit hash.
* Passed it through checkpatch script.
---
drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
index 47a4ccd..f579a65 100644
--- a/drivers/pinctrl/actions/pinctrl-s700.c
+++ b/drivers/pinctrl/actions/pinctrl-s700.c
@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
static const char * const i2c0_groups[] = {
"uart0_rx_mfp",
"uart0_tx_mfp",
- "i2c0_mfp_mfp",
+ "i2c0_mfp",
};
static const char * const i2c1_groups[] = {
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] pinctrl: actions: fix function group name for i2c0_group
2020-04-13 6:05 [PATCH v1] pinctrl: actions: fix function group name for i2c0_group Amit Singh Tomar
@ 2020-04-16 11:10 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-04-16 11:10 UTC (permalink / raw)
To: Amit Singh Tomar
Cc: Matheus Castello, Andre Przywara, linux-actions,
open list:GPIO SUBSYSTEM, Manivannan Sadhasivam,
Andreas Färber, Linux ARM
On Mon, Apr 13, 2020 at 8:05 AM Amit Singh Tomar <amittomer25@gmail.com> wrote:
> After commit 6f87359e8bca ("pinctrl: actions: Fix functions groups names
> for S700 SoC") following error has been observed while booting Linux on
> Cubieboard7-lite(based on S700 SoC).
>
> [ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
>
> This commit fixes it by using correct name for i2c0_group.
>
> Fixes: 6f87359e8bca ("pinctrl: actions: Fix functions groups names for S700 SoC")
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
Patch applied with Mani's ACK.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-16 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 6:05 [PATCH v1] pinctrl: actions: fix function group name for i2c0_group Amit Singh Tomar
2020-04-16 11:10 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).