* [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
@ 2020-07-20 10:58 Jagan Teki
2020-07-22 18:34 ` Heiko Stuebner
2020-07-22 19:21 ` Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Jagan Teki @ 2020-07-20 10:58 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: devicetree, linux-kernel, linux-rockchip, Jagan Teki,
Suniel Mahesh, William Wu, Michael Trimarchi, linux-amarula,
linux-arm-kernel
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but
rk3288w ohci can work well.
So add usb host0 ohci node in rk3288 dtsi and the quirk in
ohci platform driver will disable ohci on rk3288.
Cc: William Wu <william.wu@rock-chips.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v3:
- none
arch/arm/boot/dts/rk3288.dtsi | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 0cd88774db95..f0774d9afb67 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -614,7 +614,16 @@ usb_host0_ehci: usb@ff500000 {
status = "disabled";
};
- /* NOTE: ohci@ff520000 doesn't actually work on hardware */
+ /* NOTE: doesn't work on RK3288, but fixed on RK3288W */
+ usb_host0_ohci: usb@ff520000 {
+ compatible = "generic-ohci";
+ reg = <0x0 0xff520000 0x0 0x100>;
+ interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru HCLK_USBHOST0>;
+ phys = <&usbphy1>;
+ phy-names = "usb";
+ status = "disabled";
+ };
usb_host1: usb@ff540000 {
compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
2020-07-20 10:58 [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 Jagan Teki
@ 2020-07-22 18:34 ` Heiko Stuebner
2020-07-22 18:46 ` Jagan Teki
2020-07-22 19:21 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: Heiko Stuebner @ 2020-07-22 18:34 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, linux-kernel, linux-rockchip, Rob Herring,
Suniel Mahesh, William Wu, Michael Trimarchi, linux-amarula,
linux-arm-kernel
Hi Jaganm
Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
> rk3288 and rk3288w have a usb host0 ohci controller.
>
> Although rk3288 ohci doesn't actually work on hardware, but
> rk3288w ohci can work well.
>
> So add usb host0 ohci node in rk3288 dtsi and the quirk in
> ohci platform driver will disable ohci on rk3288.
If I remember the discussion correctly, we expect the board dts
or the bootloader to enable the ohci, right?
So that block go away ... just making sure, I don't remember
untrue stuff ;-)
Heiko
> Cc: William Wu <william.wu@rock-chips.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v3:
> - none
>
> arch/arm/boot/dts/rk3288.dtsi | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 0cd88774db95..f0774d9afb67 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -614,7 +614,16 @@ usb_host0_ehci: usb@ff500000 {
> status = "disabled";
> };
>
> - /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */
> + usb_host0_ohci: usb@ff520000 {
> + compatible = "generic-ohci";
> + reg = <0x0 0xff520000 0x0 0x100>;
> + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_USBHOST0>;
> + phys = <&usbphy1>;
> + phy-names = "usb";
> + status = "disabled";
> + };
>
> usb_host1: usb@ff540000 {
> compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
2020-07-22 18:34 ` Heiko Stuebner
@ 2020-07-22 18:46 ` Jagan Teki
2020-07-22 18:49 ` Heiko Stuebner
0 siblings, 1 reply; 5+ messages in thread
From: Jagan Teki @ 2020-07-22 18:46 UTC (permalink / raw)
To: Heiko Stuebner, Robin Murphy
Cc: devicetree, linux-kernel, open list:ARM/Rockchip SoC...,
Rob Herring, Suniel Mahesh, William Wu, Michael Trimarchi,
linux-amarula, linux-arm-kernel
Hi Heiko,
On Thu, Jul 23, 2020 at 12:04 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Jaganm
>
> Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
> > rk3288 and rk3288w have a usb host0 ohci controller.
> >
> > Although rk3288 ohci doesn't actually work on hardware, but
> > rk3288w ohci can work well.
> >
> > So add usb host0 ohci node in rk3288 dtsi and the quirk in
> > ohci platform driver will disable ohci on rk3288.
>
> If I remember the discussion correctly, we expect the board dts
> or the bootloader to enable the ohci, right?
> So that block go away ... just making sure, I don't remember
> untrue stuff ;-)
Our (with Robin) initial discussion [1] is to manage OHCI enablement
in the bootloader but since it requires many checks at bootloader
level we finally rely on board dts to enable it as normal.
[1] https://lkml.org/lkml/2020/7/3/424
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
2020-07-22 18:46 ` Jagan Teki
@ 2020-07-22 18:49 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-07-22 18:49 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, linux-amarula, linux-kernel,
open list:ARM/Rockchip SoC...,
Rob Herring, Suniel Mahesh, William Wu, Michael Trimarchi,
Robin Murphy, linux-arm-kernel
Am Mittwoch, 22. Juli 2020, 20:46:55 CEST schrieb Jagan Teki:
> Hi Heiko,
>
> On Thu, Jul 23, 2020 at 12:04 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Jaganm
> >
> > Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
> > > rk3288 and rk3288w have a usb host0 ohci controller.
> > >
> > > Although rk3288 ohci doesn't actually work on hardware, but
> > > rk3288w ohci can work well.
> > >
> > > So add usb host0 ohci node in rk3288 dtsi and the quirk in
> > > ohci platform driver will disable ohci on rk3288.
> >
> > If I remember the discussion correctly, we expect the board dts
> > or the bootloader to enable the ohci, right?
> > So that block go away ... just making sure, I don't remember
> > untrue stuff ;-)
>
> Our (with Robin) initial discussion [1] is to manage OHCI enablement
> in the bootloader but since it requires many checks at bootloader
> level we finally rely on board dts to enable it as normal.
ok, so I'll just drop this paragraph when applying.
>
> [1] https://lkml.org/lkml/2020/7/3/424
>
> Jagan.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
2020-07-20 10:58 [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 Jagan Teki
2020-07-22 18:34 ` Heiko Stuebner
@ 2020-07-22 19:21 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-07-22 19:21 UTC (permalink / raw)
To: Jagan Teki, Rob Herring
Cc: devicetree, Heiko Stuebner, linux-kernel, linux-rockchip,
Suniel Mahesh, William Wu, Michael Trimarchi, linux-amarula,
linux-arm-kernel
On Mon, 20 Jul 2020 16:28:46 +0530, Jagan Teki wrote:
> rk3288 and rk3288w have a usb host0 ohci controller.
>
> Although rk3288 ohci doesn't actually work on hardware, but
> rk3288w ohci can work well.
>
> So add usb host0 ohci node in rk3288 dtsi and the quirk in
> ohci platform driver will disable ohci on rk3288.
Applied, thanks!
[1/1] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
commit: 82540defdd9cfc491f564ffb8d01911966636bc7
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-22 19:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 10:58 [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 Jagan Teki
2020-07-22 18:34 ` Heiko Stuebner
2020-07-22 18:46 ` Jagan Teki
2020-07-22 18:49 ` Heiko Stuebner
2020-07-22 19:21 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).