* [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
@ 2020-07-27 17:11 Wei Yongjun
2020-07-31 6:54 ` Chun-Hung Wu
2020-08-05 6:29 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-07-27 17:11 UTC (permalink / raw)
To: Hulk Robot, Chaotian Jing, Ulf Hansson, Matthias Brugger, Chun-Hung Wu
Cc: linux-mmc, linux-mediatek, Wei Yongjun, linux-arm-kernel
The sparse tool complains as follows:
drivers/mmc/host/mtk-sd.c:2269:6: warning:
symbol 'msdc_cqe_disable' was not declared. Should it be static?
This function is not used outside of mtk-sd.c, so this commit
marks it static.
Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 734e403a142e..4e2583f69a63 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
msdc_set_timeout(host, 1000000000ULL, 0);
}
-void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
+static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
{
struct msdc_host *host = mmc_priv(mmc);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
@ 2020-07-31 6:54 ` Chun-Hung Wu
2020-08-05 6:29 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Chun-Hung Wu @ 2020-07-31 6:54 UTC (permalink / raw)
To: Wei Yongjun
Cc: Ulf Hansson, linux-mmc, Hulk Robot, linux-mediatek,
Chaotian Jing (井朝天),
Matthias Brugger, linux-arm-kernel
On Tue, 2020-07-28 at 01:11 +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
> symbol 'msdc_cqe_disable' was not declared. Should it be static?
>
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
> msdc_set_timeout(host, 1000000000ULL, 0);
> }
>
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> {
> struct msdc_host *host = mmc_priv(mmc);
>
>
Acked-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static
2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
2020-07-31 6:54 ` Chun-Hung Wu
@ 2020-08-05 6:29 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-08-05 6:29 UTC (permalink / raw)
To: Wei Yongjun
Cc: Chun-Hung Wu, linux-mmc, Hulk Robot,
moderated list:ARM/Mediatek SoC support, Chaotian Jing,
Matthias Brugger, Linux ARM
On Mon, 27 Jul 2020 at 19:11, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/mmc/host/mtk-sd.c:2269:6: warning:
> symbol 'msdc_cqe_disable' was not declared. Should it be static?
>
> This function is not used outside of mtk-sd.c, so this commit
> marks it static.
>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 734e403a142e..4e2583f69a63 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2266,7 +2266,7 @@ static void msdc_cqe_enable(struct mmc_host *mmc)
> msdc_set_timeout(host, 1000000000ULL, 0);
> }
>
> -void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> +static void msdc_cqe_disable(struct mmc_host *mmc, bool recovery)
> {
> struct msdc_host *host = mmc_priv(mmc);
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-05 6:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 17:11 [PATCH -next] mmc: mediatek: make function msdc_cqe_disable() static Wei Yongjun
2020-07-31 6:54 ` Chun-Hung Wu
2020-08-05 6:29 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).