* [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
@ 2020-09-14 5:38 Chunfeng Yun
2020-09-14 6:12 ` Greg Kroah-Hartman
2020-09-24 7:50 ` Felipe Balbi
0 siblings, 2 replies; 6+ messages in thread
From: Chunfeng Yun @ 2020-09-14 5:38 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Greg Kroah-Hartman, Kevin Cernekee,
linux-kernel, stable, Chunfeng Yun, linux-usb,
bcm-kernel-feedback-list, Matthias Brugger, linux-mediatek,
linux-arm-kernel
Fix up the build error caused by undeclared usb_debug_root
Cc: stable <stable@vger.kernel.org>
Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/gadget/udc/bcm63xx_udc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
index feaec00..9cd4a70 100644
--- a/drivers/usb/gadget/udc/bcm63xx_udc.c
+++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
@@ -26,6 +26,7 @@
#include <linux/seq_file.h>
#include <linux/slab.h>
#include <linux/timer.h>
+#include <linux/usb.h>
#include <linux/usb/ch9.h>
#include <linux/usb/gadget.h>
#include <linux/workqueue.h>
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
2020-09-14 5:38 [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root Chunfeng Yun
@ 2020-09-14 6:12 ` Greg Kroah-Hartman
2020-09-14 6:16 ` Chunfeng Yun
2020-09-24 7:50 ` Felipe Balbi
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2020-09-14 6:12 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Felipe Balbi, Florian Fainelli, Kevin Cernekee, linux-kernel,
stable, linux-usb, bcm-kernel-feedback-list, Matthias Brugger,
linux-mediatek, linux-arm-kernel
On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote:
> Fix up the build error caused by undeclared usb_debug_root
>
> Cc: stable <stable@vger.kernel.org>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
Nit, you need a ' ' before the '(' character...
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
2020-09-14 6:12 ` Greg Kroah-Hartman
@ 2020-09-14 6:16 ` Chunfeng Yun
0 siblings, 0 replies; 6+ messages in thread
From: Chunfeng Yun @ 2020-09-14 6:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, Florian Fainelli, Kevin Cernekee, linux-kernel,
stable, linux-usb, bcm-kernel-feedback-list, Matthias Brugger,
linux-mediatek, linux-arm-kernel
On Mon, 2020-09-14 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote:
> > Fix up the build error caused by undeclared usb_debug_root
> >
> > Cc: stable <stable@vger.kernel.org>
> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
>
> Nit, you need a ' ' before the '(' character...
Ok, thanks
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
2020-09-14 5:38 [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root Chunfeng Yun
2020-09-14 6:12 ` Greg Kroah-Hartman
@ 2020-09-24 7:50 ` Felipe Balbi
2020-09-24 8:28 ` Chunfeng Yun
1 sibling, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2020-09-24 7:50 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Greg Kroah-Hartman, Kevin Cernekee,
linux-kernel, stable, Chunfeng Yun, linux-usb,
bcm-kernel-feedback-list, Matthias Brugger, linux-mediatek,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Fix up the build error caused by undeclared usb_debug_root
>
> Cc: stable <stable@vger.kernel.org>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
$ patch -p1 --dry-run p.patch
/usr/bin/patch: **** Only garbage was found in the patch input.
--
balbi
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
2020-09-24 7:50 ` Felipe Balbi
@ 2020-09-24 8:28 ` Chunfeng Yun
2020-09-24 8:52 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Chunfeng Yun @ 2020-09-24 8:28 UTC (permalink / raw)
To: Felipe Balbi
Cc: Florian Fainelli, Greg Kroah-Hartman, Kevin Cernekee,
linux-kernel, stable, linux-usb, bcm-kernel-feedback-list,
Matthias Brugger, linux-mediatek, linux-arm-kernel
On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
>
> > Fix up the build error caused by undeclared usb_debug_root
> >
> > Cc: stable <stable@vger.kernel.org>
> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>
> $ patch -p1 --dry-run p.patch
> /usr/bin/patch: **** Only garbage was found in the patch input.
>
Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
I indeed add a line code
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root
2020-09-24 8:28 ` Chunfeng Yun
@ 2020-09-24 8:52 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2020-09-24 8:52 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Florian Fainelli, Greg Kroah-Hartman, Kevin Cernekee,
linux-kernel, stable, linux-usb, bcm-kernel-feedback-list,
Matthias Brugger, linux-mediatek, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]
Hi,
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
>> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
>>
>> > Fix up the build error caused by undeclared usb_debug_root
>> >
>> > Cc: stable <stable@vger.kernel.org>
>> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> $ patch -p1 --dry-run p.patch
>> /usr/bin/patch: **** Only garbage was found in the patch input.
>>
> Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
> I indeed add a line code
that worked, but the problem I have is that your patches always come
base64 encoded. Make sure they come as plain text in the future :-)
--
balbi
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-24 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 5:38 [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root Chunfeng Yun
2020-09-14 6:12 ` Greg Kroah-Hartman
2020-09-14 6:16 ` Chunfeng Yun
2020-09-24 7:50 ` Felipe Balbi
2020-09-24 8:28 ` Chunfeng Yun
2020-09-24 8:52 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).