* [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()
@ 2020-09-21 3:45 Xu Wang
2020-09-26 2:50 ` Barry Song
2020-10-14 2:54 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Xu Wang @ 2020-09-21 3:45 UTC (permalink / raw)
To: mturquette, sboyd, baohua, linux-clk, linux-arm-kernel
Cc: linux-kernel, Xu Wang
In case of error, the function clk_register() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/clk/sirf/clk-prima2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sirf/clk-prima2.c b/drivers/clk/sirf/clk-prima2.c
index 45dcbc9e0302..d17b345f4d2d 100644
--- a/drivers/clk/sirf/clk-prima2.c
+++ b/drivers/clk/sirf/clk-prima2.c
@@ -134,7 +134,7 @@ static void __init prima2_clk_init(struct device_node *np)
for (i = pll1; i < maxclk; i++) {
prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
- BUG_ON(!prima2_clks[i]);
+ BUG_ON(IS_ERR(prima2_clks[i]));
}
clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
clk_register_clkdev(prima2_clks[io], NULL, "io");
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()
2020-09-21 3:45 [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init() Xu Wang
@ 2020-09-26 2:50 ` Barry Song
2020-10-14 2:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Barry Song @ 2020-09-26 2:50 UTC (permalink / raw)
To: Xu Wang; +Cc: sboyd, Michael Turquette, linux-clk, linux-arm-kernel, LKML
Xu Wang <vulab@iscas.ac.cn> 于2020年9月21日周一 下午3:45写道:
>
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Barry Song <baohua@kernel.org>
Thanks
> ---
> drivers/clk/sirf/clk-prima2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sirf/clk-prima2.c b/drivers/clk/sirf/clk-prima2.c
> index 45dcbc9e0302..d17b345f4d2d 100644
> --- a/drivers/clk/sirf/clk-prima2.c
> +++ b/drivers/clk/sirf/clk-prima2.c
> @@ -134,7 +134,7 @@ static void __init prima2_clk_init(struct device_node *np)
>
> for (i = pll1; i < maxclk; i++) {
> prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
> - BUG_ON(!prima2_clks[i]);
> + BUG_ON(IS_ERR(prima2_clks[i]));
> }
> clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
> clk_register_clkdev(prima2_clks[io], NULL, "io");
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()
2020-09-21 3:45 [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init() Xu Wang
2020-09-26 2:50 ` Barry Song
@ 2020-10-14 2:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-10-14 2:54 UTC (permalink / raw)
To: Xu Wang, baohua, linux-arm-kernel, linux-clk, mturquette
Cc: linux-kernel, Xu Wang
Quoting Xu Wang (2020-09-20 20:45:22)
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-14 2:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 3:45 [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init() Xu Wang
2020-09-26 2:50 ` Barry Song
2020-10-14 2:54 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).