linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
Date: Mon, 13 Jan 2020 11:19:16 +0530	[thread overview]
Message-ID: <1602b7831356274792ce5a84fb44d701@codeaurora.org> (raw)
In-Reply-To: <20191219232615.GA22811@bogus>

On 2019-12-20 04:56, Rob Herring wrote:
> On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote:
>> Convert QCOM watchdog timer bindings to DT schema format using
>> json-schema.
>> 
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>>  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
>>  .../bindings/watchdog/qcom-wdt.yaml           | 47 
>> +++++++++++++++++++
>>  2 files changed, 47 insertions(+), 28 deletions(-)
>>  delete mode 100644 
>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>  create mode 100644 
>> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> 
> 
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml 
>> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> new file mode 100644
>> index 000000000000..4a42f4261322
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
>> +
>> +maintainers:
>> +  - Andy Gross <agross@kernel.org>
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: qcom,kpss-timer
>> +      - const: qcom,kpss-wdt
>> +      - const: qcom,kpss-wdt-apq8064
>> +      - const: qcom,kpss-wdt-ipq4019
>> +      - const: qcom,kpss-wdt-ipq8064
>> +      - const: qcom,kpss-wdt-msm8960
>> +      - const: qcom,scss-timer
> 
> An 'enum' is better than oneOf+const.
> 

Will change.

>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  timeout-sec:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description:
>> +      Contains the watchdog timeout in seconds. If unset, the
>> +      default timeout is 30 seconds.
> 
> Include watchdog.yaml and don't redefine this.
> 

Ok

>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +
>> +examples:
>> +  - |
>> +    watchdog@208a038 {
>> +      compatible = "qcom,kpss-wdt-ipq8064";
>> +      reg = <0x0208a038 0x40>;
>> +      clocks = <&sleep_clk>;
>> +      timeout-sec = <10>;
>> +    };
>> ---
>> 
>> I have added Andy as the maintainer here since the get_maintainer 
>> script
>> showed him. If he is not happy, then I can change it to Bjorn probably 
>> and
>> again if he is not happy ;-) then I will add myself or whoever they 
>> suggest.
> 
> Add yourself.
> 

Sure will add myself.


Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-13  5:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13  4:53 [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2019-12-13  4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
2019-12-19 23:26   ` Rob Herring
2020-01-13  5:49     ` Sai Prakash Ranjan [this message]
2019-12-13  4:53 ` [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2019-12-19 23:28   ` Rob Herring
2020-01-13  5:47     ` Sai Prakash Ranjan
2019-12-13  4:53 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer Sai Prakash Ranjan
2019-12-20  0:40   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1602b7831356274792ce5a84fb44d701@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mka@chromium.org \
    --cc=robh@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).